Re: [PATCH] of: When constructing the bus id consider assigned-addresses as well

2012-12-03 Thread Grant Likely
On Fri, 30 Nov 2012 17:49:48 -0700, Jason Gunthorpe wrote: > On Fri, Nov 30, 2012 at 09:48:05AM +, Grant Likely wrote: > > > > If you attempt to stick a 'reg' in a block nested below a > > > 'device_type="pci"' the kernel throws lots of error messsages and > > > generates bad address

Re: [PATCH] of: When constructing the bus id consider assigned-addresses as well

2012-12-03 Thread Grant Likely
On Fri, 30 Nov 2012 17:49:48 -0700, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: On Fri, Nov 30, 2012 at 09:48:05AM +, Grant Likely wrote: If you attempt to stick a 'reg' in a block nested below a 'device_type=pci' the kernel throws lots of error messsages and generates

Re: [PATCH] of: When constructing the bus id consider assigned-addresses as well

2012-11-30 Thread Jason Gunthorpe
On Fri, Nov 30, 2012 at 09:48:05AM +, Grant Likely wrote: > > If you attempt to stick a 'reg' in a block nested below a > > 'device_type="pci"' the kernel throws lots of error messsages and > > generates bad address mappings. > > Have you added the appropriate #address-cells and #size-cells

Re: [PATCH] of: When constructing the bus id consider assigned-addresses as well

2012-11-30 Thread Grant Likely
On Thu, 29 Nov 2012 12:38:29 -0700, Jason Gunthorpe wrote: > On Thu, Nov 29, 2012 at 04:26:48PM +, Grant Likely wrote: > > > Hmmm. okay that makes sense, but something still isn't quite right. So > > of_translate_address should take care of drilling down through the bus > > layers, and when

Re: [PATCH] of: When constructing the bus id consider assigned-addresses as well

2012-11-30 Thread Grant Likely
On Thu, 29 Nov 2012 12:38:29 -0700, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: On Thu, Nov 29, 2012 at 04:26:48PM +, Grant Likely wrote: Hmmm. okay that makes sense, but something still isn't quite right. So of_translate_address should take care of drilling down through the

Re: [PATCH] of: When constructing the bus id consider assigned-addresses as well

2012-11-30 Thread Jason Gunthorpe
On Fri, Nov 30, 2012 at 09:48:05AM +, Grant Likely wrote: If you attempt to stick a 'reg' in a block nested below a 'device_type=pci' the kernel throws lots of error messsages and generates bad address mappings. Have you added the appropriate #address-cells and #size-cells to the pci

Re: [PATCH] of: When constructing the bus id consider assigned-addresses as well

2012-11-29 Thread Jason Gunthorpe
On Thu, Nov 29, 2012 at 04:26:48PM +, Grant Likely wrote: > Hmmm. okay that makes sense, but something still isn't quite right. So > of_translate_address should take care of drilling down through the bus > layers, and when it gets to the PCI node it /should/ use > of_bus_pci_translate to

Re: [PATCH] of: When constructing the bus id consider assigned-addresses as well

2012-11-29 Thread Grant Likely
On Mon, 26 Nov 2012 11:20:54 -0700, Jason Gunthorpe wrote: > On Mon, Nov 26, 2012 at 02:03:16PM +, Grant Likely wrote: > > On Wed, 21 Nov 2012 14:02:40 -0700, Jason Gunthorpe > > wrote: > > > 'assigned-addresses' is used for certain PCI device type nodes in > > > lieu of 'reg', since this

Re: [PATCH] of: When constructing the bus id consider assigned-addresses as well

2012-11-29 Thread Grant Likely
On Mon, 26 Nov 2012 11:20:54 -0700, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: On Mon, Nov 26, 2012 at 02:03:16PM +, Grant Likely wrote: On Wed, 21 Nov 2012 14:02:40 -0700, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: 'assigned-addresses' is used for certain PCI

Re: [PATCH] of: When constructing the bus id consider assigned-addresses as well

2012-11-29 Thread Jason Gunthorpe
On Thu, Nov 29, 2012 at 04:26:48PM +, Grant Likely wrote: Hmmm. okay that makes sense, but something still isn't quite right. So of_translate_address should take care of drilling down through the bus layers, and when it gets to the PCI node it /should/ use of_bus_pci_translate to handle

Re: [PATCH] of: When constructing the bus id consider assigned-addresses as well

2012-11-26 Thread Jason Gunthorpe
On Mon, Nov 26, 2012 at 02:03:16PM +, Grant Likely wrote: > On Wed, 21 Nov 2012 14:02:40 -0700, Jason Gunthorpe > wrote: > > 'assigned-addresses' is used for certain PCI device type nodes in > > lieu of 'reg', since this is enforced by of/address.c, have > > of_device_make_bus_id look there

Re: [PATCH] of: When constructing the bus id consider assigned-addresses as well

2012-11-26 Thread Grant Likely
On Wed, 21 Nov 2012 14:02:40 -0700, Jason Gunthorpe wrote: > 'assigned-addresses' is used for certain PCI device type nodes in > lieu of 'reg', since this is enforced by of/address.c, have > of_device_make_bus_id look there as well. > > Signed-off-by: Jason Gunthorpe If it is a PCI device,

Re: [PATCH] of: When constructing the bus id consider assigned-addresses as well

2012-11-26 Thread Grant Likely
On Wed, 21 Nov 2012 14:02:40 -0700, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: 'assigned-addresses' is used for certain PCI device type nodes in lieu of 'reg', since this is enforced by of/address.c, have of_device_make_bus_id look there as well. Signed-off-by: Jason Gunthorpe

Re: [PATCH] of: When constructing the bus id consider assigned-addresses as well

2012-11-26 Thread Jason Gunthorpe
On Mon, Nov 26, 2012 at 02:03:16PM +, Grant Likely wrote: On Wed, 21 Nov 2012 14:02:40 -0700, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: 'assigned-addresses' is used for certain PCI device type nodes in lieu of 'reg', since this is enforced by of/address.c, have

[PATCH] of: When constructing the bus id consider assigned-addresses as well

2012-11-21 Thread Jason Gunthorpe
'assigned-addresses' is used for certain PCI device type nodes in lieu of 'reg', since this is enforced by of/address.c, have of_device_make_bus_id look there as well. Signed-off-by: Jason Gunthorpe --- drivers/of/platform.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)

[PATCH] of: When constructing the bus id consider assigned-addresses as well

2012-11-21 Thread Jason Gunthorpe
'assigned-addresses' is used for certain PCI device type nodes in lieu of 'reg', since this is enforced by of/address.c, have of_device_make_bus_id look there as well. Signed-off-by: Jason Gunthorpe jguntho...@obsidianresearch.com --- drivers/of/platform.c |2 ++ 1 files changed, 2