Re: security review needed - Re: [PATCH] ohci: Turn remote DMA support into a module parameter

2014-01-12 Thread Stefan Richter
On Dec 23 Stefan Richter wrote: > On Dec 22 Lubomir Rintel wrote: > > This makes it possible to debug kernel over FireWire without the need to > > recompile it. > > > > Cc: Stefan Richter > > Cc: Dave Hansen > > Signed-off-by: Lubomir Rintel > > Looks good to me. A load-time option is prefera

security review needed - Re: [PATCH] ohci: Turn remote DMA support into a module parameter

2013-12-23 Thread Stefan Richter
On Dec 22 Lubomir Rintel wrote: > This makes it possible to debug kernel over FireWire without the need to > recompile it. > > Cc: Stefan Richter > Cc: Dave Hansen > Signed-off-by: Lubomir Rintel Looks good to me. A load-time option is preferable over a compile-time option not only from the P

[PATCH] ohci: Turn remote DMA support into a module parameter

2013-12-22 Thread Lubomir Rintel
This makes it possible to debug kernel over FireWire without the need to recompile it. Cc: Stefan Richter Cc: Dave Hansen Signed-off-by: Lubomir Rintel --- Documentation/debugging-via-ohci1394.txt | 4 +--- drivers/firewire/ohci.c | 19 +++ lib/Kconfig.debug