Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-08 Thread Miklos Szeredi
On Wed, Jan 7, 2015 at 4:04 PM, Seunghun Lee wrote: >> On 2015/1/6 22:02, Seunghun Lee wrote: >>> After patch: >>> root@qemux86:~# mount -t overlay overlay -olowerdir=lower:lower2 merged >>> mount: warning: merged seems to be mounted read-only. >>> root@qemux86:~# mount | grep overlay >>> overlay

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-08 Thread Miklos Szeredi
On Wed, Jan 7, 2015 at 4:04 PM, Seunghun Lee way...@gmail.com wrote: On 2015/1/6 22:02, Seunghun Lee wrote: After patch: root@qemux86:~# mount -t overlay overlay -olowerdir=lower:lower2 merged mount: warning: merged seems to be mounted read-only. root@qemux86:~# mount | grep overlay overlay

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-07 Thread Seunghun Lee
Hi Hu, On 01/07/2015 11:56 AM, hujianyang wrote: > Hi, > > There maybe some misunderstandings here. I think your patch really > fix an important problem, but not in correct way. > > On 2015/1/6 22:02, Seunghun Lee wrote: >> After patch: >> root@qemux86:~# mount -t overlay overlay

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-07 Thread Seunghun Lee
Hi Hu, On 01/07/2015 11:56 AM, hujianyang wrote: Hi, There maybe some misunderstandings here. I think your patch really fix an important problem, but not in correct way. On 2015/1/6 22:02, Seunghun Lee wrote: After patch: root@qemux86:~# mount -t overlay overlay -olowerdir=lower:lower2

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-06 Thread hujianyang
Hi, There maybe some misunderstandings here. I think your patch really fix an important problem, but not in correct way. On 2015/1/6 22:02, Seunghun Lee wrote: > > After patch: > root@qemux86:~# mount -t overlay overlay -olowerdir=lower:lower2 merged > mount: warning: merged seems to be mounted

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-06 Thread Seunghun Lee
On 01/04/2015 11:59 AM, hujianyang wrote: > I think this exporting of .remount_fs may allow people in userspace have the > ability to remount a filesystem with a new set of mounting options. Your new > adding function do nothing with the passing in parameters. I'm not sure if it > could be

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-06 Thread Seunghun Lee
On 01/04/2015 11:59 AM, hujianyang wrote: I think this exporting of .remount_fs may allow people in userspace have the ability to remount a filesystem with a new set of mounting options. Your new adding function do nothing with the passing in parameters. I'm not sure if it could be

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-06 Thread hujianyang
Hi, There maybe some misunderstandings here. I think your patch really fix an important problem, but not in correct way. On 2015/1/6 22:02, Seunghun Lee wrote: After patch: root@qemux86:~# mount -t overlay overlay -olowerdir=lower:lower2 merged mount: warning: merged seems to be mounted

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-03 Thread hujianyang
On 2015/1/3 1:26, Seunghun Lee wrote: > Overlayfs should be mounted read-only when upper-fs is read-only or > nonexistent. > But now it can be remounted read-write and this can cause kernel panic. > So we should prevent read-write remount when the above situation happens. > > Signed-off-by:

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-03 Thread hujianyang
On 2015/1/3 1:26, Seunghun Lee wrote: Overlayfs should be mounted read-only when upper-fs is read-only or nonexistent. But now it can be remounted read-write and this can cause kernel panic. So we should prevent read-write remount when the above situation happens. Signed-off-by: Seunghun

[PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-02 Thread Seunghun Lee
Overlayfs should be mounted read-only when upper-fs is read-only or nonexistent. But now it can be remounted read-write and this can cause kernel panic. So we should prevent read-write remount when the above situation happens. Signed-off-by: Seunghun Lee --- fs/overlayfs/super.c | 11

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-02 Thread Seunghun Lee
On 01/02/2015 03:33 AM, Sedat Dilek wrote: > On Thu, Jan 1, 2015 at 4:38 PM, Seunghun Lee wrote: >> Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. >> But now it can be remounted read-write and this can causes kernel panic. >> So we should prevent read-write remount

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-02 Thread Seunghun Lee
On 01/02/2015 03:33 AM, Sedat Dilek wrote: On Thu, Jan 1, 2015 at 4:38 PM, Seunghun Lee way...@gmail.com wrote: Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. But now it can be remounted read-write and this can causes kernel panic. So we should prevent read-write

[PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-02 Thread Seunghun Lee
Overlayfs should be mounted read-only when upper-fs is read-only or nonexistent. But now it can be remounted read-write and this can cause kernel panic. So we should prevent read-write remount when the above situation happens. Signed-off-by: Seunghun Lee way...@gmail.com --- fs/overlayfs/super.c

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-01 Thread Sedat Dilek
On Thu, Jan 1, 2015 at 4:38 PM, Seunghun Lee wrote: > Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. > But now it can be remounted read-write and this can causes kernel panic. > So we should prevent read-write remount when the above situation. > Cannot say much to the

[PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-01 Thread Seunghun Lee
Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. But now it can be remounted read-write and this can causes kernel panic. So we should prevent read-write remount when the above situation. Signed-off-by: Seunghun Lee --- fs/overlayfs/super.c | 11 +++ 1 file

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-01 Thread Seunghun Lee
On 01/02/2015 12:24 AM, Sedat Dilek wrote: > On Thu, Jan 1, 2015 at 4:13 PM, Richard Weinberger > wrote: >> On Thu, Jan 1, 2015 at 6:07 AM, Seunghun Lee wrote: >>> Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. >>> But now it can be remounted read-write and this can

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-01 Thread Sedat Dilek
On Thu, Jan 1, 2015 at 4:13 PM, Richard Weinberger wrote: > On Thu, Jan 1, 2015 at 6:07 AM, Seunghun Lee wrote: >> Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. >> But now it can be remounted read-write and this can causes kernel panic. >> So we should prevent

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-01 Thread Richard Weinberger
On Thu, Jan 1, 2015 at 6:07 AM, Seunghun Lee wrote: > Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. > But now it can be remounted read-write and this can causes kernel panic. > So we should prevent read-write remount when the above situation. > > Signed-off-by:

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-01 Thread Richard Weinberger
On Thu, Jan 1, 2015 at 6:07 AM, Seunghun Lee way...@gmail.com wrote: Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. But now it can be remounted read-write and this can causes kernel panic. So we should prevent read-write remount when the above situation.

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-01 Thread Seunghun Lee
On 01/02/2015 12:24 AM, Sedat Dilek wrote: On Thu, Jan 1, 2015 at 4:13 PM, Richard Weinberger richard.weinber...@gmail.com wrote: On Thu, Jan 1, 2015 at 6:07 AM, Seunghun Lee way...@gmail.com wrote: Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. But now it can be

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-01 Thread Sedat Dilek
On Thu, Jan 1, 2015 at 4:13 PM, Richard Weinberger richard.weinber...@gmail.com wrote: On Thu, Jan 1, 2015 at 6:07 AM, Seunghun Lee way...@gmail.com wrote: Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. But now it can be remounted read-write and this can causes

[PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-01 Thread Seunghun Lee
Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. But now it can be remounted read-write and this can causes kernel panic. So we should prevent read-write remount when the above situation. Signed-off-by: Seunghun Lee way...@gmail.com --- fs/overlayfs/super.c | 11

Re: [PATCH] ovl: Prevent rw remount when it should be ro mount

2015-01-01 Thread Sedat Dilek
On Thu, Jan 1, 2015 at 4:38 PM, Seunghun Lee way...@gmail.com wrote: Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. But now it can be remounted read-write and this can causes kernel panic. So we should prevent read-write remount when the above situation. Cannot say

[PATCH] ovl: Prevent rw remount when it should be ro mount

2014-12-31 Thread Seunghun Lee
Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. But now it can be remounted read-write and this can causes kernel panic. So we should prevent read-write remount when the above situation. Signed-off-by: Seunghun Lee --- fs/overlayfs/super.c | 8 1 file

[PATCH] ovl: Prevent rw remount when it should be ro mount

2014-12-31 Thread Seunghun Lee
Overlayfs should be mounted read-only when upper fs is r/o or nonexistend. But now it can be remounted read-write and this can causes kernel panic. So we should prevent read-write remount when the above situation. Signed-off-by: Seunghun Lee way...@gmail.com --- fs/overlayfs/super.c | 8