Re: [PATCH] parisc: Remove FIXME comment

2014-07-18 Thread Nick Krause
On Sat, Jul 19, 2014 at 1:20 AM, James Bottomley wrote: > On Fri, 2014-07-18 at 22:25 -0400, Nick Krause wrote: >> On Fri, Jul 18, 2014 at 5:03 PM, James Bottomley >> wrote: >> > On Fri, 2014-07-18 at 16:37 -0400, Nicholas Krause wrote: >> >> The comment for size of frame not being needed is

Re: [PATCH] parisc: Remove FIXME comment

2014-07-18 Thread James Bottomley
On Fri, 2014-07-18 at 22:25 -0400, Nick Krause wrote: > On Fri, Jul 18, 2014 at 5:03 PM, James Bottomley > wrote: > > On Fri, 2014-07-18 at 16:37 -0400, Nicholas Krause wrote: > >> The comment for size of frame not being needed is incorrect , the > >> function called needs this parameter. > > > >

Re: [PATCH] parisc: Remove FIXME comment

2014-07-18 Thread Nick Krause
On Fri, Jul 18, 2014 at 5:03 PM, James Bottomley wrote: > On Fri, 2014-07-18 at 16:37 -0400, Nicholas Krause wrote: >> The comment for size of frame not being needed is incorrect , the >> function called needs this parameter. > > Actually, that's not correct. The point of the FIXME is that

Re: [PATCH] parisc: Remove FIXME comment

2014-07-18 Thread James Bottomley
On Fri, 2014-07-18 at 16:37 -0400, Nicholas Krause wrote: > The comment for size of frame not being needed is incorrect , the > function called needs this parameter. Actually, that's not correct. The point of the FIXME is that fram_size is only used in a debug print and could be eliminated since

Re: [PATCH] parisc: Remove FIXME comment

2014-07-18 Thread Helge Deller
On 07/18/2014 10:37 PM, Nicholas Krause wrote: > The comment for size of frame not being needed is incorrect , the > function called needs this parameter. Thanks for the patch Nicholas. It has been queued up: https://patchwork.kernel.org/patch/4587631/ and

[PATCH] parisc: Remove FIXME comment

2014-07-18 Thread Nicholas Krause
The comment for size of frame not being needed is incorrect , the function called needs this parameter. Signed-off-by: Nicholas Krause --- arch/parisc/kernel/signal.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/parisc/kernel/signal.c b/arch/parisc/kernel/signal.c index

[PATCH] parisc: Remove FIXME comment

2014-07-18 Thread Nicholas Krause
The comment for size of frame not being needed is incorrect , the function called needs this parameter. Signed-off-by: Nicholas Krause xerofo...@gmail.com --- arch/parisc/kernel/signal.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/parisc/kernel/signal.c b/arch/parisc/kernel/signal.c

Re: [PATCH] parisc: Remove FIXME comment

2014-07-18 Thread Helge Deller
On 07/18/2014 10:37 PM, Nicholas Krause wrote: The comment for size of frame not being needed is incorrect , the function called needs this parameter. Thanks for the patch Nicholas. It has been queued up: https://patchwork.kernel.org/patch/4587631/ and

Re: [PATCH] parisc: Remove FIXME comment

2014-07-18 Thread James Bottomley
On Fri, 2014-07-18 at 16:37 -0400, Nicholas Krause wrote: The comment for size of frame not being needed is incorrect , the function called needs this parameter. Actually, that's not correct. The point of the FIXME is that fram_size is only used in a debug print and could be eliminated since

Re: [PATCH] parisc: Remove FIXME comment

2014-07-18 Thread Nick Krause
On Fri, Jul 18, 2014 at 5:03 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Fri, 2014-07-18 at 16:37 -0400, Nicholas Krause wrote: The comment for size of frame not being needed is incorrect , the function called needs this parameter. Actually, that's not correct. The

Re: [PATCH] parisc: Remove FIXME comment

2014-07-18 Thread James Bottomley
On Fri, 2014-07-18 at 22:25 -0400, Nick Krause wrote: On Fri, Jul 18, 2014 at 5:03 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Fri, 2014-07-18 at 16:37 -0400, Nicholas Krause wrote: The comment for size of frame not being needed is incorrect , the function called

Re: [PATCH] parisc: Remove FIXME comment

2014-07-18 Thread Nick Krause
On Sat, Jul 19, 2014 at 1:20 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Fri, 2014-07-18 at 22:25 -0400, Nick Krause wrote: On Fri, Jul 18, 2014 at 5:03 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Fri, 2014-07-18 at 16:37 -0400, Nicholas Krause