Re: [PATCH] pci: do not try to assign irq 255

2013-09-10 Thread Bjorn Helgaas
On Tue, Mar 26, 2013 at 5:34 PM, Yinghai Lu wrote: > On Tue, Mar 26, 2013 at 2:54 PM, Bjorn Helgaas wrote: > >> Where are we at with this? I don't see Sarah's patch in the tree, and >> I haven't applied any changes, so my guess is this is still broken. > > Yes, the fix is in the linus tree. > >

Re: [PATCH] pci: do not try to assign irq 255

2013-09-10 Thread Bjorn Helgaas
On Tue, Mar 26, 2013 at 5:34 PM, Yinghai Lu ying...@kernel.org wrote: On Tue, Mar 26, 2013 at 2:54 PM, Bjorn Helgaas bhelg...@google.com wrote: Where are we at with this? I don't see Sarah's patch in the tree, and I haven't applied any changes, so my guess is this is still broken. Yes, the

Re: [PATCH] pci: do not try to assign irq 255

2013-03-26 Thread Yinghai Lu
On Tue, Mar 26, 2013 at 2:54 PM, Bjorn Helgaas wrote: > Where are we at with this? I don't see Sarah's patch in the tree, and > I haven't applied any changes, so my guess is this is still broken. Yes, the fix is in the linus tree.

Re: [PATCH] pci: do not try to assign irq 255

2013-03-26 Thread Bjorn Helgaas
On Tue, Mar 5, 2013 at 3:41 PM, Sarah Sharp wrote: > On Fri, Mar 01, 2013 at 08:41:13AM +0100, Hannes Reinecke wrote: >> On 02/27/2013 10:13 PM, Bjorn Helgaas wrote: >> >[+cc Andy] >> > >> >3) I don't understand why the xhci init fails in the first place. It >> >looks like the "request interrupt

Re: [PATCH] pci: do not try to assign irq 255

2013-03-26 Thread Bjorn Helgaas
On Tue, Mar 5, 2013 at 3:41 PM, Sarah Sharp sarah.a.sh...@linux.intel.com wrote: On Fri, Mar 01, 2013 at 08:41:13AM +0100, Hannes Reinecke wrote: On 02/27/2013 10:13 PM, Bjorn Helgaas wrote: [+cc Andy] 3) I don't understand why the xhci init fails in the first place. It looks like the

Re: [PATCH] pci: do not try to assign irq 255

2013-03-26 Thread Yinghai Lu
On Tue, Mar 26, 2013 at 2:54 PM, Bjorn Helgaas bhelg...@google.com wrote: Where are we at with this? I don't see Sarah's patch in the tree, and I haven't applied any changes, so my guess is this is still broken. Yes, the fix is in the linus tree.

Re: [PATCH] pci: do not try to assign irq 255

2013-03-05 Thread Sarah Sharp
On Fri, Mar 01, 2013 at 08:41:13AM +0100, Hannes Reinecke wrote: > On 02/27/2013 10:13 PM, Bjorn Helgaas wrote: > >[+cc Andy] > > > >3) I don't understand why the xhci init fails in the first place. It > >looks like the "request interrupt 255 failed" message is from > >xhci_try_enable_msi(), but

Re: [PATCH] pci: do not try to assign irq 255

2013-03-05 Thread Sarah Sharp
On Fri, Mar 01, 2013 at 08:41:13AM +0100, Hannes Reinecke wrote: On 02/27/2013 10:13 PM, Bjorn Helgaas wrote: [+cc Andy] 3) I don't understand why the xhci init fails in the first place. It looks like the request interrupt 255 failed message is from xhci_try_enable_msi(), but that function

Re: [PATCH] pci: do not try to assign irq 255

2013-02-28 Thread Hannes Reinecke
On 02/27/2013 10:13 PM, Bjorn Helgaas wrote: [+cc Andy] On Wed, Feb 20, 2013 at 11:53 PM, Hannes Reinecke wrote: On 02/20/2013 05:57 PM, Yinghai Lu wrote: On Tue, Feb 19, 2013 at 11:58 PM, Hannes Reinecke wrote: Apparently this device is meant to use MSI _only_ so the BIOS developer

Re: [PATCH] pci: do not try to assign irq 255

2013-02-28 Thread Hannes Reinecke
On 02/27/2013 10:13 PM, Bjorn Helgaas wrote: [+cc Andy] On Wed, Feb 20, 2013 at 11:53 PM, Hannes Reinecke wrote: On 02/20/2013 05:57 PM, Yinghai Lu wrote: On Tue, Feb 19, 2013 at 11:58 PM, Hannes Reinecke wrote: Apparently this device is meant to use MSI _only_ so the BIOS developer

Re: [PATCH] pci: do not try to assign irq 255

2013-02-28 Thread Hannes Reinecke
On 02/27/2013 10:13 PM, Bjorn Helgaas wrote: [+cc Andy] On Wed, Feb 20, 2013 at 11:53 PM, Hannes Reinecke h...@suse.de wrote: On 02/20/2013 05:57 PM, Yinghai Lu wrote: On Tue, Feb 19, 2013 at 11:58 PM, Hannes Reinecke h...@suse.de wrote: Apparently this device is meant to use MSI _only_

Re: [PATCH] pci: do not try to assign irq 255

2013-02-28 Thread Hannes Reinecke
On 02/27/2013 10:13 PM, Bjorn Helgaas wrote: [+cc Andy] On Wed, Feb 20, 2013 at 11:53 PM, Hannes Reinecke h...@suse.de wrote: On 02/20/2013 05:57 PM, Yinghai Lu wrote: On Tue, Feb 19, 2013 at 11:58 PM, Hannes Reinecke h...@suse.de wrote: Apparently this device is meant to use MSI _only_

Re: [PATCH] pci: do not try to assign irq 255

2013-02-27 Thread Bjorn Helgaas
[+cc Andy] On Wed, Feb 20, 2013 at 11:53 PM, Hannes Reinecke wrote: > On 02/20/2013 05:57 PM, Yinghai Lu wrote: >> >> On Tue, Feb 19, 2013 at 11:58 PM, Hannes Reinecke wrote: >>> Apparently this device is meant to use MSI _only_ so the BIOS developer >>> didn't feel the need to assign

Re: [PATCH] pci: do not try to assign irq 255

2013-02-27 Thread Bjorn Helgaas
[+cc Andy] On Wed, Feb 20, 2013 at 11:53 PM, Hannes Reinecke h...@suse.de wrote: On 02/20/2013 05:57 PM, Yinghai Lu wrote: On Tue, Feb 19, 2013 at 11:58 PM, Hannes Reinecke h...@suse.de wrote: Apparently this device is meant to use MSI _only_ so the BIOS developer didn't feel the need to

Re: [PATCH] pci: do not try to assign irq 255

2013-02-26 Thread Hannes Reinecke
On 02/26/2013 02:29 PM, David Härdeman wrote: On Thu, Feb 21, 2013 at 07:53:14AM +0100, Hannes Reinecke wrote: On 02/20/2013 05:57 PM, Yinghai Lu wrote: it seems you mess pin with interrupt line. current code: unsigned char irq; pci_read_config_byte(dev, PCI_INTERRUPT_PIN,

Re: [PATCH] pci: do not try to assign irq 255

2013-02-26 Thread David Härdeman
On Thu, Feb 21, 2013 at 07:53:14AM +0100, Hannes Reinecke wrote: >On 02/20/2013 05:57 PM, Yinghai Lu wrote: >>it seems you mess pin with interrupt line. >> >>current code: >> unsigned char irq; >> >> pci_read_config_byte(dev, PCI_INTERRUPT_PIN, ); >> dev->pin = irq; >>

Re: [PATCH] pci: do not try to assign irq 255

2013-02-26 Thread David Härdeman
On Thu, Feb 21, 2013 at 07:53:14AM +0100, Hannes Reinecke wrote: On 02/20/2013 05:57 PM, Yinghai Lu wrote: it seems you mess pin with interrupt line. current code: unsigned char irq; pci_read_config_byte(dev, PCI_INTERRUPT_PIN, irq); dev-pin = irq; if (irq)

Re: [PATCH] pci: do not try to assign irq 255

2013-02-26 Thread Hannes Reinecke
On 02/26/2013 02:29 PM, David Härdeman wrote: On Thu, Feb 21, 2013 at 07:53:14AM +0100, Hannes Reinecke wrote: On 02/20/2013 05:57 PM, Yinghai Lu wrote: it seems you mess pin with interrupt line. current code: unsigned char irq; pci_read_config_byte(dev, PCI_INTERRUPT_PIN,

Re: [PATCH] pci: do not try to assign irq 255

2013-02-20 Thread Hannes Reinecke
On 02/20/2013 05:57 PM, Yinghai Lu wrote: On Tue, Feb 19, 2013 at 11:58 PM, Hannes Reinecke wrote: Apparently this device is meant to use MSI _only_ so the BIOS developer didn't feel the need to assign an INTx here. According to PCI-3.0, section 6.8 (Message Signalled Interrupts): It is

Re: [PATCH] pci: do not try to assign irq 255

2013-02-20 Thread Yinghai Lu
On Tue, Feb 19, 2013 at 11:58 PM, Hannes Reinecke wrote: >> > Apparently this device is meant to use MSI _only_ so the BIOS developer > didn't feel the need to assign an INTx here. > > According to PCI-3.0, section 6.8 (Message Signalled Interrupts): >> It is recommended that devices implement

Re: [PATCH] pci: do not try to assign irq 255

2013-02-20 Thread Yinghai Lu
On Tue, Feb 19, 2013 at 11:58 PM, Hannes Reinecke h...@suse.de wrote: Apparently this device is meant to use MSI _only_ so the BIOS developer didn't feel the need to assign an INTx here. According to PCI-3.0, section 6.8 (Message Signalled Interrupts): It is recommended that devices

Re: [PATCH] pci: do not try to assign irq 255

2013-02-20 Thread Hannes Reinecke
On 02/20/2013 05:57 PM, Yinghai Lu wrote: On Tue, Feb 19, 2013 at 11:58 PM, Hannes Reinecke h...@suse.de wrote: Apparently this device is meant to use MSI _only_ so the BIOS developer didn't feel the need to assign an INTx here. According to PCI-3.0, section 6.8 (Message Signalled

Re: [PATCH] pci: do not try to assign irq 255

2013-02-19 Thread Hannes Reinecke
On 02/19/2013 08:40 PM, Yinghai Lu wrote: On Mon, Feb 18, 2013 at 2:09 AM, Hannes Reinecke wrote: The PCI config space reseves a byte for the interrupt line, so irq 255 actually refers to 'not set'. However, the 'irq' field for struct pci_dev is an integer, so the original meaning is lost,

Re: [PATCH] pci: do not try to assign irq 255

2013-02-19 Thread Frederik Himpe
On Tue, Feb 19, 2013 at 12:47:32PM -0700, Bjorn Helgaas wrote: > On Mon, Feb 18, 2013 at 3:09 AM, Hannes Reinecke wrote: > > The PCI config space reseves a byte for the interrupt line, > > so irq 255 actually refers to 'not set'. > > However, the 'irq' field for struct pci_dev is an integer, > >

Re: [PATCH] pci: do not try to assign irq 255

2013-02-19 Thread Bjorn Helgaas
On Mon, Feb 18, 2013 at 3:09 AM, Hannes Reinecke wrote: > The PCI config space reseves a byte for the interrupt line, > so irq 255 actually refers to 'not set'. > However, the 'irq' field for struct pci_dev is an integer, > so the original meaning is lost, causing the system to > assign an

Re: [PATCH] pci: do not try to assign irq 255

2013-02-19 Thread Yinghai Lu
On Mon, Feb 18, 2013 at 2:09 AM, Hannes Reinecke wrote: > The PCI config space reseves a byte for the interrupt line, > so irq 255 actually refers to 'not set'. > However, the 'irq' field for struct pci_dev is an integer, > so the original meaning is lost, causing the system to > assign an

Re: [PATCH] pci: do not try to assign irq 255

2013-02-19 Thread Yinghai Lu
On Mon, Feb 18, 2013 at 2:09 AM, Hannes Reinecke h...@suse.de wrote: The PCI config space reseves a byte for the interrupt line, so irq 255 actually refers to 'not set'. However, the 'irq' field for struct pci_dev is an integer, so the original meaning is lost, causing the system to assign an

Re: [PATCH] pci: do not try to assign irq 255

2013-02-19 Thread Bjorn Helgaas
On Mon, Feb 18, 2013 at 3:09 AM, Hannes Reinecke h...@suse.de wrote: The PCI config space reseves a byte for the interrupt line, so irq 255 actually refers to 'not set'. However, the 'irq' field for struct pci_dev is an integer, so the original meaning is lost, causing the system to assign an

Re: [PATCH] pci: do not try to assign irq 255

2013-02-19 Thread Frederik Himpe
On Tue, Feb 19, 2013 at 12:47:32PM -0700, Bjorn Helgaas wrote: On Mon, Feb 18, 2013 at 3:09 AM, Hannes Reinecke h...@suse.de wrote: The PCI config space reseves a byte for the interrupt line, so irq 255 actually refers to 'not set'. However, the 'irq' field for struct pci_dev is an integer,

Re: [PATCH] pci: do not try to assign irq 255

2013-02-19 Thread Hannes Reinecke
On 02/19/2013 08:40 PM, Yinghai Lu wrote: On Mon, Feb 18, 2013 at 2:09 AM, Hannes Reinecke h...@suse.de wrote: The PCI config space reseves a byte for the interrupt line, so irq 255 actually refers to 'not set'. However, the 'irq' field for struct pci_dev is an integer, so the original meaning

Re: [PATCH] pci: do not try to assign irq 255

2013-02-18 Thread David Härdeman
On Mon, Feb 18, 2013 at 11:09:53AM +0100, Hannes Reinecke wrote: >The PCI config space reseves a byte for the interrupt line, >so irq 255 actually refers to 'not set'. >However, the 'irq' field for struct pci_dev is an integer, >so the original meaning is lost, causing the system to >assign an

[PATCH] pci: do not try to assign irq 255

2013-02-18 Thread Hannes Reinecke
The PCI config space reseves a byte for the interrupt line, so irq 255 actually refers to 'not set'. However, the 'irq' field for struct pci_dev is an integer, so the original meaning is lost, causing the system to assign an interrupt '255', which fails. So we should _not_ assign an interrupt

[PATCH] pci: do not try to assign irq 255

2013-02-18 Thread Hannes Reinecke
The PCI config space reseves a byte for the interrupt line, so irq 255 actually refers to 'not set'. However, the 'irq' field for struct pci_dev is an integer, so the original meaning is lost, causing the system to assign an interrupt '255', which fails. So we should _not_ assign an interrupt

Re: [PATCH] pci: do not try to assign irq 255

2013-02-18 Thread David Härdeman
On Mon, Feb 18, 2013 at 11:09:53AM +0100, Hannes Reinecke wrote: The PCI config space reseves a byte for the interrupt line, so irq 255 actually refers to 'not set'. However, the 'irq' field for struct pci_dev is an integer, so the original meaning is lost, causing the system to assign an