Re: [PATCH] pci: quirk: Apply APM ACS quirk to XGene devices

2017-07-20 Thread Alex Williamson
On Tue, 18 Jul 2017 22:37:00 -0700 Feng Kan wrote: > > > > I don't know what that means, does the hardware support an equivalent > > to source validation or not? > > Yes, source validation is done through the smmu. The SMMU does a context lookup based on the bdf, but if the

Re: [PATCH] pci: quirk: Apply APM ACS quirk to XGene devices

2017-07-20 Thread Alex Williamson
On Tue, 18 Jul 2017 22:37:00 -0700 Feng Kan wrote: > > > > I don't know what that means, does the hardware support an equivalent > > to source validation or not? > > Yes, source validation is done through the smmu. The SMMU does a context lookup based on the bdf, but if the root port does

Re: [PATCH] pci: quirk: Apply APM ACS quirk to XGene devices

2017-07-18 Thread Feng Kan
> > I don't know what that means, does the hardware support an equivalent > to source validation or not? Yes, source validation is done through the smmu. What's the response of the root port if > the downstream device issues a transaction spoofing devices not within > the bus number ranges of

Re: [PATCH] pci: quirk: Apply APM ACS quirk to XGene devices

2017-07-18 Thread Feng Kan
> > I don't know what that means, does the hardware support an equivalent > to source validation or not? Yes, source validation is done through the smmu. What's the response of the root port if > the downstream device issues a transaction spoofing devices not within > the bus number ranges of

Re: [PATCH] pci: quirk: Apply APM ACS quirk to XGene devices

2017-07-18 Thread Alex Williamson
On Tue, 18 Jul 2017 10:42:40 -0700 Feng Kan wrote: > On Mon, Jul 17, 2017 at 7:23 PM, Alex Williamson > wrote: > > On Mon, 17 Jul 2017 17:45:52 -0700 > > Feng Kan wrote: > > > >> The APM X-Gene PCIe root port does not support ACS at

Re: [PATCH] pci: quirk: Apply APM ACS quirk to XGene devices

2017-07-18 Thread Alex Williamson
On Tue, 18 Jul 2017 10:42:40 -0700 Feng Kan wrote: > On Mon, Jul 17, 2017 at 7:23 PM, Alex Williamson > wrote: > > On Mon, 17 Jul 2017 17:45:52 -0700 > > Feng Kan wrote: > > > >> The APM X-Gene PCIe root port does not support ACS at this point. > >> Since the root does not allow peer to peer

Re: [PATCH] pci: quirk: Apply APM ACS quirk to XGene devices

2017-07-18 Thread Feng Kan
On Mon, Jul 17, 2017 at 7:23 PM, Alex Williamson wrote: > On Mon, 17 Jul 2017 17:45:52 -0700 > Feng Kan wrote: > >> The APM X-Gene PCIe root port does not support ACS at this point. >> Since the root does not allow peer to peer transactions, mask out >>

Re: [PATCH] pci: quirk: Apply APM ACS quirk to XGene devices

2017-07-18 Thread Feng Kan
On Mon, Jul 17, 2017 at 7:23 PM, Alex Williamson wrote: > On Mon, 17 Jul 2017 17:45:52 -0700 > Feng Kan wrote: > >> The APM X-Gene PCIe root port does not support ACS at this point. >> Since the root does not allow peer to peer transactions, mask out >> ACS capability flag bits. >> >>

Re: [PATCH] pci: quirk: Apply APM ACS quirk to XGene devices

2017-07-17 Thread Alex Williamson
On Mon, 17 Jul 2017 17:45:52 -0700 Feng Kan wrote: > The APM X-Gene PCIe root port does not support ACS at this point. > Since the root does not allow peer to peer transactions, mask out > ACS capability flag bits. > > Signed-off-by: Feng Kan > --- >

Re: [PATCH] pci: quirk: Apply APM ACS quirk to XGene devices

2017-07-17 Thread Alex Williamson
On Mon, 17 Jul 2017 17:45:52 -0700 Feng Kan wrote: > The APM X-Gene PCIe root port does not support ACS at this point. > Since the root does not allow peer to peer transactions, mask out > ACS capability flag bits. > > Signed-off-by: Feng Kan > --- > drivers/pci/quirks.c | 2 ++ > 1 file

[PATCH] pci: quirk: Apply APM ACS quirk to XGene devices

2017-07-17 Thread Feng Kan
The APM X-Gene PCIe root port does not support ACS at this point. Since the root does not allow peer to peer transactions, mask out ACS capability flag bits. Signed-off-by: Feng Kan --- drivers/pci/quirks.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/quirks.c

[PATCH] pci: quirk: Apply APM ACS quirk to XGene devices

2017-07-17 Thread Feng Kan
The APM X-Gene PCIe root port does not support ACS at this point. Since the root does not allow peer to peer transactions, mask out ACS capability flag bits. Signed-off-by: Feng Kan --- drivers/pci/quirks.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pci/quirks.c