Re: [PATCH] pci_raw_ops should use unsigned args

2005-02-07 Thread Greg KH
On Thu, Feb 03, 2005 at 12:08:05PM -0700, Bjorn Helgaas wrote: > Convert pci_raw_ops to use unsigned segment (aka domain), > bus, and devfn. With the previous code, various ia64 config > accesses fail due to segment sign-extension problems. > > ia64: > - With a signed seg >= 0x8, unwanted

Re: [PATCH] pci_raw_ops should use unsigned args

2005-02-07 Thread Greg KH
On Thu, Feb 03, 2005 at 12:08:05PM -0700, Bjorn Helgaas wrote: Convert pci_raw_ops to use unsigned segment (aka domain), bus, and devfn. With the previous code, various ia64 config accesses fail due to segment sign-extension problems. ia64: - With a signed seg = 0x8, unwanted

Re: [PATCH] pci_raw_ops should use unsigned args

2005-02-03 Thread Matthew Wilcox
On Thu, Feb 03, 2005 at 12:08:05PM -0700, Bjorn Helgaas wrote: > Convert pci_raw_ops to use unsigned segment (aka domain), > bus, and devfn. With the previous code, various ia64 config > accesses fail due to segment sign-extension problems. > > ia64: > - With a signed seg >= 0x8, unwanted

[PATCH] pci_raw_ops should use unsigned args

2005-02-03 Thread Bjorn Helgaas
Convert pci_raw_ops to use unsigned segment (aka domain), bus, and devfn. With the previous code, various ia64 config accesses fail due to segment sign-extension problems. ia64: - With a signed seg >= 0x8, unwanted sign-extension occurs when "seg << 28" is cast to u64 in

[PATCH] pci_raw_ops should use unsigned args

2005-02-03 Thread Bjorn Helgaas
Convert pci_raw_ops to use unsigned segment (aka domain), bus, and devfn. With the previous code, various ia64 config accesses fail due to segment sign-extension problems. ia64: - With a signed seg = 0x8, unwanted sign-extension occurs when seg 28 is cast to u64 in

Re: [PATCH] pci_raw_ops should use unsigned args

2005-02-03 Thread Matthew Wilcox
On Thu, Feb 03, 2005 at 12:08:05PM -0700, Bjorn Helgaas wrote: Convert pci_raw_ops to use unsigned segment (aka domain), bus, and devfn. With the previous code, various ia64 config accesses fail due to segment sign-extension problems. ia64: - With a signed seg = 0x8, unwanted