Re: [PATCH] perf, tools, stat: Avoid crash with --per-thread

2016-03-02 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 02, 2016 at 07:36:59AM +0100, Jiri Olsa escreveu: > On Tue, Mar 01, 2016 at 03:32:37PM -0800, Andi Kleen wrote: > > From: Andi Kleen > > > > Bug fix: > > > > The earlier metrics changes broke --per-thread causing a segfault. > > Handle this case correctly. We

Re: [PATCH] perf, tools, stat: Avoid crash with --per-thread

2016-03-02 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 02, 2016 at 07:36:59AM +0100, Jiri Olsa escreveu: > On Tue, Mar 01, 2016 at 03:32:37PM -0800, Andi Kleen wrote: > > From: Andi Kleen > > > > Bug fix: > > > > The earlier metrics changes broke --per-thread causing a segfault. > > Handle this case correctly. We actually don't print

Re: [PATCH] perf, tools, stat: Avoid crash with --per-thread

2016-03-01 Thread Jiri Olsa
On Tue, Mar 01, 2016 at 03:32:37PM -0800, Andi Kleen wrote: > From: Andi Kleen > > Bug fix: > > The earlier metrics changes broke --per-thread causing a segfault. > Handle this case correctly. We actually don't print metrics > in per thread mode, so using a 0 shadow CPU is

Re: [PATCH] perf, tools, stat: Avoid crash with --per-thread

2016-03-01 Thread Jiri Olsa
On Tue, Mar 01, 2016 at 03:32:37PM -0800, Andi Kleen wrote: > From: Andi Kleen > > Bug fix: > > The earlier metrics changes broke --per-thread causing a segfault. > Handle this case correctly. We actually don't print metrics > in per thread mode, so using a 0 shadow CPU is fine. right, so

[PATCH] perf, tools, stat: Avoid crash with --per-thread

2016-03-01 Thread Andi Kleen
From: Andi Kleen Bug fix: The earlier metrics changes broke --per-thread causing a segfault. Handle this case correctly. We actually don't print metrics in per thread mode, so using a 0 shadow CPU is fine. Could be folded into "perf, tools, stat: Support metrics in

[PATCH] perf, tools, stat: Avoid crash with --per-thread

2016-03-01 Thread Andi Kleen
From: Andi Kleen Bug fix: The earlier metrics changes broke --per-thread causing a segfault. Handle this case correctly. We actually don't print metrics in per thread mode, so using a 0 shadow CPU is fine. Could be folded into "perf, tools, stat: Support metrics in --per-core/socket mode"