Re: [PATCH] perf/intel: Remove Perfmon-v4 counter_freezing support

2021-01-26 Thread Paolo Bonzini
On 26/01/21 12:35, Xu, Like wrote: Ah, now we have the v3 version on guest PEBS feature. It does not rely on counter_freezing, but disables the co-existence of guest PEBS and host PEBS. I am not clear about your attitude towards this co-existence. There are also more interesting topics for

Re: [PATCH] perf/intel: Remove Perfmon-v4 counter_freezing support

2021-01-26 Thread Peter Zijlstra
On Tue, Jan 26, 2021 at 10:51:39AM +0100, Paolo Bonzini wrote: > What is the state of this work? I was expecting a new version that doesn't > use counter_freezing. However, I see that counter_freezing is still in > there, so this patch from Peter has never been applied. Bah, I forgot about it.

Re: [PATCH] perf/intel: Remove Perfmon-v4 counter_freezing support

2021-01-26 Thread Xu, Like
On 2021/1/26 17:51, Paolo Bonzini wrote: On 11/11/20 03:42, Xu, Like wrote: Hi Peter, On 2020/11/11 4:52, Stephane Eranian wrote: On Tue, Nov 10, 2020 at 7:37 AM Peter Zijlstra  wrote: On Tue, Nov 10, 2020 at 04:12:57PM +0100, Peter Zijlstra wrote: On Mon, Nov 09, 2020 at 10:12:37AM +0800,

Re: [PATCH] perf/intel: Remove Perfmon-v4 counter_freezing support

2021-01-26 Thread Paolo Bonzini
On 11/11/20 03:42, Xu, Like wrote: Hi Peter, On 2020/11/11 4:52, Stephane Eranian wrote: On Tue, Nov 10, 2020 at 7:37 AM Peter Zijlstra wrote: On Tue, Nov 10, 2020 at 04:12:57PM +0100, Peter Zijlstra wrote: On Mon, Nov 09, 2020 at 10:12:37AM +0800, Like Xu wrote: The Precise Event Based

Re: [PATCH] perf/intel: Remove Perfmon-v4 counter_freezing support

2020-11-15 Thread Like Xu
Hi Peter, On 2020/11/10 23:37, Peter Zijlstra wrote: -static int __init intel_perf_counter_freezing_setup(char *s) -{ - bool res; - - if (kstrtobool(s, )) - return -EINVAL; - - disable_counter_freezing = !res; - return 1; -} -__setup("perf_v4_pmi=",

Re: [PATCH] perf/intel: Remove Perfmon-v4 counter_freezing support

2020-11-11 Thread Peter Zijlstra
On Tue, Nov 10, 2020 at 12:52:04PM -0800, Stephane Eranian wrote: > What is implemented is Freeze-on-Overflow, yet it is described as > Freeze-on-PMI. > That, in itself, is a problem. I agree with you on that point. Exactly. > However, there are use cases for both modes. > > I can sample on

Re: [PATCH] perf/intel: Remove Perfmon-v4 counter_freezing support

2020-11-10 Thread Xu, Like
Hi Peter, On 2020/11/11 4:52, Stephane Eranian wrote: On Tue, Nov 10, 2020 at 7:37 AM Peter Zijlstra wrote: On Tue, Nov 10, 2020 at 04:12:57PM +0100, Peter Zijlstra wrote: On Mon, Nov 09, 2020 at 10:12:37AM +0800, Like Xu wrote: The Precise Event Based Sampling(PEBS) supported on Intel Ice

Re: [PATCH] perf/intel: Remove Perfmon-v4 counter_freezing support

2020-11-10 Thread Stephane Eranian
On Tue, Nov 10, 2020 at 7:37 AM Peter Zijlstra wrote: > > On Tue, Nov 10, 2020 at 04:12:57PM +0100, Peter Zijlstra wrote: > > On Mon, Nov 09, 2020 at 10:12:37AM +0800, Like Xu wrote: > > > The Precise Event Based Sampling(PEBS) supported on Intel Ice Lake server > > > platforms can provide an

[PATCH] perf/intel: Remove Perfmon-v4 counter_freezing support

2020-11-10 Thread Peter Zijlstra
On Tue, Nov 10, 2020 at 04:12:57PM +0100, Peter Zijlstra wrote: > On Mon, Nov 09, 2020 at 10:12:37AM +0800, Like Xu wrote: > > The Precise Event Based Sampling(PEBS) supported on Intel Ice Lake server > > platforms can provide an architectural state of the instruction executed > > after the