Re: [PATCH] perf/probe: Search both .eh_frame and .debug_frame sections for probe location

2015-09-24 Thread Mark Wielaard
On Thu, 2015-09-24 at 10:56 +, 平松雅巳 / HIRAMATU,MASAMI wrote: > >I am not too familiar with the code so there might be a reason for > >setting and reusing the pf->cfi to do the search twice. But might it not > >be more clear to just store both pf->cfi_eh and pf->cfi_debug and then > >check both

RE: [PATCH] perf/probe: Search both .eh_frame and .debug_frame sections for probe location

2015-09-24 Thread 平松雅巳 / HIRAMATU,MASAMI
From: Mark Wielaard [mailto:m...@redhat.com] > >Hi Hemant, > >On Thu, 2015-09-24 at 07:46 +0530, Hemant Kumar wrote: >> perf probe through debuginfo__find_probes() in util/probe-finder.c >> checks for the functions' frame descriptions in either .eh_frame section >> of an ELF or the .debug_frame.

Re: [PATCH] perf/probe: Search both .eh_frame and .debug_frame sections for probe location

2015-09-24 Thread Mark Wielaard
Hi Hemant, On Thu, 2015-09-24 at 07:46 +0530, Hemant Kumar wrote: > perf probe through debuginfo__find_probes() in util/probe-finder.c > checks for the functions' frame descriptions in either .eh_frame section > of an ELF or the .debug_frame. The check is based on whether either one > of these

Re: [PATCH] perf/probe: Search both .eh_frame and .debug_frame sections for probe location

2015-09-24 Thread Mark Wielaard
Hi Hemant, On Thu, 2015-09-24 at 07:46 +0530, Hemant Kumar wrote: > perf probe through debuginfo__find_probes() in util/probe-finder.c > checks for the functions' frame descriptions in either .eh_frame section > of an ELF or the .debug_frame. The check is based on whether either one > of these

RE: [PATCH] perf/probe: Search both .eh_frame and .debug_frame sections for probe location

2015-09-24 Thread 平松雅巳 / HIRAMATU,MASAMI
From: Mark Wielaard [mailto:m...@redhat.com] > >Hi Hemant, > >On Thu, 2015-09-24 at 07:46 +0530, Hemant Kumar wrote: >> perf probe through debuginfo__find_probes() in util/probe-finder.c >> checks for the functions' frame descriptions in either .eh_frame section >> of an ELF or the .debug_frame.

Re: [PATCH] perf/probe: Search both .eh_frame and .debug_frame sections for probe location

2015-09-24 Thread Mark Wielaard
On Thu, 2015-09-24 at 10:56 +, 平松雅巳 / HIRAMATU,MASAMI wrote: > >I am not too familiar with the code so there might be a reason for > >setting and reusing the pf->cfi to do the search twice. But might it not > >be more clear to just store both pf->cfi_eh and pf->cfi_debug and then > >check both

[PATCH] perf/probe: Search both .eh_frame and .debug_frame sections for probe location

2015-09-23 Thread Hemant Kumar
perf probe through debuginfo__find_probes() in util/probe-finder.c checks for the functions' frame descriptions in either .eh_frame section of an ELF or the .debug_frame. The check is based on whether either one of these sections is present. But sometimes, it may happen that, .eh_frame, even if

[PATCH] perf/probe: Search both .eh_frame and .debug_frame sections for probe location

2015-09-23 Thread Hemant Kumar
perf probe through debuginfo__find_probes() in util/probe-finder.c checks for the functions' frame descriptions in either .eh_frame section of an ELF or the .debug_frame. The check is based on whether either one of these sections is present. But sometimes, it may happen that, .eh_frame, even if