Re: [PATCH] perf/x86: fix bug in event constraint end marker macro

2013-12-04 Thread Ingo Molnar
* Stephane Eranian wrote: > Ingo, > > Ok, I have asked Maria to clean the patch up add more comments and > repost a new version of the > patch. She will repost ASAP. Ok! Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH] perf/x86: fix bug in event constraint end marker macro

2013-12-04 Thread Stephane Eranian
Ingo, Ok, I have asked Maria to clean the patch up add more comments and repost a new version of the patch. She will repost ASAP. Thanks. On Wed, Dec 4, 2013 at 10:03 AM, Ingo Molnar wrote: > > * Stephane Eranian wrote: > >> #define EVENT_CONSTRAINT_END \ >> - EVENT_CONSTRAINT(0,

Re: [PATCH] perf/x86: fix bug in event constraint end marker macro

2013-12-04 Thread Ingo Molnar
* Stephane Eranian wrote: > #define EVENT_CONSTRAINT_END \ > - EVENT_CONSTRAINT(0, 0, 0) > + { .idxmsk64 = 0,\ > + .code = 0,\ > + .cmask = 0, \ > + .weight = -1, \ > + .overlap = 0,

[PATCH] perf/x86: fix bug in event constraint end marker macro

2013-12-04 Thread Stephane Eranian
[repost because typo in Ingo's email address] The EVENT_CONSTRAINT_END macro defines the end marker as a constraint with a weight of zero. This was all fine until we blacklisted the corrupting memory events on Intel IvyBridge. These events are blacklisted by using a counter bitmask of zero. Thus,

[PATCH] perf/x86: fix bug in event constraint end marker macro

2013-12-04 Thread Stephane Eranian
The EVENT_CONSTRAINT_END macro defines the end marker as a constraint with a weight of zero. This was all fine until we blacklisted the corrupting memory events on Intel IvyBridge. These events are blacklisted by using a counter bitmask of zero. Thus, they also get a constraint weight of zero.

[PATCH] perf/x86: fix bug in event constraint end marker macro

2013-12-04 Thread Stephane Eranian
The EVENT_CONSTRAINT_END macro defines the end marker as a constraint with a weight of zero. This was all fine until we blacklisted the corrupting memory events on Intel IvyBridge. These events are blacklisted by using a counter bitmask of zero. Thus, they also get a constraint weight of zero.

[PATCH] perf/x86: fix bug in event constraint end marker macro

2013-12-04 Thread Stephane Eranian
[repost because typo in Ingo's email address] The EVENT_CONSTRAINT_END macro defines the end marker as a constraint with a weight of zero. This was all fine until we blacklisted the corrupting memory events on Intel IvyBridge. These events are blacklisted by using a counter bitmask of zero. Thus,

Re: [PATCH] perf/x86: fix bug in event constraint end marker macro

2013-12-04 Thread Ingo Molnar
* Stephane Eranian eran...@google.com wrote: #define EVENT_CONSTRAINT_END \ - EVENT_CONSTRAINT(0, 0, 0) + { .idxmsk64 = 0,\ + .code = 0,\ + .cmask = 0, \ + .weight = -1, \ +

Re: [PATCH] perf/x86: fix bug in event constraint end marker macro

2013-12-04 Thread Stephane Eranian
Ingo, Ok, I have asked Maria to clean the patch up add more comments and repost a new version of the patch. She will repost ASAP. Thanks. On Wed, Dec 4, 2013 at 10:03 AM, Ingo Molnar mi...@kernel.org wrote: * Stephane Eranian eran...@google.com wrote: #define EVENT_CONSTRAINT_END \

Re: [PATCH] perf/x86: fix bug in event constraint end marker macro

2013-12-04 Thread Ingo Molnar
* Stephane Eranian eran...@google.com wrote: Ingo, Ok, I have asked Maria to clean the patch up add more comments and repost a new version of the patch. She will repost ASAP. Ok! Thanks, Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of