Re: [PATCH] perf: Add a new sort order: SORT_INCLUSIVE (v6)

2012-08-08 Thread Namhyung Kim
Hi, Arun On Wed, 8 Aug 2012 12:16:30 -0700, Arun Sharma wrote: > On 3/30/12 10:43 PM, Arun Sharma wrote: >> [ Meant to include v6 ChangeLog as well. Technical difficulties.. ] >> >> v6 ChangeLog: >> >> rebased to tip:perf/core and fixed a minor problem in computing >> the total period in

Re: [PATCH] perf: Add a new sort order: SORT_INCLUSIVE (v6)

2012-08-08 Thread Arun Sharma
On 8/8/12 12:16 PM, Arun Sharma wrote: and therefore breaks the invariant period == period_self in the default mode (no sort inclusive). hist_entry__decay() also needs an update to maintain the invariant. --- a/tools/perf/util/hist.c +++ b/tools/perf/util/hist.c @@ -138,6 +138,7 @@

Re: [PATCH] perf: Add a new sort order: SORT_INCLUSIVE (v6)

2012-08-08 Thread Arun Sharma
On 3/30/12 10:43 PM, Arun Sharma wrote: [ Meant to include v6 ChangeLog as well. Technical difficulties.. ] v6 ChangeLog: rebased to tip:perf/core and fixed a minor problem in computing the total period in hists__remove_entry_filter(). Needed to use period_self instead of period. This patch

Re: [PATCH] perf: Add a new sort order: SORT_INCLUSIVE (v6)

2012-08-08 Thread Arun Sharma
On 3/30/12 10:43 PM, Arun Sharma wrote: [ Meant to include v6 ChangeLog as well. Technical difficulties.. ] v6 ChangeLog: rebased to tip:perf/core and fixed a minor problem in computing the total period in hists__remove_entry_filter(). Needed to use period_self instead of period. This patch

Re: [PATCH] perf: Add a new sort order: SORT_INCLUSIVE (v6)

2012-08-08 Thread Arun Sharma
On 8/8/12 12:16 PM, Arun Sharma wrote: and therefore breaks the invariant period == period_self in the default mode (no sort inclusive). hist_entry__decay() also needs an update to maintain the invariant. --- a/tools/perf/util/hist.c +++ b/tools/perf/util/hist.c @@ -138,6 +138,7 @@

Re: [PATCH] perf: Add a new sort order: SORT_INCLUSIVE (v6)

2012-08-08 Thread Namhyung Kim
Hi, Arun On Wed, 8 Aug 2012 12:16:30 -0700, Arun Sharma wrote: On 3/30/12 10:43 PM, Arun Sharma wrote: [ Meant to include v6 ChangeLog as well. Technical difficulties.. ] v6 ChangeLog: rebased to tip:perf/core and fixed a minor problem in computing the total period in