Re: [PATCH] perf: Don't clone maps from parent when synthesizing forks

2018-10-31 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 31, 2018 at 02:01:38PM +0100, Jiri Olsa escreveu: > On Tue, Oct 30, 2018 at 10:24:04PM -0700, David Miller wrote: > > SNIP > > > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > > index 111ae858cbcb..214b7979c4e7 100644 > > --- a/tools/perf/util/machine.c > > +++ b

Re: [PATCH] perf: Don't clone maps from parent when synthesizing forks

2018-10-31 Thread Jiri Olsa
On Tue, Oct 30, 2018 at 10:24:04PM -0700, David Miller wrote: SNIP > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > index 111ae858cbcb..214b7979c4e7 100644 > --- a/tools/perf/util/machine.c > +++ b/tools/perf/util/machine.c > @@ -1708,6 +1708,7 @@ int machine__process_fork_e

Re: [PATCH] perf: Don't clone maps from parent when synthesizing forks

2018-10-31 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 30, 2018 at 10:24:04PM -0700, David Miller escreveu: > > When synthesizing FORK events, we are trying to create thread objects > for the already running tasks on the machine. > > Normally, for a kernel FORK event, we want to clone the parent's maps > because that is what the kernel ju

[PATCH] perf: Don't clone maps from parent when synthesizing forks

2018-10-30 Thread David Miller
When synthesizing FORK events, we are trying to create thread objects for the already running tasks on the machine. Normally, for a kernel FORK event, we want to clone the parent's maps because that is what the kernel just did. But when synthesizing, this should not be done. If we do, we end u