Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-16 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 16, 2012 at 12:07:54PM -0400, Steven Rostedt escreveu: > Acked-by: Steven Rostedt > > Arnaldo, can you pick this patch? Keep both the Signed-off-bys that > Boris placed. ack, done, - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-16 Thread Steven Rostedt
On Wed, 2012-08-15 at 18:39 +0200, Borislav Petkov wrote: > diff --git a/tools/scripts/Makefile.include b/tools/scripts/Makefile.include > index bde8521d56bb..96ce80a3743b 100644 > --- a/tools/scripts/Makefile.include > +++ b/tools/scripts/Makefile.include > @@ -1,6 +1,8 @@ > ifeq ("$(origin

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-16 Thread Steven Rostedt
On Wed, 2012-08-15 at 18:39 +0200, Borislav Petkov wrote: diff --git a/tools/scripts/Makefile.include b/tools/scripts/Makefile.include index bde8521d56bb..96ce80a3743b 100644 --- a/tools/scripts/Makefile.include +++ b/tools/scripts/Makefile.include @@ -1,6 +1,8 @@ ifeq ($(origin O),

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-16 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 16, 2012 at 12:07:54PM -0400, Steven Rostedt escreveu: Acked-by: Steven Rostedt rost...@goodmis.org Arnaldo, can you pick this patch? Keep both the Signed-off-bys that Boris placed. ack, done, - Arnaldo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-15 Thread Borislav Petkov
400 Subject: [PATCH] perf: Let O= makes handle relative paths When I did a compile of perf using a relative path for the output directory, the build failed when it tried to compile libtraceevent. This is because it continues to use the same relative path when the new working directory is in a differ

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-15 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 15, 2012 at 04:42:55PM +0200, Borislav Petkov escreveu: > On Wed, Aug 15, 2012 at 04:38:05PM +0200, Peter Zijlstra wrote: > > Because you're an idiot and made a typo ;-) Happens to me all the time. > > I'm not an idiot - I'm perfection at its purest! :-) > > > The regular kernel

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-15 Thread Borislav Petkov
On Wed, Aug 15, 2012 at 04:38:05PM +0200, Peter Zijlstra wrote: > Because you're an idiot and made a typo ;-) Happens to me all the time. I'm not an idiot - I'm perfection at its purest! :-) > The regular kernel build doesn't create non-existent O= targets either > iirc. Ok, I see. The kernel

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-15 Thread Peter Zijlstra
On Wed, 2012-08-15 at 15:18 +0200, Borislav Petkov wrote: > On Wed, Aug 15, 2012 at 10:06:34AM -0300, Arnaldo Carvalho de Melo wrote: > > That was the case in the past, but IIRC PeterZ advocated not to and I > > agreed. > > Maybe you guys need to explain yourselves :) I mean, the dir is not >

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-15 Thread Borislav Petkov
On Wed, Aug 15, 2012 at 10:06:34AM -0300, Arnaldo Carvalho de Melo wrote: > That was the case in the past, but IIRC PeterZ advocated not to and I > agreed. Maybe you guys need to explain yourselves :) I mean, the dir is not present so we're not overwriting anything. And since we say "O=..." on

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-15 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 15, 2012 at 12:27:22PM +0200, Borislav Petkov escreveu: > On Mon, Aug 13, 2012 at 03:02:49PM -0300, Arnaldo Carvalho de Melo wrote: > > [acme@sandy linux]$ rm -rf ../build/perf > > [acme@sandy linux]$ make -j8 -C tools/perf/ LIBUNWIND_DIR=/opt/libunwind > > O=/home/acme/git/build/perf

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-15 Thread Borislav Petkov
On Mon, Aug 13, 2012 at 03:02:49PM -0300, Arnaldo Carvalho de Melo wrote: > [acme@sandy linux]$ rm -rf ../build/perf > [acme@sandy linux]$ make -j8 -C tools/perf/ LIBUNWIND_DIR=/opt/libunwind > O=/home/acme/git/build/perf install > /bin/sh: line 0: cd: /home/acme/git/build/perf: No such file or

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-15 Thread Borislav Petkov
On Mon, Aug 13, 2012 at 03:02:49PM -0300, Arnaldo Carvalho de Melo wrote: [acme@sandy linux]$ rm -rf ../build/perf [acme@sandy linux]$ make -j8 -C tools/perf/ LIBUNWIND_DIR=/opt/libunwind O=/home/acme/git/build/perf install /bin/sh: line 0: cd: /home/acme/git/build/perf: No such file or

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-15 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 15, 2012 at 12:27:22PM +0200, Borislav Petkov escreveu: On Mon, Aug 13, 2012 at 03:02:49PM -0300, Arnaldo Carvalho de Melo wrote: [acme@sandy linux]$ rm -rf ../build/perf [acme@sandy linux]$ make -j8 -C tools/perf/ LIBUNWIND_DIR=/opt/libunwind O=/home/acme/git/build/perf

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-15 Thread Borislav Petkov
On Wed, Aug 15, 2012 at 10:06:34AM -0300, Arnaldo Carvalho de Melo wrote: That was the case in the past, but IIRC PeterZ advocated not to and I agreed. Maybe you guys need to explain yourselves :) I mean, the dir is not present so we're not overwriting anything. And since we say O=... on the

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-15 Thread Peter Zijlstra
On Wed, 2012-08-15 at 15:18 +0200, Borislav Petkov wrote: On Wed, Aug 15, 2012 at 10:06:34AM -0300, Arnaldo Carvalho de Melo wrote: That was the case in the past, but IIRC PeterZ advocated not to and I agreed. Maybe you guys need to explain yourselves :) I mean, the dir is not present so

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-15 Thread Borislav Petkov
On Wed, Aug 15, 2012 at 04:38:05PM +0200, Peter Zijlstra wrote: Because you're an idiot and made a typo ;-) Happens to me all the time. I'm not an idiot - I'm perfection at its purest! :-) The regular kernel build doesn't create non-existent O= targets either iirc. Ok, I see. The kernel

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-15 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 15, 2012 at 04:42:55PM +0200, Borislav Petkov escreveu: On Wed, Aug 15, 2012 at 04:38:05PM +0200, Peter Zijlstra wrote: Because you're an idiot and made a typo ;-) Happens to me all the time. I'm not an idiot - I'm perfection at its purest! :-) The regular kernel build

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-15 Thread Borislav Petkov
10:23:02 -0400 Subject: [PATCH] perf: Let O= makes handle relative paths When I did a compile of perf using a relative path for the output directory, the build failed when it tried to compile libtraceevent. This is because it continues to use the same relative path when the new working directory

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-13 Thread Arnaldo Carvalho de Melo
Em Mon, Aug 13, 2012 at 04:29:09PM +0200, Borislav Petkov escreveu: > On Mon, Aug 13, 2012 at 10:23:02AM -0400, Steven Rostedt wrote: > > On Mon, 2012-08-13 at 15:24 +0200, Borislav Petkov wrote: > > > > > So wouldn't it make sense to call this ABSOLUTE_O or so then? > > > > That's just because

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-13 Thread Borislav Petkov
On Mon, Aug 13, 2012 at 10:23:02AM -0400, Steven Rostedt wrote: > On Mon, 2012-08-13 at 15:24 +0200, Borislav Petkov wrote: > > > So wouldn't it make sense to call this ABSOLUTE_O or so then? > > That's just because you're russian, and are promoting Vodka! ;-) > > > Done... > > -- >

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-13 Thread Steven Rostedt
On Mon, 2012-08-13 at 15:24 +0200, Borislav Petkov wrote: > So wouldn't it make sense to call this ABSOLUTE_O or so then? That's just because you're russian, and are promoting Vodka! ;-) Done... -- When I did a compile of perf using a relative path for the output directory, the build

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-13 Thread Borislav Petkov
On Mon, Aug 13, 2012 at 09:20:55AM -0400, Steven Rostedt wrote: > When I did a compile of perf using a relative path for the output > directory, the build failed when it tried to compile libtraceevent. This > is because it continues to use the same relative path when the new > working directory is

[PATCH] perf: Let O= makes handle relative paths

2012-08-13 Thread Steven Rostedt
When I did a compile of perf using a relative path for the output directory, the build failed when it tried to compile libtraceevent. This is because it continues to use the same relative path when the new working directory is in a different path. SUBDIR ../lib/traceevent/ /bin/sh: line 0:

[PATCH] perf: Let O= makes handle relative paths

2012-08-13 Thread Steven Rostedt
When I did a compile of perf using a relative path for the output directory, the build failed when it tried to compile libtraceevent. This is because it continues to use the same relative path when the new working directory is in a different path. SUBDIR ../lib/traceevent/ /bin/sh: line 0:

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-13 Thread Borislav Petkov
On Mon, Aug 13, 2012 at 09:20:55AM -0400, Steven Rostedt wrote: When I did a compile of perf using a relative path for the output directory, the build failed when it tried to compile libtraceevent. This is because it continues to use the same relative path when the new working directory is in

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-13 Thread Steven Rostedt
On Mon, 2012-08-13 at 15:24 +0200, Borislav Petkov wrote: So wouldn't it make sense to call this ABSOLUTE_O or so then? That's just because you're russian, and are promoting Vodka! ;-) Done... -- When I did a compile of perf using a relative path for the output directory, the build

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-13 Thread Borislav Petkov
On Mon, Aug 13, 2012 at 10:23:02AM -0400, Steven Rostedt wrote: On Mon, 2012-08-13 at 15:24 +0200, Borislav Petkov wrote: So wouldn't it make sense to call this ABSOLUTE_O or so then? That's just because you're russian, and are promoting Vodka! ;-) Done... -- When I did

Re: [PATCH] perf: Let O= makes handle relative paths

2012-08-13 Thread Arnaldo Carvalho de Melo
Em Mon, Aug 13, 2012 at 04:29:09PM +0200, Borislav Petkov escreveu: On Mon, Aug 13, 2012 at 10:23:02AM -0400, Steven Rostedt wrote: On Mon, 2012-08-13 at 15:24 +0200, Borislav Petkov wrote: So wouldn't it make sense to call this ABSOLUTE_O or so then? That's just because you're