Re: [PATCH] perf annotate: Fix sample events lost in stdio mode

2021-03-12 Thread Yang Jihong
Hello, On 2021/3/13 10:00, Yang Jihong wrote: Hello, Namhyung On 2021/3/12 18:20, Yang Jihong wrote: Hello, On 2021/3/12 16:39, Namhyung Kim wrote: On Fri, Mar 12, 2021 at 4:19 PM Yang Jihong wrote: Hello, On 2021/3/12 13:49, Namhyung Kim wrote: Hi, On Fri, Mar 12, 2021 at 12:24 PM Yang

Re: [PATCH] perf annotate: Fix sample events lost in stdio mode

2021-03-12 Thread Yang Jihong
Hello, Namhyung On 2021/3/12 18:20, Yang Jihong wrote: Hello, On 2021/3/12 16:39, Namhyung Kim wrote: On Fri, Mar 12, 2021 at 4:19 PM Yang Jihong wrote: Hello, On 2021/3/12 13:49, Namhyung Kim wrote: Hi, On Fri, Mar 12, 2021 at 12:24 PM Yang Jihong wrote: Hello, Namhyung On 2021/3/11

Re: [PATCH] perf annotate: Fix sample events lost in stdio mode

2021-03-12 Thread Yang Jihong
Hello, On 2021/3/12 16:39, Namhyung Kim wrote: On Fri, Mar 12, 2021 at 4:19 PM Yang Jihong wrote: Hello, On 2021/3/12 13:49, Namhyung Kim wrote: Hi, On Fri, Mar 12, 2021 at 12:24 PM Yang Jihong wrote: Hello, Namhyung On 2021/3/11 22:42, Namhyung Kim wrote: Hi, On Thu, Mar 11, 2021 at

Re: [PATCH] perf annotate: Fix sample events lost in stdio mode

2021-03-12 Thread Namhyung Kim
On Fri, Mar 12, 2021 at 4:19 PM Yang Jihong wrote: > > > Hello, > On 2021/3/12 13:49, Namhyung Kim wrote: > > Hi, > > > > On Fri, Mar 12, 2021 at 12:24 PM Yang Jihong wrote: > >> > >> Hello, Namhyung > >> > >> On 2021/3/11 22:42, Namhyung Kim wrote: > >>> Hi, > >>> > >>> On Thu, Mar 11, 2021 at 5

Re: [PATCH] perf annotate: Fix sample events lost in stdio mode

2021-03-11 Thread Yang Jihong
Hello, On 2021/3/12 13:49, Namhyung Kim wrote: Hi, On Fri, Mar 12, 2021 at 12:24 PM Yang Jihong wrote: Hello, Namhyung On 2021/3/11 22:42, Namhyung Kim wrote: Hi, On Thu, Mar 11, 2021 at 5:48 PM Yang Jihong wrote: Hello, On 2021/3/6 16:28, Yang Jihong wrote: In hist__find_annotation

Re: [PATCH] perf annotate: Fix sample events lost in stdio mode

2021-03-11 Thread Namhyung Kim
Hi, On Fri, Mar 12, 2021 at 12:24 PM Yang Jihong wrote: > > Hello, Namhyung > > On 2021/3/11 22:42, Namhyung Kim wrote: > > Hi, > > > > On Thu, Mar 11, 2021 at 5:48 PM Yang Jihong wrote: > >> > >> Hello, > >> > >> On 2021/3/6 16:28, Yang Jihong wrote: > >>> In hist__find_annotations function, si

Re: [PATCH] perf annotate: Fix sample events lost in stdio mode

2021-03-11 Thread Yang Jihong
Hello, Namhyung On 2021/3/11 22:42, Namhyung Kim wrote: Hi, On Thu, Mar 11, 2021 at 5:48 PM Yang Jihong wrote: Hello, On 2021/3/6 16:28, Yang Jihong wrote: In hist__find_annotations function, since have a hist_entry per IP for the same symbol, we free notes->src to signal already processed

Re: [PATCH] perf annotate: Fix sample events lost in stdio mode

2021-03-11 Thread Namhyung Kim
Hi, On Thu, Mar 11, 2021 at 5:48 PM Yang Jihong wrote: > > Hello, > > On 2021/3/6 16:28, Yang Jihong wrote: > > In hist__find_annotations function, since have a hist_entry per IP for the > > same > > symbol, we free notes->src to signal already processed this symbol in stdio > > mode; > > when

Re: [PATCH] perf annotate: Fix sample events lost in stdio mode

2021-03-11 Thread Yang Jihong
Hello, On 2021/3/6 16:28, Yang Jihong wrote: In hist__find_annotations function, since have a hist_entry per IP for the same symbol, we free notes->src to signal already processed this symbol in stdio mode; when annotate, entry will skipped if notes->src is NULL to avoid repeated output. Howe

[PATCH] perf annotate: Fix sample events lost in stdio mode

2021-03-06 Thread Yang Jihong
In hist__find_annotations function, since have a hist_entry per IP for the same symbol, we free notes->src to signal already processed this symbol in stdio mode; when annotate, entry will skipped if notes->src is NULL to avoid repeated output. However, there is a problem, for example, run the fo