Re: [PATCH] perf diff: Don't crash on freeing errno-session

2021-03-02 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 02, 2021 at 01:47:55PM +0900, Namhyung Kim escreveu: > Hello, > > On Tue, Mar 2, 2021 at 11:35 AM Dmitry Safonov wrote: > > > > __cmd_diff() sets result of perf_session__new() to d->session. > > In case of failure, it's errno and perf-diff may crash with: > > failed to open perf.data:

Re: [PATCH] perf diff: Don't crash on freeing errno-session

2021-03-02 Thread Namhyung Kim
Hello, On Tue, Mar 2, 2021 at 11:35 AM Dmitry Safonov wrote: > > __cmd_diff() sets result of perf_session__new() to d->session. > In case of failure, it's errno and perf-diff may crash with: > failed to open perf.data: Permission denied > Failed to open perf.data > Segmentation fault (core dumped

[PATCH] perf diff: Don't crash on freeing errno-session

2021-03-01 Thread Dmitry Safonov
__cmd_diff() sets result of perf_session__new() to d->session. In case of failure, it's errno and perf-diff may crash with: failed to open perf.data: Permission denied Failed to open perf.data Segmentation fault (core dumped) >From the coredump: 0 0x5569a62b5955 in auxtrace__free (session=0xf