Re: [PATCH] perf probe: Warn user to rebuild target with debuginfo

2014-08-15 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 14, 2014 at 08:39:51PM -0700, Brendan Gregg escreveu: > On Thu, Aug 14, 2014 at 6:51 PM, Masami Hiramatsu > wrote: > > Here is v2 patch, which I've added "or install an appropriate debuginfo > > pacakge." :) > [...] > > Looks good, thanks. Thanks, applied. - Arnaldo -- To

Re: [PATCH] perf probe: Warn user to rebuild target with debuginfo

2014-08-15 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 14, 2014 at 08:39:51PM -0700, Brendan Gregg escreveu: On Thu, Aug 14, 2014 at 6:51 PM, Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: Here is v2 patch, which I've added or install an appropriate debuginfo pacakge. :) [...] Looks good, thanks. Thanks, applied. -

Re: [PATCH] perf probe: Warn user to rebuild target with debuginfo

2014-08-14 Thread Brendan Gregg
On Thu, Aug 14, 2014 at 6:51 PM, Masami Hiramatsu wrote: > Here is v2 patch, which I've added "or install an appropriate debuginfo > pacakge." :) [...] Looks good, thanks. Brendan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] perf probe: Warn user to rebuild target with debuginfo

2014-08-14 Thread Masami Hiramatsu
Here is v2 patch, which I've added "or install an appropriate debuginfo pacakge." :) Thank you, (2014/08/15 10:44), Masami Hiramatsu wrote: > Warn user to rebuild target with debuginfo when the perf probe > fails to find debug information in the target binary. > Without this, perf probe just

[PATCH] perf probe: Warn user to rebuild target with debuginfo

2014-08-14 Thread Masami Hiramatsu
Warn user to rebuild target with debuginfo when the perf probe fails to find debug information in the target binary. Without this, perf probe just reports the failure, but it's no hint for users. This gives more hint for users. Without this, $ strip perf $ ./perf probe -x perf -L argv_split

Re: Re: [PATCH] perf probe: Warn user to rebuild target with debuginfo

2014-08-14 Thread Masami Hiramatsu
(2014/08/15 10:07), Arnaldo Carvalho de Melo wrote: > Em Thu, Aug 14, 2014 at 01:07:28PM -0700, Brendan Gregg escreveu: >> On Thu, Aug 14, 2014 at 11:29 AM, Masami Hiramatsu >> wrote: >> [...] >>> The "rebuild with ..." part changes to "rebuild with CONFIG_DEBUG_INFO" >>> if the target is the

Re: [PATCH] perf probe: Warn user to rebuild target with debuginfo

2014-08-14 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 14, 2014 at 01:07:28PM -0700, Brendan Gregg escreveu: > On Thu, Aug 14, 2014 at 11:29 AM, Masami Hiramatsu > wrote: > [...] > > The "rebuild with ..." part changes to "rebuild with CONFIG_DEBUG_INFO" > > if the target is the kernel or a kernel module. > Thanks, definitely an

Re: [PATCH] perf probe: Warn user to rebuild target with debuginfo

2014-08-14 Thread Brendan Gregg
On Thu, Aug 14, 2014 at 11:29 AM, Masami Hiramatsu wrote: [...] > The "rebuild with ..." part changes to "rebuild with CONFIG_DEBUG_INFO" > if the target is the kernel or a kernel module. Thanks, definitely an improvement! Should the kernel message also mention kernel debuginfo packages? Depends

Re: [PATCH] perf probe: Warn user to rebuild target with debuginfo

2014-08-14 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 14, 2014 at 06:29:38PM +, Masami Hiramatsu escreveu: > Warn user to rebuild target with debuginfo when the perf probe > fails to find debug information in the target binary. > Without this, perf probe just reports the failure, but it's > no hint for users. This gives more hint for

[PATCH] perf probe: Warn user to rebuild target with debuginfo

2014-08-14 Thread Masami Hiramatsu
Warn user to rebuild target with debuginfo when the perf probe fails to find debug information in the target binary. Without this, perf probe just reports the failure, but it's no hint for users. This gives more hint for users. Without this, $ strip perf $ ./perf probe -x perf -L argv_split

[PATCH] perf probe: Warn user to rebuild target with debuginfo

2014-08-14 Thread Masami Hiramatsu
Warn user to rebuild target with debuginfo when the perf probe fails to find debug information in the target binary. Without this, perf probe just reports the failure, but it's no hint for users. This gives more hint for users. Without this, $ strip perf $ ./perf probe -x perf -L argv_split

Re: [PATCH] perf probe: Warn user to rebuild target with debuginfo

2014-08-14 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 14, 2014 at 06:29:38PM +, Masami Hiramatsu escreveu: Warn user to rebuild target with debuginfo when the perf probe fails to find debug information in the target binary. Without this, perf probe just reports the failure, but it's no hint for users. This gives more hint for

Re: [PATCH] perf probe: Warn user to rebuild target with debuginfo

2014-08-14 Thread Brendan Gregg
On Thu, Aug 14, 2014 at 11:29 AM, Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: [...] The rebuild with ... part changes to rebuild with CONFIG_DEBUG_INFO if the target is the kernel or a kernel module. Thanks, definitely an improvement! Should the kernel message also mention kernel

Re: [PATCH] perf probe: Warn user to rebuild target with debuginfo

2014-08-14 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 14, 2014 at 01:07:28PM -0700, Brendan Gregg escreveu: On Thu, Aug 14, 2014 at 11:29 AM, Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: [...] The rebuild with ... part changes to rebuild with CONFIG_DEBUG_INFO if the target is the kernel or a kernel module. Thanks,

Re: Re: [PATCH] perf probe: Warn user to rebuild target with debuginfo

2014-08-14 Thread Masami Hiramatsu
(2014/08/15 10:07), Arnaldo Carvalho de Melo wrote: Em Thu, Aug 14, 2014 at 01:07:28PM -0700, Brendan Gregg escreveu: On Thu, Aug 14, 2014 at 11:29 AM, Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: [...] The rebuild with ... part changes to rebuild with CONFIG_DEBUG_INFO if the

[PATCH] perf probe: Warn user to rebuild target with debuginfo

2014-08-14 Thread Masami Hiramatsu
Warn user to rebuild target with debuginfo when the perf probe fails to find debug information in the target binary. Without this, perf probe just reports the failure, but it's no hint for users. This gives more hint for users. Without this, $ strip perf $ ./perf probe -x perf -L argv_split

Re: [PATCH] perf probe: Warn user to rebuild target with debuginfo

2014-08-14 Thread Masami Hiramatsu
Here is v2 patch, which I've added or install an appropriate debuginfo pacakge. :) Thank you, (2014/08/15 10:44), Masami Hiramatsu wrote: Warn user to rebuild target with debuginfo when the perf probe fails to find debug information in the target binary. Without this, perf probe just reports

Re: [PATCH] perf probe: Warn user to rebuild target with debuginfo

2014-08-14 Thread Brendan Gregg
On Thu, Aug 14, 2014 at 6:51 PM, Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote: Here is v2 patch, which I've added or install an appropriate debuginfo pacakge. :) [...] Looks good, thanks. Brendan -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of