Re: [PATCH] perf report: don't crash on invalid maps in `-g srcline` mode

2017-05-12 Thread Namhyung Kim
On Fri, May 12, 2017 at 12:23:06PM +0200, Milian Wolff wrote: > On Mittwoch, 10. Mai 2017 08:04:23 CEST Namhyung Kim wrote: > > On Tue, May 09, 2017 at 10:50:46PM +0200, Milian Wolff wrote: > > > > > > diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c > > > index 9ab68682c6d

Re: [PATCH] perf report: don't crash on invalid maps in `-g srcline` mode

2017-05-12 Thread Milian Wolff
On Mittwoch, 10. Mai 2017 08:04:23 CEST Namhyung Kim wrote: > On Tue, May 09, 2017 at 10:50:46PM +0200, Milian Wolff wrote: > > diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c > > index 9ab68682c6d0..295f0846fd84 100644 > > --- a/tools/perf/util/callchain.c > > +++ b/tools

Re: [PATCH] perf report: don't crash on invalid maps in `-g srcline` mode

2017-05-11 Thread Paul Clarke
On 05/09/2017 03:50 PM, Milian Wolff wrote: > diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c > index 9ab68682c6d0..295f0846fd84 100644 > --- a/tools/perf/util/callchain.c > +++ b/tools/perf/util/callchain.c > @@ -642,13 +642,22 @@ static enum match_result match_chain_strings

Re: [PATCH] perf report: don't crash on invalid maps in `-g srcline` mode

2017-05-09 Thread Namhyung Kim
On Tue, May 09, 2017 at 10:50:46PM +0200, Milian Wolff wrote: > I just hit a segfault when doing `perf report -g srcline`. > Valgrind pointed me at this code as the culprit: > > ==8359== Invalid read of size 8 > ==8359==at 0x3096D9: map__rip_2objdump (map.c:430) > ==8359==by 0x2FC1A3: matc

[PATCH] perf report: don't crash on invalid maps in `-g srcline` mode

2017-05-09 Thread Milian Wolff
I just hit a segfault when doing `perf report -g srcline`. Valgrind pointed me at this code as the culprit: ==8359== Invalid read of size 8 ==8359==at 0x3096D9: map__rip_2objdump (map.c:430) ==8359==by 0x2FC1A3: match_chain_srcline (callchain.c:645) ==8359==by 0x2FC1A3: match_chain (ca