Re: [PATCH] perf timechart: dynamically determine event data offset

2013-11-27 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 27, 2013 at 11:51:25PM +0900, Namhyung Kim escreveu: > 2013-11-27 (수), 11:41 -0300, Arnaldo Carvalho de Melo: > > Em Wed, Nov 27, 2013 at 11:17:43PM +0900, Namhyung Kim escreveu: > > > 2013-11-27 (수), 10:44 -0300, Arnaldo Carvalho de Melo: > > > > Same signature, 32-bit, 64-bit

Re: [PATCH] perf timechart: dynamically determine event data offset

2013-11-27 Thread Namhyung Kim
2013-11-27 (수), 11:41 -0300, Arnaldo Carvalho de Melo: > Em Wed, Nov 27, 2013 at 11:17:43PM +0900, Namhyung Kim escreveu: > > 2013-11-27 (수), 10:44 -0300, Arnaldo Carvalho de Melo: > > > Same signature, 32-bit, 64-bit userland, so whoever wrote timechart, > > > Arjan, I > > > think, made no

Re: [PATCH] perf timechart: dynamically determine event data offset

2013-11-27 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 27, 2013 at 11:17:43PM +0900, Namhyung Kim escreveu: > 2013-11-27 (수), 10:44 -0300, Arnaldo Carvalho de Melo: > > Same signature, 32-bit, 64-bit userland, so whoever wrote timechart, Arjan, > > I > > think, made no mistakes at using the kernel exported interface, choosing the > > most

Re: [PATCH] perf timechart: dynamically determine event data offset

2013-11-27 Thread Namhyung Kim
Hi Arnaldo, 2013-11-27 (수), 10:44 -0300, Arnaldo Carvalho de Melo: > Em Wed, Nov 27, 2013 at 05:49:02PM +0900, Namhyung Kim escreveu: > > On Tue, 26 Nov 2013 18:54:37 +0400, Stanislav Fomichev wrote: > > > Since b000c8065a92 "tracing: Remove the extra 4 bytes of padding in > > > events" > > >

Re: [PATCH] perf timechart: dynamically determine event data offset

2013-11-27 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 27, 2013 at 05:49:02PM +0900, Namhyung Kim escreveu: > On Tue, 26 Nov 2013 18:54:37 +0400, Stanislav Fomichev wrote: > > Since b000c8065a92 "tracing: Remove the extra 4 bytes of padding in events" > > removed padding bytes, perf timechart got out of sync with the kernel's > >

Re: [PATCH] perf timechart: dynamically determine event data offset

2013-11-27 Thread Stanislav Fomichev
> Nacked-by: Namhyung Kim Thanks for a review. I'll try to convert all binary structures to perf_evsel__intval() and perf_evsel__strval() and will rebase on Arnaldo's perf/core branch. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] perf timechart: dynamically determine event data offset

2013-11-27 Thread Namhyung Kim
Hi Stanislav, On Tue, 26 Nov 2013 18:54:37 +0400, Stanislav Fomichev wrote: > Since b000c8065a92 "tracing: Remove the extra 4 bytes of padding in events" > removed padding bytes, perf timechart got out of sync with the kernel's > trace_entry structure. > We can't just align perf's trace_entry

Re: [PATCH] perf timechart: dynamically determine event data offset

2013-11-27 Thread Namhyung Kim
Hi Stanislav, On Tue, 26 Nov 2013 18:54:37 +0400, Stanislav Fomichev wrote: Since b000c8065a92 tracing: Remove the extra 4 bytes of padding in events removed padding bytes, perf timechart got out of sync with the kernel's trace_entry structure. We can't just align perf's trace_entry

Re: [PATCH] perf timechart: dynamically determine event data offset

2013-11-27 Thread Stanislav Fomichev
Nacked-by: Namhyung Kim namhy...@kernel.org Thanks for a review. I'll try to convert all binary structures to perf_evsel__intval() and perf_evsel__strval() and will rebase on Arnaldo's perf/core branch. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [PATCH] perf timechart: dynamically determine event data offset

2013-11-27 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 27, 2013 at 05:49:02PM +0900, Namhyung Kim escreveu: On Tue, 26 Nov 2013 18:54:37 +0400, Stanislav Fomichev wrote: Since b000c8065a92 tracing: Remove the extra 4 bytes of padding in events removed padding bytes, perf timechart got out of sync with the kernel's trace_entry

Re: [PATCH] perf timechart: dynamically determine event data offset

2013-11-27 Thread Namhyung Kim
Hi Arnaldo, 2013-11-27 (수), 10:44 -0300, Arnaldo Carvalho de Melo: Em Wed, Nov 27, 2013 at 05:49:02PM +0900, Namhyung Kim escreveu: On Tue, 26 Nov 2013 18:54:37 +0400, Stanislav Fomichev wrote: Since b000c8065a92 tracing: Remove the extra 4 bytes of padding in events removed padding

Re: [PATCH] perf timechart: dynamically determine event data offset

2013-11-27 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 27, 2013 at 11:17:43PM +0900, Namhyung Kim escreveu: 2013-11-27 (수), 10:44 -0300, Arnaldo Carvalho de Melo: Same signature, 32-bit, 64-bit userland, so whoever wrote timechart, Arjan, I think, made no mistakes at using the kernel exported interface, choosing the most

Re: [PATCH] perf timechart: dynamically determine event data offset

2013-11-27 Thread Namhyung Kim
2013-11-27 (수), 11:41 -0300, Arnaldo Carvalho de Melo: Em Wed, Nov 27, 2013 at 11:17:43PM +0900, Namhyung Kim escreveu: 2013-11-27 (수), 10:44 -0300, Arnaldo Carvalho de Melo: Same signature, 32-bit, 64-bit userland, so whoever wrote timechart, Arjan, I think, made no mistakes at using

Re: [PATCH] perf timechart: dynamically determine event data offset

2013-11-27 Thread Arnaldo Carvalho de Melo
Em Wed, Nov 27, 2013 at 11:51:25PM +0900, Namhyung Kim escreveu: 2013-11-27 (수), 11:41 -0300, Arnaldo Carvalho de Melo: Em Wed, Nov 27, 2013 at 11:17:43PM +0900, Namhyung Kim escreveu: 2013-11-27 (수), 10:44 -0300, Arnaldo Carvalho de Melo: Same signature, 32-bit, 64-bit userland, so

Re: [PATCH] perf timechart: dynamically determine event data offset

2013-11-26 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 26, 2013 at 06:54:37PM +0400, Stanislav Fomichev escreveu: > Since b000c8065a92 "tracing: Remove the extra 4 bytes of padding in events" > removed padding bytes, perf timechart got out of sync with the kernel's > trace_entry structure. > We can't just align perf's trace_entry

[PATCH] perf timechart: dynamically determine event data offset

2013-11-26 Thread Stanislav Fomichev
Since b000c8065a92 "tracing: Remove the extra 4 bytes of padding in events" removed padding bytes, perf timechart got out of sync with the kernel's trace_entry structure. We can't just align perf's trace_entry definition with the kernel because we want timechart to continue working with old

[PATCH] perf timechart: dynamically determine event data offset

2013-11-26 Thread Stanislav Fomichev
Since b000c8065a92 tracing: Remove the extra 4 bytes of padding in events removed padding bytes, perf timechart got out of sync with the kernel's trace_entry structure. We can't just align perf's trace_entry definition with the kernel because we want timechart to continue working with old

Re: [PATCH] perf timechart: dynamically determine event data offset

2013-11-26 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 26, 2013 at 06:54:37PM +0400, Stanislav Fomichev escreveu: Since b000c8065a92 tracing: Remove the extra 4 bytes of padding in events removed padding bytes, perf timechart got out of sync with the kernel's trace_entry structure. We can't just align perf's trace_entry definition with