Re: [PATCH] perf tool: Round mmap pages to power 2

2013-11-11 Thread Arnaldo Carvalho de Melo
Em Mon, Nov 11, 2013 at 12:27:54PM +0100, Ingo Molnar escreveu: > * David Ahern wrote: > > > Currently perf requires the -m / --mmap_pages option to be a power of 2. > > To be more user friendly perf should automatically round this up to the > > next power of 2. > > > > Currently: > > $ perf

Re: [PATCH] perf tool: Round mmap pages to power 2

2013-11-11 Thread Ingo Molnar
* David Ahern wrote: > Currently perf requires the -m / --mmap_pages option to be a power of 2. > To be more user friendly perf should automatically round this up to the > next power of 2. > > Currently: > $ perf record -m 3 -a -- sleep 1 > --mmap_pages/-m value must be a power of

Re: [PATCH] perf tool: Round mmap pages to power 2

2013-11-11 Thread Ingo Molnar
* David Ahern dsah...@gmail.com wrote: Currently perf requires the -m / --mmap_pages option to be a power of 2. To be more user friendly perf should automatically round this up to the next power of 2. Currently: $ perf record -m 3 -a -- sleep 1 --mmap_pages/-m value must be a power

Re: [PATCH] perf tool: Round mmap pages to power 2

2013-11-11 Thread Arnaldo Carvalho de Melo
Em Mon, Nov 11, 2013 at 12:27:54PM +0100, Ingo Molnar escreveu: * David Ahern dsah...@gmail.com wrote: Currently perf requires the -m / --mmap_pages option to be a power of 2. To be more user friendly perf should automatically round this up to the next power of 2. Currently: $

Re: [PATCH] perf tool: Round mmap pages to power 2

2013-11-10 Thread Adrian Hunter
On 08/11/13 16:41, David Ahern wrote: > On 11/8/13, 2:11 AM, Adrian Hunter wrote: >> This prevents: >> >> --out-pages=0 >> >> from working e.g. >> >> tools/perf/perf record -vv --out-pages=0 uname >> rounding mmap pages size to 4096 (1 pages) >> >> Although without this patch: >> >>

Re: [PATCH] perf tool: Round mmap pages to power 2

2013-11-10 Thread Adrian Hunter
On 08/11/13 16:41, David Ahern wrote: On 11/8/13, 2:11 AM, Adrian Hunter wrote: This prevents: --out-pages=0 from working e.g. tools/perf/perf record -vv --out-pages=0 uname rounding mmap pages size to 4096 (1 pages) Although without this patch: tools/perf/perf

Re: [PATCH] perf tool: Round mmap pages to power 2

2013-11-08 Thread David Ahern
On 11/8/13, 2:11 AM, Adrian Hunter wrote: This prevents: --out-pages=0 from working e.g. tools/perf/perf record -vv --out-pages=0 uname rounding mmap pages size to 4096 (1 pages) Although without this patch: tools/perf/perf record -vv --out-pages=0 uname

Re: [PATCH] perf tool: Round mmap pages to power 2

2013-11-08 Thread Adrian Hunter
On 08/11/13 06:36, David Ahern wrote: > Currently perf requires the -m / --mmap_pages option to be a power of 2. > To be more user friendly perf should automatically round this up to the > next power of 2. > > Currently: > $ perf record -m 3 -a -- sleep 1 > --mmap_pages/-m value must be a

Re: [PATCH] perf tool: Round mmap pages to power 2

2013-11-08 Thread Adrian Hunter
On 08/11/13 06:36, David Ahern wrote: Currently perf requires the -m / --mmap_pages option to be a power of 2. To be more user friendly perf should automatically round this up to the next power of 2. Currently: $ perf record -m 3 -a -- sleep 1 --mmap_pages/-m value must be a power of

Re: [PATCH] perf tool: Round mmap pages to power 2

2013-11-08 Thread David Ahern
On 11/8/13, 2:11 AM, Adrian Hunter wrote: This prevents: --out-pages=0 from working e.g. tools/perf/perf record -vv --out-pages=0 uname rounding mmap pages size to 4096 (1 pages) Although without this patch: tools/perf/perf record -vv --out-pages=0 uname

[PATCH] perf tool: Round mmap pages to power 2

2013-11-07 Thread David Ahern
Currently perf requires the -m / --mmap_pages option to be a power of 2. To be more user friendly perf should automatically round this up to the next power of 2. Currently: $ perf record -m 3 -a -- sleep 1 --mmap_pages/-m value must be a power of two.sleep: Terminated With patch: $ perf

[PATCH] perf tool: Round mmap pages to power 2

2013-11-07 Thread David Ahern
Currently perf requires the -m / --mmap_pages option to be a power of 2. To be more user friendly perf should automatically round this up to the next power of 2. Currently: $ perf record -m 3 -a -- sleep 1 --mmap_pages/-m value must be a power of two.sleep: Terminated With patch: $ perf