Re: [PATCH] perf tools: Prevent condition that all sort keys are elided

2013-11-11 Thread Namhyung Kim
Hi Ingo, On Mon, 11 Nov 2013 12:20:13 +0100, Ingo Molnar wrote: > * Namhyung Kim wrote: >> +/* >> + * It makes no sense to elide all of sort entries. >> + * Just revert them to show up again. >> + */ >> +list_for_each_entry(se, _entry__sort_list, list) >> +if

Re: [PATCH] perf tools: Prevent condition that all sort keys are elided

2013-11-11 Thread Ingo Molnar
* Namhyung Kim wrote: > From: Namhyung Kim > > If given sort keys are all elided there'll be no output except for the > overhead column - actually the TUI shows a noisy output. In this case > it'd be better to show up the sort keys rather than elide. > > Before: > > $ perf report -s comm

Re: [PATCH] perf tools: Prevent condition that all sort keys are elided

2013-11-11 Thread Ingo Molnar
* Namhyung Kim namhy...@kernel.org wrote: From: Namhyung Kim namhyung@lge.com If given sort keys are all elided there'll be no output except for the overhead column - actually the TUI shows a noisy output. In this case it'd be better to show up the sort keys rather than elide.

Re: [PATCH] perf tools: Prevent condition that all sort keys are elided

2013-11-11 Thread Namhyung Kim
Hi Ingo, On Mon, 11 Nov 2013 12:20:13 +0100, Ingo Molnar wrote: * Namhyung Kim namhy...@kernel.org wrote: +/* + * It makes no sense to elide all of sort entries. + * Just revert them to show up again. + */ +list_for_each_entry(se, hist_entry__sort_list, list) +

[PATCH] perf tools: Prevent condition that all sort keys are elided

2013-11-08 Thread Namhyung Kim
From: Namhyung Kim If given sort keys are all elided there'll be no output except for the overhead column - actually the TUI shows a noisy output. In this case it'd be better to show up the sort keys rather than elide. Before: $ perf report -s comm -c perf (...) # Overhead #

[PATCH] perf tools: Prevent condition that all sort keys are elided

2013-11-08 Thread Namhyung Kim
From: Namhyung Kim namhyung@lge.com If given sort keys are all elided there'll be no output except for the overhead column - actually the TUI shows a noisy output. In this case it'd be better to show up the sort keys rather than elide. Before: $ perf report -s comm -c perf (...) #