Re: [PATCH] pinctrl: add pinctrl_register_reason() to return proper error code

2015-06-08 Thread Linus Walleij
On Tue, Jun 2, 2015 at 5:32 PM, Masahiro Yamada wrote: > If nobody is opposed to this, I can send a single big patch > replacing all the references. > > In that case, we would not need _strict(). Yeah just do this. > My concern is the sudden change of the function interface > will break

Re: [PATCH] pinctrl: add pinctrl_register_reason() to return proper error code

2015-06-08 Thread Linus Walleij
On Tue, Jun 2, 2015 at 5:32 PM, Masahiro Yamada yamada.masah...@socionext.com wrote: If nobody is opposed to this, I can send a single big patch replacing all the references. In that case, we would not need _strict(). Yeah just do this. My concern is the sudden change of the function

Re: [PATCH] pinctrl: add pinctrl_register_reason() to return proper error code

2015-06-02 Thread Masahiro Yamada
Hi Linus, 2015-06-02 21:56 GMT+09:00 Linus Walleij : > On Fri, May 29, 2015 at 1:30 PM, Masahiro Yamada > wrote: > >> The pinctrl_register() just returns NULL on error, so the callers >> can not know the exact reason of the failure. >> >> Some of the pinctrl drivers return -EINVAL, some

Re: [PATCH] pinctrl: add pinctrl_register_reason() to return proper error code

2015-06-02 Thread Linus Walleij
On Fri, May 29, 2015 at 1:30 PM, Masahiro Yamada wrote: > The pinctrl_register() just returns NULL on error, so the callers > can not know the exact reason of the failure. > > Some of the pinctrl drivers return -EINVAL, some -ENODEV, and some > -ENOMEM on error of pinctrl_register() , although

Re: [PATCH] pinctrl: add pinctrl_register_reason() to return proper error code

2015-06-02 Thread Linus Walleij
On Fri, May 29, 2015 at 1:30 PM, Masahiro Yamada yamada.masah...@socionext.com wrote: The pinctrl_register() just returns NULL on error, so the callers can not know the exact reason of the failure. Some of the pinctrl drivers return -EINVAL, some -ENODEV, and some -ENOMEM on error of

Re: [PATCH] pinctrl: add pinctrl_register_reason() to return proper error code

2015-06-02 Thread Masahiro Yamada
Hi Linus, 2015-06-02 21:56 GMT+09:00 Linus Walleij linus.wall...@linaro.org: On Fri, May 29, 2015 at 1:30 PM, Masahiro Yamada yamada.masah...@socionext.com wrote: The pinctrl_register() just returns NULL on error, so the callers can not know the exact reason of the failure. Some of the

Re: [PATCH] pinctrl: add pinctrl_register_reason() to return proper error code

2015-05-29 Thread Sören Brinkmann
On Fri, 2015-05-29 at 08:30PM +0900, Masahiro Yamada wrote: > The pinctrl_register() just returns NULL on error, so the callers > can not know the exact reason of the failure. > > Some of the pinctrl drivers return -EINVAL, some -ENODEV, and some > -ENOMEM on error of pinctrl_register() ,

[PATCH] pinctrl: add pinctrl_register_reason() to return proper error code

2015-05-29 Thread Masahiro Yamada
The pinctrl_register() just returns NULL on error, so the callers can not know the exact reason of the failure. Some of the pinctrl drivers return -EINVAL, some -ENODEV, and some -ENOMEM on error of pinctrl_register() , although the error code might be different from the actual cause of the

[PATCH] pinctrl: add pinctrl_register_reason() to return proper error code

2015-05-29 Thread Masahiro Yamada
The pinctrl_register() just returns NULL on error, so the callers can not know the exact reason of the failure. Some of the pinctrl drivers return -EINVAL, some -ENODEV, and some -ENOMEM on error of pinctrl_register() , although the error code might be different from the actual cause of the

Re: [PATCH] pinctrl: add pinctrl_register_reason() to return proper error code

2015-05-29 Thread Sören Brinkmann
On Fri, 2015-05-29 at 08:30PM +0900, Masahiro Yamada wrote: The pinctrl_register() just returns NULL on error, so the callers can not know the exact reason of the failure. Some of the pinctrl drivers return -EINVAL, some -ENODEV, and some -ENOMEM on error of pinctrl_register() , although the