Re: [PATCH] pinctrl: at91-pio4: fix pull-up/down logic

2016-04-29 Thread Linus Walleij
On Tue, Apr 19, 2016 at 4:03 PM, Ludovic Desroches wrote: > The default configuration of a pin is often with a value in the > pull-up/down field at chip reset. So, even if the internal logic of the > controller prevents writing a configuration with pull-up and

Re: [PATCH] pinctrl: at91-pio4: fix pull-up/down logic

2016-04-29 Thread Linus Walleij
On Tue, Apr 19, 2016 at 4:03 PM, Ludovic Desroches wrote: > The default configuration of a pin is often with a value in the > pull-up/down field at chip reset. So, even if the internal logic of the > controller prevents writing a configuration with pull-up and pull-down at > the same time, we

Re: [PATCH] pinctrl: at91-pio4: fix pull-up/down logic

2016-04-19 Thread Nicolas Ferre
Le 19/04/2016 16:03, Ludovic Desroches a écrit : > The default configuration of a pin is often with a value in the > pull-up/down field at chip reset. So, even if the internal logic of the > controller prevents writing a configuration with pull-up and pull-down at > the same time, we must ensure

Re: [PATCH] pinctrl: at91-pio4: fix pull-up/down logic

2016-04-19 Thread Nicolas Ferre
Le 19/04/2016 16:03, Ludovic Desroches a écrit : > The default configuration of a pin is often with a value in the > pull-up/down field at chip reset. So, even if the internal logic of the > controller prevents writing a configuration with pull-up and pull-down at > the same time, we must ensure

Re: [PATCH] pinctrl: at91-pio4: fix pull-up/down logic

2016-04-19 Thread Alexandre Belloni
On 19/04/2016 at 16:03:45 +0200, Ludovic Desroches wrote : > The default configuration of a pin is often with a value in the > pull-up/down field at chip reset. So, even if the internal logic of the > controller prevents writing a configuration with pull-up and pull-down at > the same time, we

Re: [PATCH] pinctrl: at91-pio4: fix pull-up/down logic

2016-04-19 Thread Alexandre Belloni
On 19/04/2016 at 16:03:45 +0200, Ludovic Desroches wrote : > The default configuration of a pin is often with a value in the > pull-up/down field at chip reset. So, even if the internal logic of the > controller prevents writing a configuration with pull-up and pull-down at > the same time, we

[PATCH] pinctrl: at91-pio4: fix pull-up/down logic

2016-04-19 Thread Ludovic Desroches
The default configuration of a pin is often with a value in the pull-up/down field at chip reset. So, even if the internal logic of the controller prevents writing a configuration with pull-up and pull-down at the same time, we must ensure explicitly this condition before writing the register.

[PATCH] pinctrl: at91-pio4: fix pull-up/down logic

2016-04-19 Thread Ludovic Desroches
The default configuration of a pin is often with a value in the pull-up/down field at chip reset. So, even if the internal logic of the controller prevents writing a configuration with pull-up and pull-down at the same time, we must ensure explicitly this condition before writing the register.