Re: [PATCH] pinctrl: document the "GPIO mode" pitfall

2013-05-12 Thread Linus Walleij
On Sat, Apr 27, 2013 at 3:16 AM, Laurent Pinchart wrote: > On Friday 26 April 2013 10:49:12 Linus Walleij wrote: >> > Does DRIVE_* imply that the pin is driven by the selected function, and >> > OUTPUT imply that the pin is driven to a fixed level ? >> >> That is unclear, but I suggest DRIVE* imp

Re: [PATCH] pinctrl: document the "GPIO mode" pitfall

2013-04-26 Thread Laurent Pinchart
Hi Linus, On Friday 26 April 2013 10:49:12 Linus Walleij wrote: > On Fri, Apr 26, 2013 at 1:15 AM, Laurent Pinchart wrote: > > On Thursday 25 April 2013 23:39:18 Linus Walleij wrote: > >> On Tue, Apr 23, 2013 at 3:33 PM, Laurent Pinchart wrote: > >> > Could you clarify the exact scope of the two c

Re: [PATCH] pinctrl: document the "GPIO mode" pitfall

2013-04-26 Thread Linus Walleij
On Fri, Apr 26, 2013 at 1:15 AM, Laurent Pinchart wrote: > On Thursday 25 April 2013 23:39:18 Linus Walleij wrote: >> On Tue, Apr 23, 2013 at 3:33 PM, Laurent Pinchart wrote: >> > Could you clarify the exact scope of the two configuration parameters ? >> >> PIN_CONFIG_OUTPUT is left a bit unspeci

Re: [PATCH] pinctrl: document the "GPIO mode" pitfall

2013-04-25 Thread Laurent Pinchart
Hi Linus, On Thursday 25 April 2013 23:39:18 Linus Walleij wrote: > On Tue, Apr 23, 2013 at 3:33 PM, Laurent Pinchart wrote: > >> +And your machine configuration may look like this: > >> +-- > >> + > >> +static unsigned long uart_default_mode[] = { >

Re: [PATCH] pinctrl: document the "GPIO mode" pitfall

2013-04-25 Thread Linus Walleij
On Tue, Apr 23, 2013 at 3:33 PM, Laurent Pinchart wrote: >> +And your machine configuration may look like this: >> +-- >> + >> +static unsigned long uart_default_mode[] = { >> +PIN_CONF_PACKED(PIN_CONFIG_DRIVE_PUSH_PULL, 0), >> +}; >> + >> +stat

Re: [PATCH] pinctrl: document the "GPIO mode" pitfall

2013-04-23 Thread Laurent Pinchart
Hi Linus, On Friday 15 March 2013 12:07:16 Linus Walleij wrote: > From: Linus Walleij > > Recently as adoption of the pinctrl framework is reaching > niches where the pins are reconfigured during system sleep > and datasheets often talk about something called "GPIO mode", > some engineers become

Re: [PATCH] pinctrl: document the "GPIO mode" pitfall

2013-03-15 Thread Stephen Warren
On 03/15/2013 05:07 AM, Linus Walleij wrote: > From: Linus Walleij > > Recently as adoption of the pinctrl framework is reaching > niches where the pins are reconfigured during system sleep > and datasheets often talk about something called "GPIO mode", > some engineers become confused by this, t

[PATCH] pinctrl: document the "GPIO mode" pitfall

2013-03-15 Thread Linus Walleij
From: Linus Walleij Recently as adoption of the pinctrl framework is reaching niches where the pins are reconfigured during system sleep and datasheets often talk about something called "GPIO mode", some engineers become confused by this, thinking that since it is named "GPIO (something something