Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Fri, Jan 01, 2016 at 09:56:01AM +0800, Daniel Kurtz wrote: > On Fri, Jan 1, 2016 at 6:07 AM, Mark Brown wrote: > > On Thu, Dec 31, 2015 at 09:45:51PM +0800, Daniel Kurtz wrote: > >> Things are actively broken right now, in the sense that there are many > >> needless probe deferrals on boot.

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Fri, Jan 01, 2016 at 06:29:15PM +0100, Linus Walleij wrote: > On Fri, Jan 1, 2016 at 3:27 PM, Matthias Brugger > wrote: > > I think what Mark means is, that we define some pinctrl_initcall which > > is a macro to subsys_initcall (or arch_initcall or similar). We apply this > > to all pinctrl

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Fri, Jan 01, 2016 at 06:29:15PM +0100, Linus Walleij wrote: > On Fri, Jan 1, 2016 at 3:27 PM, Matthias Brugger > wrote: > > I think what Mark means is, that we define some pinctrl_initcall which > > is a macro to subsys_initcall (or arch_initcall or similar). We apply

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Fri, Jan 01, 2016 at 09:56:01AM +0800, Daniel Kurtz wrote: > On Fri, Jan 1, 2016 at 6:07 AM, Mark Brown wrote: > > On Thu, Dec 31, 2015 at 09:45:51PM +0800, Daniel Kurtz wrote: > >> Things are actively broken right now, in the sense that there are many > >> needless probe

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Fri, Jan 1, 2016 at 3:27 PM, Matthias Brugger wrote: > On January 1, 2016 3:56:01 AM EET, Daniel Kurtz wrote: >>> It's fairly clear that there's at least a case for simplifying the >>> existing practice here, for example by moving everything into a >>single >>> (perhaps aliased) initcall

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On January 1, 2016 3:56:01 AM EET, Daniel Kurtz wrote: >Hi Mark, > >Thanks for responding. > >On Fri, Jan 1, 2016 at 6:07 AM, Mark Brown wrote: >> On Thu, Dec 31, 2015 at 09:45:51PM +0800, Daniel Kurtz wrote: >>> On Thu, Dec 31, 2015 at 1:22 AM, Mark Brown >wrote: >> >>> > I really don't

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On January 1, 2016 3:56:01 AM EET, Daniel Kurtz wrote: >Hi Mark, > >Thanks for responding. > >On Fri, Jan 1, 2016 at 6:07 AM, Mark Brown wrote: >> On Thu, Dec 31, 2015 at 09:45:51PM +0800, Daniel Kurtz wrote: >>> On Thu, Dec 31, 2015 at 1:22 AM, Mark

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Fri, Jan 1, 2016 at 3:27 PM, Matthias Brugger wrote: > On January 1, 2016 3:56:01 AM EET, Daniel Kurtz wrote: >>> It's fairly clear that there's at least a case for simplifying the >>> existing practice here, for example by moving everything into

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

Hi Mark, Thanks for responding. On Fri, Jan 1, 2016 at 6:07 AM, Mark Brown wrote: > On Thu, Dec 31, 2015 at 09:45:51PM +0800, Daniel Kurtz wrote: >> On Thu, Dec 31, 2015 at 1:22 AM, Mark Brown wrote: > >> > I really don't think we should be applying this sort of stuff unless >> > things are

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Thu, Dec 31, 2015 at 09:45:51PM +0800, Daniel Kurtz wrote: > On Thu, Dec 31, 2015 at 1:22 AM, Mark Brown wrote: > > I really don't think we should be applying this sort of stuff unless > > things are actively broken right now. It's a bit of a rabbit hole we > > could spend a long time going

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Thu, Dec 31, 2015 at 1:22 AM, Mark Brown wrote: > > On Tue, Dec 22, 2015 at 04:11:47PM +0100, Linus Walleij wrote: > > On Tue, Dec 22, 2015 at 2:46 PM, Daniel Kurtz wrote: > > > > Move pinctrl initialization earlier in boot so that real devices can find > > > their pctldev without probe

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Thu, Dec 31, 2015 at 1:22 AM, Mark Brown wrote: > > On Tue, Dec 22, 2015 at 04:11:47PM +0100, Linus Walleij wrote: > > On Tue, Dec 22, 2015 at 2:46 PM, Daniel Kurtz wrote: > > > > Move pinctrl initialization earlier in boot so that real devices can

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

Hi Mark, Thanks for responding. On Fri, Jan 1, 2016 at 6:07 AM, Mark Brown wrote: > On Thu, Dec 31, 2015 at 09:45:51PM +0800, Daniel Kurtz wrote: >> On Thu, Dec 31, 2015 at 1:22 AM, Mark Brown wrote: > >> > I really don't think we should be applying this

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Thu, Dec 31, 2015 at 09:45:51PM +0800, Daniel Kurtz wrote: > On Thu, Dec 31, 2015 at 1:22 AM, Mark Brown wrote: > > I really don't think we should be applying this sort of stuff unless > > things are actively broken right now. It's a bit of a rabbit hole we > > could

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Tue, Dec 22, 2015 at 04:11:47PM +0100, Linus Walleij wrote: > On Tue, Dec 22, 2015 at 2:46 PM, Daniel Kurtz wrote: > > Move pinctrl initialization earlier in boot so that real devices can find > > their pctldev without probe deferring. > (...) > > -module_init(mtk_pinctrl_init); > >

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Tue, Dec 22, 2015 at 04:11:47PM +0100, Linus Walleij wrote: > On Tue, Dec 22, 2015 at 2:46 PM, Daniel Kurtz wrote: > > Move pinctrl initialization earlier in boot so that real devices can find > > their pctldev without probe deferring. > (...) > >

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Tue, Dec 22, 2015 at 2:46 PM, Daniel Kurtz wrote: > Move pinctrl initialization earlier in boot so that real devices can find > their pctldev without probe deferring. (...) > -module_init(mtk_pinctrl_init); > +arch_initcall(mtk_pinctrl_init); So I see why you're doing this (because of

[PATCH] pinctrl: mediatek: convert to arch_initcall

Move pinctrl initialization earlier in boot so that real devices can find their pctldev without probe deferring. Note: We don't change mt6397 probe order in this patch, since MT6397 is mfd PMIC, which depends on pwrap on main AP to work. Since pmic-wrap itself is module_platform_driver, we keep

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Tue, Dec 22, 2015 at 9:36 PM, Yingjoe Chen wrote: > On Tue, 2015-12-22 at 11:23 +0100, Linus Walleij wrote: >> On Fri, Dec 18, 2015 at 5:21 AM, Daniel Kurtz wrote: >> >> > Move pinctrl initialization earlier in boot so that real devices can find >> > their pctldev without probe deferring. >>

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Tue, 2015-12-22 at 11:23 +0100, Linus Walleij wrote: > On Fri, Dec 18, 2015 at 5:21 AM, Daniel Kurtz wrote: > > > Move pinctrl initialization earlier in boot so that real devices can find > > their pctldev without probe deferring. > > > > Signed-off-by: Daniel Kurtz > > I interpret the

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Fri, Dec 18, 2015 at 5:21 AM, Daniel Kurtz wrote: > Move pinctrl initialization earlier in boot so that real devices can find > their pctldev without probe deferring. > > Signed-off-by: Daniel Kurtz I interpret the discussion as I should wait for a new version of this? Or should it be

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Tue, Dec 22, 2015 at 2:46 PM, Daniel Kurtz wrote: > Move pinctrl initialization earlier in boot so that real devices can find > their pctldev without probe deferring. (...) > -module_init(mtk_pinctrl_init); > +arch_initcall(mtk_pinctrl_init); So I see why you're doing

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Fri, Dec 18, 2015 at 5:21 AM, Daniel Kurtz wrote: > Move pinctrl initialization earlier in boot so that real devices can find > their pctldev without probe deferring. > > Signed-off-by: Daniel Kurtz I interpret the discussion as I should wait for

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Tue, 2015-12-22 at 11:23 +0100, Linus Walleij wrote: > On Fri, Dec 18, 2015 at 5:21 AM, Daniel Kurtz wrote: > > > Move pinctrl initialization earlier in boot so that real devices can find > > their pctldev without probe deferring. > > > > Signed-off-by: Daniel Kurtz

[PATCH] pinctrl: mediatek: convert to arch_initcall

Move pinctrl initialization earlier in boot so that real devices can find their pctldev without probe deferring. Note: We don't change mt6397 probe order in this patch, since MT6397 is mfd PMIC, which depends on pwrap on main AP to work. Since pmic-wrap itself is module_platform_driver, we keep

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Tue, Dec 22, 2015 at 9:36 PM, Yingjoe Chen wrote: > On Tue, 2015-12-22 at 11:23 +0100, Linus Walleij wrote: >> On Fri, Dec 18, 2015 at 5:21 AM, Daniel Kurtz wrote: >> >> > Move pinctrl initialization earlier in boot so that real devices can

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Mon, Dec 21, 2015 at 8:39 PM, Yingjoe Chen wrote: > > On Mon, 2015-12-21 at 14:51 +0800, Daniel Kurtz wrote: > > On Fri, Dec 18, 2015 at 11:06 PM, Yingjoe Chen > > wrote: > > > On Fri, 2015-12-18 at 12:21 +0800, Daniel Kurtz wrote: > > >> Move pinctrl initialization earlier in boot so that

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Mon, 2015-12-21 at 14:51 +0800, Daniel Kurtz wrote: > On Fri, Dec 18, 2015 at 11:06 PM, Yingjoe Chen > wrote: > > On Fri, 2015-12-18 at 12:21 +0800, Daniel Kurtz wrote: > >> Move pinctrl initialization earlier in boot so that real devices can find > >> their pctldev without probe deferring. >

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Mon, Dec 21, 2015 at 8:39 PM, Yingjoe Chen wrote: > > On Mon, 2015-12-21 at 14:51 +0800, Daniel Kurtz wrote: > > On Fri, Dec 18, 2015 at 11:06 PM, Yingjoe Chen > > wrote: > > > On Fri, 2015-12-18 at 12:21 +0800, Daniel Kurtz wrote: > > >>

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Mon, 2015-12-21 at 14:51 +0800, Daniel Kurtz wrote: > On Fri, Dec 18, 2015 at 11:06 PM, Yingjoe Chen > wrote: > > On Fri, 2015-12-18 at 12:21 +0800, Daniel Kurtz wrote: > >> Move pinctrl initialization earlier in boot so that real devices can find > >> their pctldev

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Fri, Dec 18, 2015 at 11:06 PM, Yingjoe Chen wrote: > On Fri, 2015-12-18 at 12:21 +0800, Daniel Kurtz wrote: >> Move pinctrl initialization earlier in boot so that real devices can find >> their pctldev without probe deferring. >> >> Signed-off-by: Daniel Kurtz >> --- >>

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Fri, Dec 18, 2015 at 11:06 PM, Yingjoe Chen wrote: > On Fri, 2015-12-18 at 12:21 +0800, Daniel Kurtz wrote: >> Move pinctrl initialization earlier in boot so that real devices can find >> their pctldev without probe deferring. >> >> Signed-off-by: Daniel Kurtz

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Fri, 2015-12-18 at 12:21 +0800, Daniel Kurtz wrote: > Move pinctrl initialization earlier in boot so that real devices can find > their pctldev without probe deferring. > > Signed-off-by: Daniel Kurtz > --- > drivers/pinctrl/mediatek/pinctrl-mt6397.c | 2 +- >

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Fri, 2015-12-18 at 12:21 +0800, Daniel Kurtz wrote: > Move pinctrl initialization earlier in boot so that real devices can find > their pctldev without probe deferring. > > Signed-off-by: Daniel Kurtz > --- > drivers/pinctrl/mediatek/pinctrl-mt6397.c | 2 +- >

[PATCH] pinctrl: mediatek: convert to arch_initcall

Move pinctrl initialization earlier in boot so that real devices can find their pctldev without probe deferring. Signed-off-by: Daniel Kurtz --- drivers/pinctrl/mediatek/pinctrl-mt6397.c | 2 +- drivers/pinctrl/mediatek/pinctrl-mt8127.c | 2 +- drivers/pinctrl/mediatek/pinctrl-mt8135.c | 2 +-

[PATCH] pinctrl: mediatek: convert to arch_initcall

Move pinctrl initialization earlier in boot so that real devices can find their pctldev without probe deferring. Signed-off-by: Daniel Kurtz --- drivers/pinctrl/mediatek/pinctrl-mt6397.c | 2 +- drivers/pinctrl/mediatek/pinctrl-mt8127.c | 2 +-