Re: [PATCH] pinctrl: move subsystem mutex to pinctrl_dev struct

2013-04-24 Thread Linus Walleij
On Wed, Apr 10, 2013 at 3:04 PM, Patrice CHOTARD wrote: > On 03/28/2013 12:33 AM, Stephen Warren wrote: I don't understand the link between maps and pinctrl_select(), pinctrl_select_state_locked() doesn't touch the map. >> >> Yes, pinctrl_select() shouldn't touch the map since it's

Re: [PATCH] pinctrl: move subsystem mutex to pinctrl_dev struct

2013-04-24 Thread Linus Walleij
On Wed, Apr 10, 2013 at 3:04 PM, Patrice CHOTARD patrice.chot...@st.com wrote: On 03/28/2013 12:33 AM, Stephen Warren wrote: I don't understand the link between maps and pinctrl_select(), pinctrl_select_state_locked() doesn't touch the map. Yes, pinctrl_select() shouldn't touch the map since

Re: [PATCH] pinctrl: move subsystem mutex to pinctrl_dev struct

2013-04-10 Thread Patrice CHOTARD
On 03/28/2013 12:33 AM, Stephen Warren wrote: > On 03/27/2013 03:45 PM, Linus Walleij wrote: >> On Thu, Mar 14, 2013 at 5:59 PM, Patrice CHOTARD >> wrote: >>> On 03/13/2013 07:22 PM, Stephen Warren wrote: >>> On 03/13/2013 09:44 AM, Linus Walleij wrote: > From: Patrice Chotard >

Re: [PATCH] pinctrl: move subsystem mutex to pinctrl_dev struct

2013-04-10 Thread Patrice CHOTARD
On 03/28/2013 12:33 AM, Stephen Warren wrote: On 03/27/2013 03:45 PM, Linus Walleij wrote: On Thu, Mar 14, 2013 at 5:59 PM, Patrice CHOTARD patrice.chot...@st.com wrote: On 03/13/2013 07:22 PM, Stephen Warren wrote: On 03/13/2013 09:44 AM, Linus Walleij wrote: From: Patrice Chotard

Re: [PATCH] pinctrl: move subsystem mutex to pinctrl_dev struct

2013-03-27 Thread Stephen Warren
On 03/27/2013 03:45 PM, Linus Walleij wrote: > On Thu, Mar 14, 2013 at 5:59 PM, Patrice CHOTARD > wrote: >> On 03/13/2013 07:22 PM, Stephen Warren wrote: >> >>> On 03/13/2013 09:44 AM, Linus Walleij wrote: From: Patrice Chotard This mutex avoids deadlock in case of use of

Re: [PATCH] pinctrl: move subsystem mutex to pinctrl_dev struct

2013-03-27 Thread Linus Walleij
On Thu, Mar 14, 2013 at 5:59 PM, Patrice CHOTARD wrote: > On 03/13/2013 07:22 PM, Stephen Warren wrote: > >> On 03/13/2013 09:44 AM, Linus Walleij wrote: >>> From: Patrice Chotard >>> >>> This mutex avoids deadlock in case of use of multiple pin >>> controllers. Before this modification, by

Re: [PATCH] pinctrl: move subsystem mutex to pinctrl_dev struct

2013-03-27 Thread Linus Walleij
On Thu, Mar 14, 2013 at 5:59 PM, Patrice CHOTARD patrice.chot...@st.com wrote: On 03/13/2013 07:22 PM, Stephen Warren wrote: On 03/13/2013 09:44 AM, Linus Walleij wrote: From: Patrice Chotard patrice.chot...@st.com This mutex avoids deadlock in case of use of multiple pin controllers.

Re: [PATCH] pinctrl: move subsystem mutex to pinctrl_dev struct

2013-03-27 Thread Stephen Warren
On 03/27/2013 03:45 PM, Linus Walleij wrote: On Thu, Mar 14, 2013 at 5:59 PM, Patrice CHOTARD patrice.chot...@st.com wrote: On 03/13/2013 07:22 PM, Stephen Warren wrote: On 03/13/2013 09:44 AM, Linus Walleij wrote: From: Patrice Chotard patrice.chot...@st.com This mutex avoids deadlock in

Re: [PATCH] pinctrl: move subsystem mutex to pinctrl_dev struct

2013-03-14 Thread Patrice CHOTARD
On 03/13/2013 07:22 PM, Stephen Warren wrote: > On 03/13/2013 09:44 AM, Linus Walleij wrote: >> From: Patrice Chotard >> >> This mutex avoids deadlock in case of use of multiple pin >> controllers. Before this modification, by using a global >> mutex, deadlock appeared when, for example, a call

Re: [PATCH] pinctrl: move subsystem mutex to pinctrl_dev struct

2013-03-14 Thread Patrice CHOTARD
On 03/13/2013 07:22 PM, Stephen Warren wrote: On 03/13/2013 09:44 AM, Linus Walleij wrote: From: Patrice Chotard patrice.chot...@st.com This mutex avoids deadlock in case of use of multiple pin controllers. Before this modification, by using a global mutex, deadlock appeared when, for

Re: [PATCH] pinctrl: move subsystem mutex to pinctrl_dev struct

2013-03-13 Thread Stephen Warren
On 03/13/2013 09:44 AM, Linus Walleij wrote: > From: Patrice Chotard > > This mutex avoids deadlock in case of use of multiple pin > controllers. Before this modification, by using a global > mutex, deadlock appeared when, for example, a call to > pinctrl_pins_show() locked the pinctrl_mutex,

[PATCH] pinctrl: move subsystem mutex to pinctrl_dev struct

2013-03-13 Thread Linus Walleij
From: Patrice Chotard This mutex avoids deadlock in case of use of multiple pin controllers. Before this modification, by using a global mutex, deadlock appeared when, for example, a call to pinctrl_pins_show() locked the pinctrl_mutex, called the ops->pin_dbg_show of a particular pin

[PATCH] pinctrl: move subsystem mutex to pinctrl_dev struct

2013-03-13 Thread Linus Walleij
From: Patrice Chotard patrice.chot...@st.com This mutex avoids deadlock in case of use of multiple pin controllers. Before this modification, by using a global mutex, deadlock appeared when, for example, a call to pinctrl_pins_show() locked the pinctrl_mutex, called the ops-pin_dbg_show of a

Re: [PATCH] pinctrl: move subsystem mutex to pinctrl_dev struct

2013-03-13 Thread Stephen Warren
On 03/13/2013 09:44 AM, Linus Walleij wrote: From: Patrice Chotard patrice.chot...@st.com This mutex avoids deadlock in case of use of multiple pin controllers. Before this modification, by using a global mutex, deadlock appeared when, for example, a call to pinctrl_pins_show() locked the