Re: [PATCH] pinctrl: msm: Add check for pinctrl group is valid

2020-06-02 Thread Mayank Grover
On Mon, May 25, 2020 at 11:02:14AM +0200, Linus Walleij wrote: > On Tue, May 19, 2020 at 3:39 AM Bjorn Andersson > wrote: > > > @Linus, we started off with something similar for GPIOs and ended up > > with the logic in the core code. Should we somehow try to do the same > > for pinctrl? > >

Re: [PATCH] pinctrl: msm: Add check for pinctrl group is valid

2020-05-25 Thread Linus Walleij
On Tue, May 19, 2020 at 3:39 AM Bjorn Andersson wrote: > @Linus, we started off with something similar for GPIOs and ended up > with the logic in the core code. Should we somehow try to do the same > for pinctrl? msm_pingroup_is_valid() looks very reusable but I'm afraid I do not understand the

Re: [PATCH] pinctrl: msm: Add check for pinctrl group is valid

2020-05-19 Thread Mayank Grover
O Mon, May 18, 2020 at 06:38:13PM -0700, Bjorn Andersson wrote: > On Mon 18 May 08:50 PDT 2020, Mayank Grover wrote: > > > The list of reserved gpio pins for platform are populated > > in gpiochip valid_mask. > > > > Here on MSM common driver introduce ability to check if > > pingroup is valid,

Re: [PATCH] pinctrl: msm: Add check for pinctrl group is valid

2020-05-18 Thread Bjorn Andersson
On Mon 18 May 08:50 PDT 2020, Mayank Grover wrote: > The list of reserved gpio pins for platform are populated > in gpiochip valid_mask. > > Here on MSM common driver introduce ability to check if > pingroup is valid, by parsing pins in pingroup against > reserved pins for gpios. This does not

[PATCH] pinctrl: msm: Add check for pinctrl group is valid

2020-05-18 Thread Mayank Grover
The list of reserved gpio pins for platform are populated in gpiochip valid_mask. Here on MSM common driver introduce ability to check if pingroup is valid, by parsing pins in pingroup against reserved pins for gpios. This does not handle non-gpio pingroups. Signed-off-by: Mayank Grover ---