Re: [PATCH] pinctrl: qcom: lpass lpi: use default pullup/strength values

2021-03-10 Thread Linus Walleij
On Thu, Mar 4, 2021 at 8:49 PM Jonathan Marek wrote: > If these fields are not set in dts, the driver will use these variables > uninitialized to set the fields. Not only will it set garbage values for > these fields, but it can overflow into other fields and break those. > > In the current sm825

Re: [PATCH] pinctrl: qcom: lpass lpi: use default pullup/strength values

2021-03-05 Thread Srinivas Kandagatla
Thanks Jonathan for fixing this! On 04/03/2021 19:48, Jonathan Marek wrote: If these fields are not set in dts, the driver will use these variables uninitialized to set the fields. Not only will it set garbage values for these fields, but it can overflow into other fields and break those. In th

Re: [PATCH] pinctrl: qcom: lpass lpi: use default pullup/strength values

2021-03-04 Thread Jonathan Marek
On 3/4/21 7:05 PM, Bjorn Andersson wrote: On Thu 04 Mar 13:48 CST 2021, Jonathan Marek wrote: If these fields are not set in dts, the driver will use these variables uninitialized to set the fields. Not only will it set garbage values for these fields, but it can overflow into other fields and

Re: [PATCH] pinctrl: qcom: lpass lpi: use default pullup/strength values

2021-03-04 Thread Bjorn Andersson
On Thu 04 Mar 13:48 CST 2021, Jonathan Marek wrote: > If these fields are not set in dts, the driver will use these variables > uninitialized to set the fields. Not only will it set garbage values for > these fields, but it can overflow into other fields and break those. > > In the current sm8250

[PATCH] pinctrl: qcom: lpass lpi: use default pullup/strength values

2021-03-04 Thread Jonathan Marek
If these fields are not set in dts, the driver will use these variables uninitialized to set the fields. Not only will it set garbage values for these fields, but it can overflow into other fields and break those. In the current sm8250 dts, the dmic01 entries do not have a pullup setting, and migh