Re: [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined

2019-05-24 Thread Amelie DELAUNAY
On 5/23/19 9:18 PM, Linus Walleij wrote: > On Thu, May 23, 2019 at 4:11 PM Amelie DELAUNAY > wrote: >> On 5/22/19 11:48 PM, Linus Walleij wrote: >>> On Wed, May 22, 2019 at 11:21 AM Amelie DELAUNAY >>> wrote: >>> ../drivers/pinctrl/pinctrl-stmfx.c:409:20: error: ‘pinconf_generic_dt_no

Re: [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined

2019-05-23 Thread Linus Walleij
On Thu, May 23, 2019 at 4:11 PM Amelie DELAUNAY wrote: > On 5/22/19 11:48 PM, Linus Walleij wrote: > > On Wed, May 22, 2019 at 11:21 AM Amelie DELAUNAY > > wrote: > > > >> ../drivers/pinctrl/pinctrl-stmfx.c:409:20: error: > >> ‘pinconf_generic_dt_node_to_map_pin’ undeclared here (not in a functi

Re: [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined

2019-05-23 Thread Amelie DELAUNAY
On 5/22/19 11:48 PM, Linus Walleij wrote: > On Wed, May 22, 2019 at 11:21 AM Amelie DELAUNAY > wrote: > >> ../drivers/pinctrl/pinctrl-stmfx.c:409:20: error: >> ‘pinconf_generic_dt_node_to_map_pin’ undeclared here (not in a function) >> .dt_node_to_map = pinconf_generic_dt_node_to_map_pin, >>

Re: [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined

2019-05-22 Thread Linus Walleij
On Wed, May 22, 2019 at 11:21 AM Amelie DELAUNAY wrote: > ../drivers/pinctrl/pinctrl-stmfx.c:409:20: error: > ‘pinconf_generic_dt_node_to_map_pin’ undeclared here (not in a function) >.dt_node_to_map = pinconf_generic_dt_node_to_map_pin, > > OF_GPIO depends on OF. > > So either > depends

Re: [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined

2019-05-22 Thread Lee Jones
On Wed, 22 May 2019, Amelie DELAUNAY wrote: > On 5/22/19 10:41 AM, Lee Jones wrote: > > On Wed, 22 May 2019, Amelie DELAUNAY wrote: > >> On 5/22/19 7:48 AM, Lee Jones wrote: > >>> On Mon, 20 May 2019, Amelie Delaunay wrote: > >>> > When CONFIG_GPIO_OF is not defined, struct gpio_chip 'of_node

Re: [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined

2019-05-22 Thread Amelie DELAUNAY
On 5/22/19 10:41 AM, Lee Jones wrote: > On Wed, 22 May 2019, Amelie DELAUNAY wrote: >> On 5/22/19 7:48 AM, Lee Jones wrote: >>> On Mon, 20 May 2019, Amelie Delaunay wrote: >>> When CONFIG_GPIO_OF is not defined, struct gpio_chip 'of_node' member does not exist: drivers/pinctrl/pinctr

Re: [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined

2019-05-22 Thread Lee Jones
On Wed, 22 May 2019, Amelie DELAUNAY wrote: > On 5/22/19 7:48 AM, Lee Jones wrote: > > On Mon, 20 May 2019, Amelie Delaunay wrote: > > > >> When CONFIG_GPIO_OF is not defined, struct gpio_chip 'of_node' member does > >> not exist: > >> drivers/pinctrl/pinctrl-stmfx.c: In function 'stmfx_pinctrl_pr

Re: [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined

2019-05-22 Thread Amelie DELAUNAY
On 5/22/19 7:48 AM, Lee Jones wrote: > On Mon, 20 May 2019, Amelie Delaunay wrote: > >> When CONFIG_GPIO_OF is not defined, struct gpio_chip 'of_node' member does >> not exist: >> drivers/pinctrl/pinctrl-stmfx.c: In function 'stmfx_pinctrl_probe': >> drivers/pinctrl/pinctrl-stmfx.c:652:17: error

Re: [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined

2019-05-21 Thread Lee Jones
On Mon, 20 May 2019, Amelie Delaunay wrote: > When CONFIG_GPIO_OF is not defined, struct gpio_chip 'of_node' member does > not exist: > drivers/pinctrl/pinctrl-stmfx.c: In function 'stmfx_pinctrl_probe': > drivers/pinctrl/pinctrl-stmfx.c:652:17: error: 'struct gpio_chip' has no > member named 'of

Re: [PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined

2019-05-21 Thread Randy Dunlap
On 5/20/19 12:52 AM, Amelie Delaunay wrote: > When CONFIG_GPIO_OF is not defined, struct gpio_chip 'of_node' member does > not exist: > drivers/pinctrl/pinctrl-stmfx.c: In function 'stmfx_pinctrl_probe': > drivers/pinctrl/pinctrl-stmfx.c:652:17: error: 'struct gpio_chip' has no > member named 'of_

[PATCH] pinctrl: stmfx: Fix compile issue when CONFIG_OF_GPIO is not defined

2019-05-20 Thread Amelie Delaunay
When CONFIG_GPIO_OF is not defined, struct gpio_chip 'of_node' member does not exist: drivers/pinctrl/pinctrl-stmfx.c: In function 'stmfx_pinctrl_probe': drivers/pinctrl/pinctrl-stmfx.c:652:17: error: 'struct gpio_chip' has no member named 'of_node' pctl->gpio_chip.of_node = np; Fixes: 1490d