Re: [PATCH] platform/chrome: fix a double-unlock issue

Hi Qiushi, Thank you for the patch. On 23/5/20 5:16, wu000...@umn.edu wrote: > From: Qiushi Wu > > In function cros_ec_ishtp_probe(), "up_write" is already called > before function "cros_ec_dev_init". But "up_write" will be called > again after the calling of the function "cros_ec_dev_init" fai

Re: [PATCH] platform/chrome: fix a double-unlock issue

On Thu, Jun 25, 2020 at 2:26 AM Enric Balletbo i Serra wrote: > > Hi Qiushi, > > Thank you for your patch. > > On 23/5/20 5:16, wu000...@umn.edu wrote: > > From: Qiushi Wu > > > > In function cros_ec_ishtp_probe(), "up_write" is already called > > before function "cros_ec_dev_init". But "up_write

Re: [PATCH] platform/chrome: fix a double-unlock issue

Hi Qiushi, Thank you for your patch. On 23/5/20 5:16, wu000...@umn.edu wrote: > From: Qiushi Wu > > In function cros_ec_ishtp_probe(), "up_write" is already called > before function "cros_ec_dev_init". But "up_write" will be called > again after the calling of the function "cros_ec_dev_init" fa

[PATCH] platform/chrome: fix a double-unlock issue

From: Qiushi Wu In function cros_ec_ishtp_probe(), "up_write" is already called before function "cros_ec_dev_init". But "up_write" will be called again after the calling of the function "cros_ec_dev_init" failed. Thus add a call of the function “down_write” in this if branch for the completion of