RE: [PATCH] platform/x86: dell-smbios-base: Fix use after free on failure of dell_smbios_init()

2019-04-03 Thread Mario.Limonciello
> -Original Message- > From: Darren Hart > Sent: Wednesday, April 3, 2019 3:16 PM > To: Steven Rostedt; Limonciello, Mario > Cc: LKML; platform-driver-...@vger.kernel.org; Andy Shevchenko; Pali Rohár; > Tom > Zanussi > Subject: Re: [PATCH] platform/x86: dell-sm

Re: [PATCH] platform/x86: dell-smbios-base: Fix use after free on failure of dell_smbios_init()

2019-04-03 Thread Darren Hart
On Wed, Apr 03, 2019 at 03:20:18PM -0400, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > If da_tokens are allocated, but dell_smbios_init() eventually fails, it will > free the da_tokens but it does not reset the da_num_tokens number. This > leads to the possibility of a use after

[PATCH] platform/x86: dell-smbios-base: Fix use after free on failure of dell_smbios_init()

2019-04-03 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" If da_tokens are allocated, but dell_smbios_init() eventually fails, it will free the da_tokens but it does not reset the da_num_tokens number. This leads to the possibility of a use after free in dell_smbios_find_token(). As da_tokens is not NULL and