Re: [PATCH] platform/x86: fujitsu-laptop: Revert UNSUPPORTED_CMD back to an int

2018-03-21 Thread Darren Hart
On Sun, Mar 11, 2018 at 02:40:56PM +1030, Jonathan Woithe wrote: > On Sat, Mar 10, 2018 at 09:43:53PM +0100, Micha?? K??pie?? wrote: > > UNSUPPORTED_CMD was previously 0x8000 (int), but commit 819cddae7cfa > > ("platform/x86: fujitsu-laptop: Clean up constants") changed it into an > > unsigned

Re: [PATCH] platform/x86: fujitsu-laptop: Revert UNSUPPORTED_CMD back to an int

2018-03-21 Thread Darren Hart
On Sun, Mar 11, 2018 at 02:40:56PM +1030, Jonathan Woithe wrote: > On Sat, Mar 10, 2018 at 09:43:53PM +0100, Micha?? K??pie?? wrote: > > UNSUPPORTED_CMD was previously 0x8000 (int), but commit 819cddae7cfa > > ("platform/x86: fujitsu-laptop: Clean up constants") changed it into an > > unsigned

Re: [PATCH] platform/x86: fujitsu-laptop: Revert UNSUPPORTED_CMD back to an int

2018-03-10 Thread Jonathan Woithe
On Sat, Mar 10, 2018 at 09:43:53PM +0100, Micha?? K??pie?? wrote: > UNSUPPORTED_CMD was previously 0x8000 (int), but commit 819cddae7cfa > ("platform/x86: fujitsu-laptop: Clean up constants") changed it into an > unsigned long due to BIT() being used to define it. As call_fext_func() >

Re: [PATCH] platform/x86: fujitsu-laptop: Revert UNSUPPORTED_CMD back to an int

2018-03-10 Thread Jonathan Woithe
On Sat, Mar 10, 2018 at 09:43:53PM +0100, Micha?? K??pie?? wrote: > UNSUPPORTED_CMD was previously 0x8000 (int), but commit 819cddae7cfa > ("platform/x86: fujitsu-laptop: Clean up constants") changed it into an > unsigned long due to BIT() being used to define it. As call_fext_func() >

[PATCH] platform/x86: fujitsu-laptop: Revert UNSUPPORTED_CMD back to an int

2018-03-10 Thread Michał Kępień
UNSUPPORTED_CMD was previously 0x8000 (int), but commit 819cddae7cfa ("platform/x86: fujitsu-laptop: Clean up constants") changed it into an unsigned long due to BIT() being used to define it. As call_fext_func() returns an int, 0x8000 would get type promoted when compared to an unsigned

[PATCH] platform/x86: fujitsu-laptop: Revert UNSUPPORTED_CMD back to an int

2018-03-10 Thread Michał Kępień
UNSUPPORTED_CMD was previously 0x8000 (int), but commit 819cddae7cfa ("platform/x86: fujitsu-laptop: Clean up constants") changed it into an unsigned long due to BIT() being used to define it. As call_fext_func() returns an int, 0x8000 would get type promoted when compared to an unsigned