Re: [PATCH] platform/x86: intel_cht_int33fe: Work around BIOS bug on some devices

2017-09-02 Thread Mika Westerberg
On Fri, Sep 01, 2017 at 11:58:55PM +0200, Hans de Goede wrote: > Given that on the device in question where we need this workaround there > is only ever 1 max17047, including the instance number in the check really > is a non-problem, but if there is a strong preference for me to change > the check

Re: [PATCH] platform/x86: intel_cht_int33fe: Work around BIOS bug on some devices

2017-09-01 Thread Hans de Goede
Hi, On 09/01/2017 11:19 AM, Mika Westerberg wrote: On Thu, Aug 31, 2017 at 07:04:46PM +0300, Andy Shevchenko wrote: On Mon, Aug 14, 2017 at 11:52 PM, Hans de Goede wrote: On 14-08-17 22:45, Andy Shevchenko wrote: On Mon, Aug 14, 2017 at 11:14 PM, Hans de Goede wrote: +int cht_int33fe_che

Re: [PATCH] platform/x86: intel_cht_int33fe: Work around BIOS bug on some devices

2017-09-01 Thread Mika Westerberg
On Thu, Aug 31, 2017 at 07:04:46PM +0300, Andy Shevchenko wrote: > On Mon, Aug 14, 2017 at 11:52 PM, Hans de Goede wrote: > > On 14-08-17 22:45, Andy Shevchenko wrote: > >> On Mon, Aug 14, 2017 at 11:14 PM, Hans de Goede > >> wrote: > > >>> +int cht_int33fe_check_for_max17047(struct device *dev,

Re: [PATCH] platform/x86: intel_cht_int33fe: Work around BIOS bug on some devices

2017-08-31 Thread Jarkko Nikula
On 08/31/2017 07:04 PM, Andy Shevchenko wrote: On Mon, Aug 14, 2017 at 11:52 PM, Hans de Goede wrote: On 14-08-17 22:45, Andy Shevchenko wrote: On Mon, Aug 14, 2017 at 11:14 PM, Hans de Goede wrote: +int cht_int33fe_check_for_max17047(struct device *dev, void *data) +{ + const char *

Re: [PATCH] platform/x86: intel_cht_int33fe: Work around BIOS bug on some devices

2017-08-31 Thread Andy Shevchenko
On Mon, Aug 14, 2017 at 11:52 PM, Hans de Goede wrote: > On 14-08-17 22:45, Andy Shevchenko wrote: >> On Mon, Aug 14, 2017 at 11:14 PM, Hans de Goede >> wrote: >>> +int cht_int33fe_check_for_max17047(struct device *dev, void *data) >>> +{ >>> + const char *name = dev_name(dev); >>> +

Re: [PATCH] platform/x86: intel_cht_int33fe: Work around BIOS bug on some devices

2017-08-31 Thread Hans de Goede
Hi, On 14-08-17 22:14, Hans de Goede wrote: At least one BIOS enumerates the max17047 both through the INT33FE ACPI device (it is right there in the resources table) as well as through a separate MAX17047 device. This commit checks for the max17047 already being enumerated through a separate MA

Re: [PATCH] platform/x86: intel_cht_int33fe: Work around BIOS bug on some devices

2017-08-14 Thread Hans de Goede
Hi, On 14-08-17 22:45, Andy Shevchenko wrote: On Mon, Aug 14, 2017 at 11:14 PM, Hans de Goede wrote: At least one BIOS enumerates the max17047 both through the INT33FE ACPI device (it is right there in the resources table) as well as through a separate MAX17047 device. This commit checks for

Re: [PATCH] platform/x86: intel_cht_int33fe: Work around BIOS bug on some devices

2017-08-14 Thread Andy Shevchenko
On Mon, Aug 14, 2017 at 11:14 PM, Hans de Goede wrote: > At least one BIOS enumerates the max17047 both through the INT33FE ACPI > device (it is right there in the resources table) as well as through a > separate MAX17047 device. > > This commit checks for the max17047 already being enumerated thr

[PATCH] platform/x86: intel_cht_int33fe: Work around BIOS bug on some devices

2017-08-14 Thread Hans de Goede
At least one BIOS enumerates the max17047 both through the INT33FE ACPI device (it is right there in the resources table) as well as through a separate MAX17047 device. This commit checks for the max17047 already being enumerated through a separate MAX17047 ACPI device and if so it uses the i2c-cl