Re: [PATCH] platform/x86: thinkpad_acpi: initialize tp_nvram_state variable

2020-09-17 Thread mark gross
Acked-by: mark gross --mark On Sun, Sep 13, 2020 at 12:02:03PM -0700, t...@redhat.com wrote: > From: Tom Rix > > clang static analysis flags this represenative problem > thinkpad_acpi.c:2523:7: warning: Branch condition evaluates > to a garbage value > if (!oldn->mute || >

Re: [PATCH] platform/x86: thinkpad_acpi: initialize tp_nvram_state variable

2020-09-14 Thread Hans de Goede
Hi, On 9/13/20 9:02 PM, t...@redhat.com wrote: From: Tom Rix clang static analysis flags this represenative problem thinkpad_acpi.c:2523:7: warning: Branch condition evaluates to a garbage value if (!oldn->mute || ^~~ In hotkey_kthread() mute i

[PATCH] platform/x86: thinkpad_acpi: initialize tp_nvram_state variable

2020-09-13 Thread trix
From: Tom Rix clang static analysis flags this represenative problem thinkpad_acpi.c:2523:7: warning: Branch condition evaluates to a garbage value if (!oldn->mute || ^~~ In hotkey_kthread() mute is conditionally set by hotkey_read_nvram() but uncond