Re: [PATCH] pm80xx: Don't override ts->stat on IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY

2015-08-17 Thread Johannes Thumshirn
Jack Wang writes: > 2015-08-17 15:04 GMT+02:00 Johannes Thumshirn : >> In case XXX returns with a status of IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY Apparently I've hit enter to fast. This shouldn't be XXX but psataPayload->status. I'll be sending a v2 :-(. >> ts->stat gets set to SAS_OPEN_REJECT but

Re: [PATCH] pm80xx: Don't override ts->stat on IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY

2015-08-17 Thread Jack Wang
2015-08-17 15:04 GMT+02:00 Johannes Thumshirn : > In case XXX returns with a status of IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY > ts->stat gets set to SAS_OPEN_REJECT but a missing 'break' statement causes a > fallthrough to the default handler of the switch statement overriding ts->stat > to SAS_DEV_NO_

[PATCH] pm80xx: Don't override ts->stat on IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY

2015-08-17 Thread Johannes Thumshirn
In case XXX returns with a status of IO_OPEN_CNX_ERROR_HW_RESOURCE_BUSY ts->stat gets set to SAS_OPEN_REJECT but a missing 'break' statement causes a fallthrough to the default handler of the switch statement overriding ts->stat to SAS_DEV_NO_RESPONSE. Signed-off-by: Johannes Thumshirn --- drive