RE: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Hi Andreas, > Hi Ram, thanks for submitting this, please see some feedback inlined... > > On Sun, Sep 06, 2015 at 10:53:07PM +0530, Ramakrishna Pallala wrote: > > Add new charger driver support for BQ24261 charger IC. > > > > BQ24261 charger driver relies on extcon notifications to get the > >

RE: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Hi Andreas, > Hi Ram, thanks for submitting this, please see some feedback inlined... > > On Sun, Sep 06, 2015 at 10:53:07PM +0530, Ramakrishna Pallala wrote: > > Add new charger driver support for BQ24261 charger IC. > > > > BQ24261 charger driver relies on extcon notifications to get the > >

RE: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

> Hi, > > On Fri, Sep 11, 2015 at 09:58:40AM +0900, Krzysztof Kozlowski wrote: > > On 11.09.2015 01:42, Andrew F. Davis wrote: > > > On 09/09/2015 06:47 PM, Krzysztof Kozlowski wrote: > > > +- ti,enable-user-write: boolean, if present driver will allow > > > +the > > > user space > >

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Hi, On Fri, Sep 11, 2015 at 09:58:40AM +0900, Krzysztof Kozlowski wrote: > On 11.09.2015 01:42, Andrew F. Davis wrote: > > On 09/09/2015 06:47 PM, Krzysztof Kozlowski wrote: > > +- ti,enable-user-write: boolean, if present driver will allow the > > user space > > +to control the

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Hi, On Fri, Sep 11, 2015 at 09:58:40AM +0900, Krzysztof Kozlowski wrote: > On 11.09.2015 01:42, Andrew F. Davis wrote: > > On 09/09/2015 06:47 PM, Krzysztof Kozlowski wrote: > > +- ti,enable-user-write: boolean, if present driver will allow the > > user space > > +to control the

RE: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

> Hi, > > On Fri, Sep 11, 2015 at 09:58:40AM +0900, Krzysztof Kozlowski wrote: > > On 11.09.2015 01:42, Andrew F. Davis wrote: > > > On 09/09/2015 06:47 PM, Krzysztof Kozlowski wrote: > > > +- ti,enable-user-write: boolean, if present driver will allow > > > +the > > > user space > >

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On 11.09.2015 01:42, Andrew F. Davis wrote: > On 09/09/2015 06:47 PM, Krzysztof Kozlowski wrote: > +- ti,enable-user-write: boolean, if present driver will allow the > user space > +to control the charging current and voltage through sysfs; This is not DT property. It

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On 09/09/2015 06:47 PM, Krzysztof Kozlowski wrote: +- ti,enable-user-write: boolean, if present driver will allow the user space +to control the charging current and voltage through sysfs; This is not DT property. It does not describe hardware. We needed a mechanism to enable the sysfs

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On Thu, Sep 10, 2015 at 08:49:26AM +0900, Krzysztof Kozlowski wrote: > On 10.09.2015 02:31, Andreas Dannenberg wrote: > > On Wed, Sep 09, 2015 at 01:17:11PM +0900, Krzysztof Kozlowski wrote: > >> On 09.09.2015 11:26, Andreas Dannenberg wrote: > >>> Krzysztof, good observation! In bq2425x_charger.c

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On Thu, Sep 10, 2015 at 08:49:26AM +0900, Krzysztof Kozlowski wrote: > On 10.09.2015 02:31, Andreas Dannenberg wrote: > > On Wed, Sep 09, 2015 at 01:17:11PM +0900, Krzysztof Kozlowski wrote: > >> On 09.09.2015 11:26, Andreas Dannenberg wrote: > >>> Krzysztof, good observation! In bq2425x_charger.c

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On 09/09/2015 06:47 PM, Krzysztof Kozlowski wrote: +- ti,enable-user-write: boolean, if present driver will allow the user space +to control the charging current and voltage through sysfs; This is not DT property. It does not describe hardware. We needed a mechanism to enable the sysfs

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On 11.09.2015 01:42, Andrew F. Davis wrote: > On 09/09/2015 06:47 PM, Krzysztof Kozlowski wrote: > +- ti,enable-user-write: boolean, if present driver will allow the > user space > +to control the charging current and voltage through sysfs; This is not DT property. It

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On 10.09.2015 02:31, Andreas Dannenberg wrote: > On Wed, Sep 09, 2015 at 01:17:11PM +0900, Krzysztof Kozlowski wrote: >> On 09.09.2015 11:26, Andreas Dannenberg wrote: >>> Krzysztof, good observation! In bq2425x_charger.c (formerly known as >>> bq24257_charger.c :) that I worked on the unit used

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On 10.09.2015 03:11, Pallala, Ramakrishna wrote: >>> +Optional properties: >>> +- ti,thermal-sensing: boolean, if present thermal regulation will be >>> +enabled; >> >> What is the requirement for thermal-sensing? Can it be enabled always? >> If yes, then this is not really a hardware property. >

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Hi Ramakrishna, On Sun, Sep 6, 2015 at 8:23 PM, Ramakrishna Pallala wrote: > Add new charger driver support for BQ24261 charger IC. > > BQ24261 charger driver relies on extcon notifications to get the > charger cable type and based on that it will set the charging parameters. > > Signed-off-by:

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Hi Ram, thanks for submitting this, please see some feedback inlined... On Sun, Sep 06, 2015 at 10:53:07PM +0530, Ramakrishna Pallala wrote: > Add new charger driver support for BQ24261 charger IC. > > BQ24261 charger driver relies on extcon notifications to get the > charger cable type and

RE: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Reichel; Tc, Jenny; Andreas Dannenberg > Subject: Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 > charger > > 2015-09-07 2:23 GMT+09:00 Ramakrishna Pallala > : > > > > Add new charger driver support for BQ24261 charger IC. > > > > BQ2

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On Wed, Sep 09, 2015 at 01:17:11PM +0900, Krzysztof Kozlowski wrote: > On 09.09.2015 11:26, Andreas Dannenberg wrote: > > Krzysztof, good observation! In bq2425x_charger.c (formerly known as > > bq24257_charger.c :) that I worked on the unit used was uA. At that time > > I did a quick check and

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Hi Ramakrishna, On Sun, Sep 6, 2015 at 8:23 PM, Ramakrishna Pallala wrote: > Add new charger driver support for BQ24261 charger IC. > > BQ24261 charger driver relies on extcon notifications to get the > charger cable type and based on that it will set the charging

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On 10.09.2015 02:31, Andreas Dannenberg wrote: > On Wed, Sep 09, 2015 at 01:17:11PM +0900, Krzysztof Kozlowski wrote: >> On 09.09.2015 11:26, Andreas Dannenberg wrote: >>> Krzysztof, good observation! In bq2425x_charger.c (formerly known as >>> bq24257_charger.c :) that I worked on the unit used

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Hi Ram, thanks for submitting this, please see some feedback inlined... On Sun, Sep 06, 2015 at 10:53:07PM +0530, Ramakrishna Pallala wrote: > Add new charger driver support for BQ24261 charger IC. > > BQ24261 charger driver relies on extcon notifications to get the > charger cable type and

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On 10.09.2015 03:11, Pallala, Ramakrishna wrote: >>> +Optional properties: >>> +- ti,thermal-sensing: boolean, if present thermal regulation will be >>> +enabled; >> >> What is the requirement for thermal-sensing? Can it be enabled always? >> If yes, then this is not really a hardware property. >

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On Wed, Sep 09, 2015 at 01:17:11PM +0900, Krzysztof Kozlowski wrote: > On 09.09.2015 11:26, Andreas Dannenberg wrote: > > Krzysztof, good observation! In bq2425x_charger.c (formerly known as > > bq24257_charger.c :) that I worked on the unit used was uA. At that time > > I did a quick check and

RE: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Reichel; Tc, Jenny; Andreas Dannenberg > Subject: Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 > charger > > 2015-09-07 2:23 GMT+09:00 Ramakrishna Pallala > <ramakrishna.pall...@intel.com>: > > > > Add new charger driver support for BQ24261 charger

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On 09.09.2015 11:26, Andreas Dannenberg wrote: > On Mon, Sep 07, 2015 at 12:57:56PM +0900, Krzysztof Kozlowski wrote: >> 2015-09-07 2:23 GMT+09:00 Ramakrishna Pallala >> : >>> >>> Add new charger driver support for BQ24261 charger IC. >>> >>> BQ24261 charger driver relies on extcon notifications

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On Sun, Sep 6, 2015 at 2:23 PM, Ramakrishna Pallala wrote: > + chip->psy_usb = power_supply_register(>dev, > + _charger_desc, _cfg); > + if (IS_ERR(chip->psy_usb)) { > + dev_err(>dev, > + "power supply registration

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On Mon, Sep 07, 2015 at 12:57:56PM +0900, Krzysztof Kozlowski wrote: > 2015-09-07 2:23 GMT+09:00 Ramakrishna Pallala : > > > > Add new charger driver support for BQ24261 charger IC. > > > > BQ24261 charger driver relies on extcon notifications to get the > > charger cable type and based on that it

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On Mon, Sep 07, 2015 at 12:57:56PM +0900, Krzysztof Kozlowski wrote: > 2015-09-07 2:23 GMT+09:00 Ramakrishna Pallala : > > > > Add new charger driver support for BQ24261 charger IC. > > > > BQ24261 charger driver relies on extcon notifications to get the > > charger

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On Sun, Sep 6, 2015 at 2:23 PM, Ramakrishna Pallala wrote: > + chip->psy_usb = power_supply_register(>dev, > + _charger_desc, _cfg); > + if (IS_ERR(chip->psy_usb)) { > + dev_err(>dev, > +

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On 09.09.2015 11:26, Andreas Dannenberg wrote: > On Mon, Sep 07, 2015 at 12:57:56PM +0900, Krzysztof Kozlowski wrote: >> 2015-09-07 2:23 GMT+09:00 Ramakrishna Pallala >> : >>> >>> Add new charger driver support for BQ24261 charger IC. >>> >>> BQ24261 charger driver

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-09-07 2:23 GMT+09:00 Ramakrishna Pallala : > > Add new charger driver support for BQ24261 charger IC. > > BQ24261 charger driver relies on extcon notifications to get the > charger cable type and based on that it will set the charging parameters. > > Signed-off-by: Ramakrishna Pallala >

[PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Add new charger driver support for BQ24261 charger IC. BQ24261 charger driver relies on extcon notifications to get the charger cable type and based on that it will set the charging parameters. Signed-off-by: Ramakrishna Pallala Signed-off-by: Jennt TC ---

Re: [PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

2015-09-07 2:23 GMT+09:00 Ramakrishna Pallala : > > Add new charger driver support for BQ24261 charger IC. > > BQ24261 charger driver relies on extcon notifications to get the > charger cable type and based on that it will set the charging parameters. > >

[PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Add new charger driver support for BQ24261 charger IC. BQ24261 charger driver relies on extcon notifications to get the charger cable type and based on that it will set the charging parameters. Signed-off-by: Ramakrishna Pallala Signed-off-by: Jennt TC

Re: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On Tue, Sep 01, 2015 at 06:20:54PM +, Pallala, Ramakrishna wrote: > Hi Andreas, > I will resubmit the patch by this weekend. I Hope this works for you. > > Thanks, > Ram Sounds good, thanks. -- Andreas Dannenberg Texas Instruments Inc -- To unsubscribe from this list: send the line

RE: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Hi Andreas, > On Wed, Aug 26, 2015 at 11:03:00AM +, Pallala, Ramakrishna wrote: > > Hi Andreas, > > > > I went on a unplanned leave and I came back to office recently. I will go > through your comments and get back to you. > > Hi Ram, > hope all is well. Please let me know your

RE: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Hi Andreas, > On Wed, Aug 26, 2015 at 11:03:00AM +, Pallala, Ramakrishna wrote: > > Hi Andreas, > > > > I went on a unplanned leave and I came back to office recently. I will go > through your comments and get back to you. > > Hi Ram, > hope all is well. Please let me know your

Re: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

On Tue, Sep 01, 2015 at 06:20:54PM +, Pallala, Ramakrishna wrote: > Hi Andreas, > I will resubmit the patch by this weekend. I Hope this works for you. > > Thanks, > Ram Sounds good, thanks. -- Andreas Dannenberg Texas Instruments Inc -- To unsubscribe from this list: send the line

Re: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

-- Andreas Dannenberg Texas Instruments Inc > > > > Subject: Re: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 > > charger > > > > Hi, > > > > On Tue, Aug 18, 2015 at 11:19:35PM +0530, Ramakrishna Pallala wrote: > > > Add new ch

Re: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

-- Andreas Dannenberg Texas Instruments Inc > > > > Subject: Re: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 > > charger > > > > Hi, > > > > On Tue, Aug 18, 2015 at 11:19:35PM +0530, Ramakrishna Pallala wrote: > > > Add new ch

RE: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Hi Andreas, I went on a unplanned leave and I came back to office recently. I will go through your comments and get back to you. > Subject: Re: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 > charger > > Hi, > > On Tue, Aug 18, 2015 at 11:19:35PM +0530, R

RE: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Hi Andreas, I went on a unplanned leave and I came back to office recently. I will go through your comments and get back to you. Subject: Re: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger Hi, On Tue, Aug 18, 2015 at 11:19:35PM +0530, Ramakrishna Pallala wrote

Re: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Hi, On Tue, Aug 18, 2015 at 11:19:35PM +0530, Ramakrishna Pallala wrote: > Add new charger driver support for BQ24261 charger IC. > > Signed-off-by: Ramakrishna Pallala > --- > drivers/power/Kconfig |6 + > drivers/power/Makefile|1 + >

[RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Add new charger driver support for BQ24261 charger IC. Signed-off-by: Ramakrishna Pallala --- drivers/power/Kconfig |6 + drivers/power/Makefile|1 + drivers/power/bq24261_charger.c | 1127 +

[RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Add new charger driver support for BQ24261 charger IC. Signed-off-by: Ramakrishna Pallala --- drivers/power/Kconfig |6 + drivers/power/Makefile|1 + drivers/power/bq24261_charger.c | 1127 +

[RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Add new charger driver support for BQ24261 charger IC. Signed-off-by: Ramakrishna Pallala ramakrishna.pall...@intel.com --- drivers/power/Kconfig |6 + drivers/power/Makefile|1 + drivers/power/bq24261_charger.c | 1127

[RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Add new charger driver support for BQ24261 charger IC. Signed-off-by: Ramakrishna Pallala ramakrishna.pall...@intel.com --- drivers/power/Kconfig |6 + drivers/power/Makefile|1 + drivers/power/bq24261_charger.c | 1127

Re: [RFC PATCH] power: bq24261_charger: Add support for TI BQ24261 charger

Hi, On Tue, Aug 18, 2015 at 11:19:35PM +0530, Ramakrishna Pallala wrote: Add new charger driver support for BQ24261 charger IC. Signed-off-by: Ramakrishna Pallala ramakrishna.pall...@intel.com --- drivers/power/Kconfig |6 + drivers/power/Makefile|1