Re: [PATCH] power: reset: zx-reboot: put device node in zx_reboot_probe()

2018-07-06 Thread Sebastian Reichel
Hi, On Sun, Jun 03, 2018 at 01:22:05AM +0300, Alexey Khoroshilov wrote: > zx_reboot_probe() increments refcnt of zx296702-pcu device node by > of_find_compatible_node() and leaves it undecremented on both > successful and error paths. > > Found by Linux Driver Verification project

Re: [PATCH] power: reset: zx-reboot: put device node in zx_reboot_probe()

2018-07-06 Thread Sebastian Reichel
Hi, On Sun, Jun 03, 2018 at 01:22:05AM +0300, Alexey Khoroshilov wrote: > zx_reboot_probe() increments refcnt of zx296702-pcu device node by > of_find_compatible_node() and leaves it undecremented on both > successful and error paths. > > Found by Linux Driver Verification project

Re: [SIL2review] [PATCH] power: reset: zx-reboot: put device node in zx_reboot_probe()

2018-06-03 Thread Nicholas Mc Guire
On Sun, Jun 03, 2018 at 01:22:05AM +0300, Alexey Khoroshilov wrote: > zx_reboot_probe() increments refcnt of zx296702-pcu device node by > of_find_compatible_node() and leaves it undecremented on both > successful and error paths. > Just wonder - if it warns on the failed case it probably should

Re: [SIL2review] [PATCH] power: reset: zx-reboot: put device node in zx_reboot_probe()

2018-06-03 Thread Nicholas Mc Guire
On Sun, Jun 03, 2018 at 01:22:05AM +0300, Alexey Khoroshilov wrote: > zx_reboot_probe() increments refcnt of zx296702-pcu device node by > of_find_compatible_node() and leaves it undecremented on both > successful and error paths. > Just wonder - if it warns on the failed case it probably should

[PATCH] power: reset: zx-reboot: put device node in zx_reboot_probe()

2018-06-02 Thread Alexey Khoroshilov
zx_reboot_probe() increments refcnt of zx296702-pcu device node by of_find_compatible_node() and leaves it undecremented on both successful and error paths. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/power/reset/zx-reboot.c | 1

[PATCH] power: reset: zx-reboot: put device node in zx_reboot_probe()

2018-06-02 Thread Alexey Khoroshilov
zx_reboot_probe() increments refcnt of zx296702-pcu device node by of_find_compatible_node() and leaves it undecremented on both successful and error paths. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/power/reset/zx-reboot.c | 1