Re: [PATCH] powerpc/pci: Improve device hotplug initialization

2013-06-05 Thread Benjamin Herrenschmidt
On Wed, 2013-06-05 at 22:25 -0700, Guenter Roeck wrote: > > > Can you point me to some of the breaking code ? I guess it must be in some of > the pci_dma_dev_setup callbacks, but those I looked at only check devicetree > data or simply set function pointers, both of which should not be affected

Re: [PATCH] powerpc/pci: Improve device hotplug initialization

2013-06-05 Thread Guenter Roeck
On Thu, Jun 06, 2013 at 11:00:04AM +1000, Benjamin Herrenschmidt wrote: > On Sat, 2013-06-01 at 06:58 -0700, Guenter Roeck wrote: > > the comment was actuially directed towards Yuanquan. > > > > No problem, take your time. I did my best to test it, but I agree that this > > is a > > critical

Re: [PATCH] powerpc/pci: Improve device hotplug initialization

2013-06-05 Thread Benjamin Herrenschmidt
On Sat, 2013-06-01 at 06:58 -0700, Guenter Roeck wrote: > the comment was actuially directed towards Yuanquan. > > No problem, take your time. I did my best to test it, but I agree that this > is a > critical area of the code, and it would be desirable to get additional > scrutiny > and test

Re: [PATCH] powerpc/pci: Improve device hotplug initialization

2013-06-05 Thread Benjamin Herrenschmidt
On Sat, 2013-06-01 at 06:58 -0700, Guenter Roeck wrote: the comment was actuially directed towards Yuanquan. No problem, take your time. I did my best to test it, but I agree that this is a critical area of the code, and it would be desirable to get additional scrutiny and test feedback.

Re: [PATCH] powerpc/pci: Improve device hotplug initialization

2013-06-05 Thread Guenter Roeck
On Thu, Jun 06, 2013 at 11:00:04AM +1000, Benjamin Herrenschmidt wrote: On Sat, 2013-06-01 at 06:58 -0700, Guenter Roeck wrote: the comment was actuially directed towards Yuanquan. No problem, take your time. I did my best to test it, but I agree that this is a critical area of the

Re: [PATCH] powerpc/pci: Improve device hotplug initialization

2013-06-05 Thread Benjamin Herrenschmidt
On Wed, 2013-06-05 at 22:25 -0700, Guenter Roeck wrote: Can you point me to some of the breaking code ? I guess it must be in some of the pci_dma_dev_setup callbacks, but those I looked at only check devicetree data or simply set function pointers, both of which should not be affected by

Re: [PATCH] powerpc/pci: Improve device hotplug initialization

2013-06-02 Thread Guenter Roeck
On Mon, Jun 03, 2013 at 10:28:47AM +0800, Chen Yuanquan-B41889 wrote: > On 06/01/2013 09:58 PM, Guenter Roeck wrote: > >On Fri, May 31, 2013 at 03:44:07PM +1000, Benjamin Herrenschmidt wrote: > >>On Thu, 2013-05-30 at 22:14 -0700, Guenter Roeck wrote: > >>>On Wed, May 29, 2013 at 05:30:41PM +0800,

Re: [PATCH] powerpc/pci: Improve device hotplug initialization

2013-06-02 Thread Chen Yuanquan-B41889
On 06/01/2013 09:58 PM, Guenter Roeck wrote: On Fri, May 31, 2013 at 03:44:07PM +1000, Benjamin Herrenschmidt wrote: On Thu, 2013-05-30 at 22:14 -0700, Guenter Roeck wrote: On Wed, May 29, 2013 at 05:30:41PM +0800, Chen Yuanquan-B41889 wrote: On 05/29/2013 01:35 AM, Guenter Roeck wrote:

Re: [PATCH] powerpc/pci: Improve device hotplug initialization

2013-06-02 Thread Chen Yuanquan-B41889
On 06/01/2013 09:58 PM, Guenter Roeck wrote: On Fri, May 31, 2013 at 03:44:07PM +1000, Benjamin Herrenschmidt wrote: On Thu, 2013-05-30 at 22:14 -0700, Guenter Roeck wrote: On Wed, May 29, 2013 at 05:30:41PM +0800, Chen Yuanquan-B41889 wrote: On 05/29/2013 01:35 AM, Guenter Roeck wrote:

Re: [PATCH] powerpc/pci: Improve device hotplug initialization

2013-06-02 Thread Guenter Roeck
On Mon, Jun 03, 2013 at 10:28:47AM +0800, Chen Yuanquan-B41889 wrote: On 06/01/2013 09:58 PM, Guenter Roeck wrote: On Fri, May 31, 2013 at 03:44:07PM +1000, Benjamin Herrenschmidt wrote: On Thu, 2013-05-30 at 22:14 -0700, Guenter Roeck wrote: On Wed, May 29, 2013 at 05:30:41PM +0800, Chen

Re: [PATCH] powerpc/pci: Improve device hotplug initialization

2013-06-01 Thread Guenter Roeck
On Fri, May 31, 2013 at 03:44:07PM +1000, Benjamin Herrenschmidt wrote: > On Thu, 2013-05-30 at 22:14 -0700, Guenter Roeck wrote: > > On Wed, May 29, 2013 at 05:30:41PM +0800, Chen Yuanquan-B41889 wrote: > > > On 05/29/2013 01:35 AM, Guenter Roeck wrote: > > > >bios_add_device(). Drop explicit

Re: [PATCH] powerpc/pci: Improve device hotplug initialization

2013-06-01 Thread Guenter Roeck
On Fri, May 31, 2013 at 03:44:07PM +1000, Benjamin Herrenschmidt wrote: On Thu, 2013-05-30 at 22:14 -0700, Guenter Roeck wrote: On Wed, May 29, 2013 at 05:30:41PM +0800, Chen Yuanquan-B41889 wrote: On 05/29/2013 01:35 AM, Guenter Roeck wrote: bios_add_device(). Drop explicit calls to

Re: [PATCH] powerpc/pci: Improve device hotplug initialization

2013-05-30 Thread Benjamin Herrenschmidt
On Thu, 2013-05-30 at 22:14 -0700, Guenter Roeck wrote: > On Wed, May 29, 2013 at 05:30:41PM +0800, Chen Yuanquan-B41889 wrote: > > On 05/29/2013 01:35 AM, Guenter Roeck wrote: > > >bios_add_device(). Drop explicit calls to pcibios_setup_device(); > > >this makes pcibios_setup_bus_devices() a noop

Re: [PATCH] powerpc/pci: Improve device hotplug initialization

2013-05-30 Thread Guenter Roeck
On Wed, May 29, 2013 at 05:30:41PM +0800, Chen Yuanquan-B41889 wrote: > On 05/29/2013 01:35 AM, Guenter Roeck wrote: > >bios_add_device(). Drop explicit calls to pcibios_setup_device(); > >this makes pcibios_setup_bus_devices() a noop function which could > >eve > > Yeah, it's more reasonable to

Re: [PATCH] powerpc/pci: Improve device hotplug initialization

2013-05-30 Thread Guenter Roeck
On Wed, May 29, 2013 at 05:30:41PM +0800, Chen Yuanquan-B41889 wrote: On 05/29/2013 01:35 AM, Guenter Roeck wrote: bios_add_device(). Drop explicit calls to pcibios_setup_device(); this makes pcibios_setup_bus_devices() a noop function which could eve Yeah, it's more reasonable to do the

Re: [PATCH] powerpc/pci: Improve device hotplug initialization

2013-05-30 Thread Benjamin Herrenschmidt
On Thu, 2013-05-30 at 22:14 -0700, Guenter Roeck wrote: On Wed, May 29, 2013 at 05:30:41PM +0800, Chen Yuanquan-B41889 wrote: On 05/29/2013 01:35 AM, Guenter Roeck wrote: bios_add_device(). Drop explicit calls to pcibios_setup_device(); this makes pcibios_setup_bus_devices() a noop function

Re: [PATCH] powerpc/pci: Improve device hotplug initialization

2013-05-29 Thread Chen Yuanquan-B41889
On 05/29/2013 01:35 AM, Guenter Roeck wrote: bios_add_device(). Drop explicit calls to pcibios_setup_device(); this makes pcibios_setup_bus_devices() a noop function which could eve Yeah, it's more reasonable to do the irq and DMA related initialization in one code path for all devices.

Re: [PATCH] powerpc/pci: Improve device hotplug initialization

2013-05-29 Thread Chen Yuanquan-B41889
On 05/29/2013 01:35 AM, Guenter Roeck wrote: bios_add_device(). Drop explicit calls to pcibios_setup_device(); this makes pcibios_setup_bus_devices() a noop function which could eve Yeah, it's more reasonable to do the irq and DMA related initialization in one code path for all devices.

[PATCH] powerpc/pci: Improve device hotplug initialization

2013-05-28 Thread Guenter Roeck
Commit 37f02195b (powerpc/pci: fix PCI-e devices rescan issue on powerpc platform) fixes a problem with interrupt and DMA initialization on hot plugged devices. With this commit, interrupt and DMA initialization for hot plugged devices is handled in the pci device enable function. This approach

[PATCH] powerpc/pci: Improve device hotplug initialization

2013-05-28 Thread Guenter Roeck
Commit 37f02195b (powerpc/pci: fix PCI-e devices rescan issue on powerpc platform) fixes a problem with interrupt and DMA initialization on hot plugged devices. With this commit, interrupt and DMA initialization for hot plugged devices is handled in the pci device enable function. This approach