Re: [PATCH] powerpc/pseries: Drop unnecessary continue

2014-08-24 Thread Michael Ellerman
On Thu, 2014-08-21 at 10:51 -0500, Robert Jennings wrote: > On 08/20/2014 11:41 PM, Michael Ellerman wrote: > > On Wed, 2014-08-13 at 14:48 +0530, Himangi Saraogi wrote: > >> Continue is not needed at the bottom of a loop. > > > > True. > > > > I wonder though, is the code trying to continue to

Re: [PATCH] powerpc/pseries: Drop unnecessary continue

2014-08-24 Thread Michael Ellerman
On Thu, 2014-08-21 at 10:51 -0500, Robert Jennings wrote: On 08/20/2014 11:41 PM, Michael Ellerman wrote: On Wed, 2014-08-13 at 14:48 +0530, Himangi Saraogi wrote: Continue is not needed at the bottom of a loop. True. I wonder though, is the code trying to continue to the outer

Re: [PATCH] powerpc/pseries: Drop unnecessary continue

2014-08-21 Thread Robert Jennings
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 08/20/2014 11:41 PM, Michael Ellerman wrote: > On Wed, 2014-08-13 at 14:48 +0530, Himangi Saraogi wrote: >> Continue is not needed at the bottom of a loop. > > True. > > I wonder though, is the code trying to continue to the outer loop? > I

Re: [PATCH] powerpc/pseries: Drop unnecessary continue

2014-08-21 Thread Robert Jennings
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 08/20/2014 11:41 PM, Michael Ellerman wrote: On Wed, 2014-08-13 at 14:48 +0530, Himangi Saraogi wrote: Continue is not needed at the bottom of a loop. True. I wonder though, is the code trying to continue to the outer loop? I stared at

Re: [PATCH] powerpc/pseries: Drop unnecessary continue

2014-08-20 Thread Michael Ellerman
On Wed, 2014-08-13 at 14:48 +0530, Himangi Saraogi wrote: > Continue is not needed at the bottom of a loop. True. I wonder though, is the code trying to continue to the outer loop? I stared at it for a minute but it wasn't obvious. I wonder if Robert still remembers? cheers > diff --git

Re: [PATCH] powerpc/pseries: Drop unnecessary continue

2014-08-20 Thread Michael Ellerman
On Wed, 2014-08-13 at 14:48 +0530, Himangi Saraogi wrote: Continue is not needed at the bottom of a loop. True. I wonder though, is the code trying to continue to the outer loop? I stared at it for a minute but it wasn't obvious. I wonder if Robert still remembers? cheers diff --git

[PATCH] powerpc/pseries: Drop unnecessary continue

2014-08-13 Thread Himangi Saraogi
Continue is not needed at the bottom of a loop. The Coccinelle semantic patch implementing this change is: @@ @@ for (...;...;...) { ... if (...) { ... - continue; } } Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall --- Not compile tested.

[PATCH] powerpc/pseries: Drop unnecessary continue

2014-08-13 Thread Himangi Saraogi
Continue is not needed at the bottom of a loop. The Coccinelle semantic patch implementing this change is: @@ @@ for (...;...;...) { ... if (...) { ... - continue; } } Signed-off-by: Himangi Saraogi himangi...@gmail.com Acked-by: Julia Lawall julia.law...@lip6.fr --- Not compile