Re: [PATCH] powerpc/traps: fix recoverability of machine check handling on book3s/32

2020-09-14 Thread Michal Suchánek
On Fri, Sep 11, 2020 at 11:23:57PM +1000, Michael Ellerman wrote: > Michal Suchánek writes: > > Hello, > > > > does this logic apply to "Unrecoverable System Reset" as well? > > Which logic do you mean? > > We do call die() before checking MSR_RI in system_reset_exception(): > > /* >

Re: [PATCH] powerpc/traps: fix recoverability of machine check handling on book3s/32

2020-09-11 Thread Michael Ellerman
Michal Suchánek writes: > Hello, > > does this logic apply to "Unrecoverable System Reset" as well? Which logic do you mean? We do call die() before checking MSR_RI in system_reset_exception(): /* * No debugger or crash dump registered, print logs then * panic.

Re: [PATCH] powerpc/traps: fix recoverability of machine check handling on book3s/32

2020-09-11 Thread Christophe Leroy
Hello, Le 11/09/2020 à 11:15, Michal Suchánek a écrit : Hello, does this logic apply to "Unrecoverable System Reset" as well? I don't know, I don't think I have any way the generate a System Reset on my board to check it. Christophe Thanks Michal On Tue, Jan 22, 2019 at 02:11:24PM

Re: [PATCH] powerpc/traps: fix recoverability of machine check handling on book3s/32

2020-09-11 Thread Michal Suchánek
Hello, does this logic apply to "Unrecoverable System Reset" as well? Thanks Michal On Tue, Jan 22, 2019 at 02:11:24PM +, Christophe Leroy wrote: > Looks like book3s/32 doesn't set RI on machine check, so > checking RI before calling die() will always be fatal > allthought this is not an

Re: [PATCH] powerpc/traps: fix recoverability of machine check handling on book3s/32

2019-01-23 Thread Nicholas Piggin
Christophe Leroy's on January 23, 2019 12:11 am: > Looks like book3s/32 doesn't set RI on machine check, so > checking RI before calling die() will always be fatal > allthought this is not an issue in most cases. Oh good catch, this is a fix for powerpc/64 as well. I think actually the panic was

[PATCH] powerpc/traps: fix recoverability of machine check handling on book3s/32

2019-01-22 Thread Christophe Leroy
Looks like book3s/32 doesn't set RI on machine check, so checking RI before calling die() will always be fatal allthought this is not an issue in most cases. Fixes: b96672dd840f ("powerpc: Machine check interrupt is a non-maskable interrupt") Fixes: daf00ae71dad ("powerpc/traps: restore