Re: [PATCH] proc: check vma->vm_file before dereferencing

2012-10-16 Thread Stanislav Kinsbursky
16.10.2012 01:40, Andrew Morton пишет: On Mon, 15 Oct 2012 19:30:03 +0400 Stanislav Kinsbursky wrote: It can be equal to NULL. Please write better changelogs, so people do not have to ask questions such as: - Under what conditions does this bug trigger? - In which kernel version(s)? -

Re: [PATCH] proc: check vma-vm_file before dereferencing

2012-10-16 Thread Stanislav Kinsbursky
16.10.2012 01:40, Andrew Morton пишет: On Mon, 15 Oct 2012 19:30:03 +0400 Stanislav Kinsbursky skinsbur...@parallels.com wrote: It can be equal to NULL. Please write better changelogs, so people do not have to ask questions such as: - Under what conditions does this bug trigger? - In

Re: [PATCH] proc: check vma->vm_file before dereferencing

2012-10-15 Thread Andrew Morton
On Tue, 16 Oct 2012 01:52:30 +0400 Cyrill Gorcunov wrote: > On Mon, Oct 15, 2012 at 02:40:48PM -0700, Andrew Morton wrote: > > On Mon, 15 Oct 2012 19:30:03 +0400 > > Stanislav Kinsbursky wrote: > > > > > It can be equal to NULL. > > > > > > > Please write better changelogs, so people do not

Re: [PATCH] proc: check vma->vm_file before dereferencing

2012-10-15 Thread Cyrill Gorcunov
On Mon, Oct 15, 2012 at 02:40:48PM -0700, Andrew Morton wrote: > On Mon, 15 Oct 2012 19:30:03 +0400 > Stanislav Kinsbursky wrote: > > > It can be equal to NULL. > > > > Please write better changelogs, so people do not have to ask questions > such as: > > - Under what conditions does this bug

Re: [PATCH] proc: check vma->vm_file before dereferencing

2012-10-15 Thread Andrew Morton
On Mon, 15 Oct 2012 19:30:03 +0400 Stanislav Kinsbursky wrote: > It can be equal to NULL. > Please write better changelogs, so people do not have to ask questions such as: - Under what conditions does this bug trigger? - In which kernel version(s)? - Is it a post-3.6 regression? Thanks.

Re: [PATCH] proc: check vma->vm_file before dereferencing

2012-10-15 Thread Cyrill Gorcunov
On Mon, Oct 15, 2012 at 07:30:03PM +0400, Stanislav Kinsbursky wrote: > It can be equal to NULL. > > Signed-off-by: Stanislav Kinsbursky Acked-by: Cyrill Gorcunov Thanks, Stas! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

[PATCH] proc: check vma->vm_file before dereferencing

2012-10-15 Thread Stanislav Kinsbursky
It can be equal to NULL. Signed-off-by: Stanislav Kinsbursky --- fs/proc/base.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/proc/base.c b/fs/proc/base.c index 144a967..74fc562 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -1770,8 +1770,9 @@ static

[PATCH] proc: check vma-vm_file before dereferencing

2012-10-15 Thread Stanislav Kinsbursky
It can be equal to NULL. Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com --- fs/proc/base.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/proc/base.c b/fs/proc/base.c index 144a967..74fc562 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@

Re: [PATCH] proc: check vma-vm_file before dereferencing

2012-10-15 Thread Cyrill Gorcunov
On Mon, Oct 15, 2012 at 07:30:03PM +0400, Stanislav Kinsbursky wrote: It can be equal to NULL. Signed-off-by: Stanislav Kinsbursky skinsbur...@parallels.com Acked-by: Cyrill Gorcunov gorcu...@openvz.org Thanks, Stas! -- To unsubscribe from this list: send the line unsubscribe linux-kernel in

Re: [PATCH] proc: check vma-vm_file before dereferencing

2012-10-15 Thread Andrew Morton
On Mon, 15 Oct 2012 19:30:03 +0400 Stanislav Kinsbursky skinsbur...@parallels.com wrote: It can be equal to NULL. Please write better changelogs, so people do not have to ask questions such as: - Under what conditions does this bug trigger? - In which kernel version(s)? - Is it a post-3.6

Re: [PATCH] proc: check vma-vm_file before dereferencing

2012-10-15 Thread Cyrill Gorcunov
On Mon, Oct 15, 2012 at 02:40:48PM -0700, Andrew Morton wrote: On Mon, 15 Oct 2012 19:30:03 +0400 Stanislav Kinsbursky skinsbur...@parallels.com wrote: It can be equal to NULL. Please write better changelogs, so people do not have to ask questions such as: - Under what conditions

Re: [PATCH] proc: check vma-vm_file before dereferencing

2012-10-15 Thread Andrew Morton
On Tue, 16 Oct 2012 01:52:30 +0400 Cyrill Gorcunov gorcu...@openvz.org wrote: On Mon, Oct 15, 2012 at 02:40:48PM -0700, Andrew Morton wrote: On Mon, 15 Oct 2012 19:30:03 +0400 Stanislav Kinsbursky skinsbur...@parallels.com wrote: It can be equal to NULL. Please write better