Re: [PATCH] proc: return on proc_readdir error

2013-08-23 Thread Geert Uytterhoeven
On Mon, Aug 19, 2013 at 6:30 PM, Richard Genoud wrote: > This is not triggered on glibc (as getdents is called with a 32KB > buffer), but on uclibc, the buffer size is only 1KB, thus some proc > entries are missing. JFYI, on glibc 2.3.6.ds1-13 it's also 1 KiB. Gr{oetje,eeting}s,

Re: [PATCH] proc: return on proc_readdir error

2013-08-23 Thread Geert Uytterhoeven
On Mon, Aug 19, 2013 at 6:30 PM, Richard Genoud richard.gen...@gmail.com wrote: This is not triggered on glibc (as getdents is called with a 32KB buffer), but on uclibc, the buffer size is only 1KB, thus some proc entries are missing. JFYI, on glibc 2.3.6.ds1-13 it's also 1 KiB.

Re: [PATCH] proc: return on proc_readdir error

2013-08-20 Thread Richard Genoud
2013/8/20 Marc Dionne : > On Mon, Aug 19, 2013 at 7:49 PM, Linus Torvalds > wrote: >> On Mon, Aug 19, 2013 at 1:33 PM, Marc Dionne wrote: >>> >>> By my reading that commit (f0c3b5093add) also made proc_readdir always >>> return 0, so with this patch the effect I see is that no pid entries >>>

Re: [PATCH] proc: return on proc_readdir error

2013-08-20 Thread Richard Genoud
2013/8/20 Marc Dionne marc.c.dio...@gmail.com: On Mon, Aug 19, 2013 at 7:49 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Mon, Aug 19, 2013 at 1:33 PM, Marc Dionne marc.c.dio...@gmail.com wrote: By my reading that commit (f0c3b5093add) also made proc_readdir always return 0, so

Re: [PATCH] proc: return on proc_readdir error

2013-08-19 Thread Marc Dionne
On Mon, Aug 19, 2013 at 7:49 PM, Linus Torvalds wrote: > On Mon, Aug 19, 2013 at 1:33 PM, Marc Dionne wrote: >> >> By my reading that commit (f0c3b5093add) also made proc_readdir always >> return 0, so with this patch the effect I see is that no pid entries >> are listed under /proc, breaking ps

Re: [PATCH] proc: return on proc_readdir error

2013-08-19 Thread Linus Torvalds
On Mon, Aug 19, 2013 at 1:33 PM, Marc Dionne wrote: > > By my reading that commit (f0c3b5093add) also made proc_readdir always > return 0, so with this patch the effect I see is that no pid entries > are listed under /proc, breaking ps for instance. I don't see how > even the previous version of

Re: [PATCH] proc: return on proc_readdir error

2013-08-19 Thread Marc Dionne
On Mon, Aug 19, 2013 at 12:30 PM, Richard Genoud wrote: > > commit f0c3b5093addc8bfe9fe3a5b01acb7ec7969eafa > "[readdir] convert procfs" introduced a bug on the listing of the proc > file-system. > The return value of proc_readdir() isn't tested anymore in the > proc_root_readdir function. > >

Re: [PATCH] proc: return on proc_readdir error

2013-08-19 Thread Linus Torvalds
Thanks, applied. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH] proc: return on proc_readdir error

2013-08-19 Thread Richard Genoud
commit f0c3b5093addc8bfe9fe3a5b01acb7ec7969eafa "[readdir] convert procfs" introduced a bug on the listing of the proc file-system. The return value of proc_readdir() isn't tested anymore in the proc_root_readdir function. This lead to an "interesting" behaviour when we are using the getdents()

[PATCH] proc: return on proc_readdir error

2013-08-19 Thread Richard Genoud
commit f0c3b5093addc8bfe9fe3a5b01acb7ec7969eafa [readdir] convert procfs introduced a bug on the listing of the proc file-system. The return value of proc_readdir() isn't tested anymore in the proc_root_readdir function. This lead to an interesting behaviour when we are using the getdents()

Re: [PATCH] proc: return on proc_readdir error

2013-08-19 Thread Linus Torvalds
Thanks, applied. Linus -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] proc: return on proc_readdir error

2013-08-19 Thread Marc Dionne
On Mon, Aug 19, 2013 at 12:30 PM, Richard Genoud richard.gen...@gmail.com wrote: commit f0c3b5093addc8bfe9fe3a5b01acb7ec7969eafa [readdir] convert procfs introduced a bug on the listing of the proc file-system. The return value of proc_readdir() isn't tested anymore in the proc_root_readdir

Re: [PATCH] proc: return on proc_readdir error

2013-08-19 Thread Linus Torvalds
On Mon, Aug 19, 2013 at 1:33 PM, Marc Dionne marc.c.dio...@gmail.com wrote: By my reading that commit (f0c3b5093add) also made proc_readdir always return 0, so with this patch the effect I see is that no pid entries are listed under /proc, breaking ps for instance. I don't see how even the

Re: [PATCH] proc: return on proc_readdir error

2013-08-19 Thread Marc Dionne
On Mon, Aug 19, 2013 at 7:49 PM, Linus Torvalds torva...@linux-foundation.org wrote: On Mon, Aug 19, 2013 at 1:33 PM, Marc Dionne marc.c.dio...@gmail.com wrote: By my reading that commit (f0c3b5093add) also made proc_readdir always return 0, so with this patch the effect I see is that no pid