Re: [PATCH] proc: task_mmu: show page size in /proc//numa_maps

2014-12-22 Thread David Rientjes
On Sat, 20 Dec 2014, Dave Hansen wrote: > I sometimes wonder what 'numa_maps' purpose is any if we should have > _some_ kind of policy about what goes in there vs. smaps. numa_maps > seems to be turning in to smaps, minus the \n. :) > It seems like an interface, similar to the one proposed by U

Re: [PATCH] proc: task_mmu: show page size in /proc//numa_maps

2014-12-22 Thread David Rientjes
On Mon, 22 Dec 2014, Dave Hansen wrote: > > Remaining question here is: should we print out 'pagesize' deliberately > > or conditionally, only to disambiguate cases where page_size != PAGE_SIZE? > > I say print it unconditionally. Not to completely overdesign this, but > I do think we should tr

Re: [PATCH] proc: task_mmu: show page size in /proc//numa_maps

2014-12-22 Thread Dave Hansen
On 12/22/2014 09:25 AM, Rafael Aquini wrote: > Remaining question here is: should we print out 'pagesize' deliberately > or conditionally, only to disambiguate cases where page_size != PAGE_SIZE? I say print it unconditionally. Not to completely overdesign this, but I do think we should try to a

Re: [PATCH] proc: task_mmu: show page size in /proc//numa_maps

2014-12-22 Thread Rafael Aquini
On Mon, Dec 22, 2014 at 09:10:34AM -0800, Dave Hansen wrote: > On 12/21/2014 02:28 PM, Rafael Aquini wrote: > >>> > > I'm fine either way, it makes the change even simpler. Also, if we > >>> > > decide to get rid of page_size != PAGE_SIZE condition I believe we > >>> > > can > >>> > > also get ri

Re: [PATCH] proc: task_mmu: show page size in /proc//numa_maps

2014-12-22 Thread Dave Hansen
On 12/21/2014 02:28 PM, Rafael Aquini wrote: >>> > > I'm fine either way, it makes the change even simpler. Also, if we >>> > > decide to get rid of page_size != PAGE_SIZE condition I believe we can >>> > > also get rid of that "huge" hint being conditionally printed out too. >> > >> > That would

Re: [PATCH] proc: task_mmu: show page size in /proc//numa_maps

2014-12-21 Thread Rafael Aquini
On Sun, Dec 21, 2014 at 10:02:49AM -0800, Dave Hansen wrote: > On 12/20/2014 11:44 AM, Rafael Aquini wrote: > >> > > >> > It would be simpler to include this unconditionally. Otherwise you > >> > are forcing everybody parsing the file and trying to run calculations > >> > of it to check for its p

Re: [PATCH] proc: task_mmu: show page size in /proc//numa_maps

2014-12-21 Thread Dave Hansen
On 12/20/2014 11:44 AM, Rafael Aquini wrote: >> > >> > It would be simpler to include this unconditionally. Otherwise you >> > are forcing everybody parsing the file and trying to run calculations >> > of it to check for its presence, and then have them fall back and get >> > the value from somew

Re: [PATCH] proc: task_mmu: show page size in /proc//numa_maps

2014-12-20 Thread Rafael Aquini
On Sat, Dec 20, 2014 at 01:36:13PM -0500, Johannes Weiner wrote: > On Sat, Dec 20, 2014 at 08:54:45AM -0500, Rafael Aquini wrote: > > This patch introduces 'pagesize' line element to /proc//numa_maps > > report file in order to help disambiguating the size of pages that are > > backing memory areas

Re: [PATCH] proc: task_mmu: show page size in /proc//numa_maps

2014-12-20 Thread Johannes Weiner
On Sat, Dec 20, 2014 at 08:54:45AM -0500, Rafael Aquini wrote: > This patch introduces 'pagesize' line element to /proc//numa_maps > report file in order to help disambiguating the size of pages that are > backing memory areas mapped by a task. When the VMA backing page size > is observed different

Re: [PATCH] proc: task_mmu: show page size in /proc//numa_maps

2014-12-20 Thread Dave Hansen
On 12/20/2014 05:54 AM, Rafael Aquini wrote: > This patch introduces 'pagesize' line element to /proc//numa_maps > report file in order to help disambiguating the size of pages that are > backing memory areas mapped by a task. When the VMA backing page size > is observed different from kernel's def

[PATCH] proc: task_mmu: show page size in /proc//numa_maps

2014-12-20 Thread Rafael Aquini
This patch introduces 'pagesize' line element to /proc//numa_maps report file in order to help disambiguating the size of pages that are backing memory areas mapped by a task. When the VMA backing page size is observed different from kernel's default PAGE_SIZE, the new element is printed out to co