Re: [PATCH] pstore: Use memcpy_toio instead of memcpy

2014-11-13 Thread Kees Cook
On Thu, Nov 13, 2014 at 10:09 AM, Furquan Shaikh wrote: > persistent_ram_update uses vmap / iomap based on whether the buffer is in > memory > region or reserved region. However, both map it as non-cacheable memory. For > armv8 specifically, non-cacheable mapping requests use a memory type that

[PATCH] pstore: Use memcpy_toio instead of memcpy

2014-11-13 Thread Furquan Shaikh
persistent_ram_update uses vmap / iomap based on whether the buffer is in memory region or reserved region. However, both map it as non-cacheable memory. For armv8 specifically, non-cacheable mapping requests use a memory type that has to be accessed aligned to the request size. memcpy() doesn't

[PATCH] pstore: Use memcpy_toio instead of memcpy

2014-11-13 Thread Furquan Shaikh
persistent_ram_update uses vmap / iomap based on whether the buffer is in memory region or reserved region. However, both map it as non-cacheable memory. For armv8 specifically, non-cacheable mapping requests use a memory type that has to be accessed aligned to the request size. memcpy() doesn't

Re: [PATCH] pstore: Use memcpy_toio instead of memcpy

2014-11-13 Thread Kees Cook
On Thu, Nov 13, 2014 at 10:09 AM, Furquan Shaikh furq...@google.com wrote: persistent_ram_update uses vmap / iomap based on whether the buffer is in memory region or reserved region. However, both map it as non-cacheable memory. For armv8 specifically, non-cacheable mapping requests use a