Re: [PATCH] r_du_lvdsenc.c : Check return value of devm_ioremap_resource with IS_ERR

2013-12-09 Thread Ethan Zhao
Laurent, Next time I scan the NULL check, if hit your driver again, I will resend it. Thanks, Ethan On Tue, Dec 10, 2013 at 10:24 AM, Laurent Pinchart wrote: > Hi Ethan, > > Thank you for the patch. > > On Sunday 08 December 2013 10:41:46 ethan.zhao wrote: >> function

Re: [PATCH] r_du_lvdsenc.c : Check return value of devm_ioremap_resource with IS_ERR

2013-12-09 Thread Laurent Pinchart
Hi Ethan, Thank you for the patch. On Sunday 08 December 2013 10:41:46 ethan.zhao wrote: > function devm_ioremap_resource() doesn't return NULL, should check its > return value with helper IS_ERR(). > > Signed-off-by: ethan.zhao This issue has already been addressed by a patch sent to the

Re: [PATCH] r_du_lvdsenc.c : Check return value of devm_ioremap_resource with IS_ERR

2013-12-09 Thread Laurent Pinchart
Hi Ethan, Thank you for the patch. On Sunday 08 December 2013 10:41:46 ethan.zhao wrote: function devm_ioremap_resource() doesn't return NULL, should check its return value with helper IS_ERR(). Signed-off-by: ethan.zhao ethan.ker...@gmail.com This issue has already been addressed by a

Re: [PATCH] r_du_lvdsenc.c : Check return value of devm_ioremap_resource with IS_ERR

2013-12-09 Thread Ethan Zhao
Laurent, Next time I scan the NULL check, if hit your driver again, I will resend it. Thanks, Ethan On Tue, Dec 10, 2013 at 10:24 AM, Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: Hi Ethan, Thank you for the patch. On Sunday 08 December 2013 10:41:46 ethan.zhao wrote:

[PATCH] r_du_lvdsenc.c : Check return value of devm_ioremap_resource with IS_ERR

2013-12-07 Thread ethan.zhao
function devm_ioremap_resource() doesn't return NULL, should check its return value with helper IS_ERR(). Signed-off-by: ethan.zhao --- drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c

[PATCH] r_du_lvdsenc.c : Check return value of devm_ioremap_resource with IS_ERR

2013-12-07 Thread ethan.zhao
function devm_ioremap_resource() doesn't return NULL, should check its return value with helper IS_ERR(). Signed-off-by: ethan.zhao ethan.ker...@gmail.com --- drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git