Re: [PATCH] random: avoid arch_get_random_seed_long() when collecting IRQ randomness

2021-01-21 Thread Will Deacon
On Thu, 5 Nov 2020 16:29:44 +0100, Ard Biesheuvel wrote: > When reseeding the CRNG periodically, arch_get_random_seed_long() is > called to obtain entropy from an architecture specific source if one > is implemented. In most cases, these are special instructions, but in > some cases, such as on ARM

Re: [PATCH] random: avoid arch_get_random_seed_long() when collecting IRQ randomness

2021-01-15 Thread Jason A. Donenfeld
In case it helps, Reviewed-by: Jason A. Donenfeld [resending, as my mail server got blocked from vger for a week and my message bounced]

Re: [PATCH] random: avoid arch_get_random_seed_long() when collecting IRQ randomness

2021-01-10 Thread Ard Biesheuvel
On Mon, 4 Jan 2021 at 20:09, Ard Biesheuvel wrote: > > On Tue, 17 Nov 2020 at 14:33, Ard Biesheuvel wrote: > > > > On Wed, 11 Nov 2020 at 09:19, Ard Biesheuvel wrote: > > > > > > (+ Eric) > > > > > > On Thu, 5 Nov 2020 at 16:29, Ard Biesheuvel wrote: > > > > > > > > When reseeding the CRNG peri

Re: [PATCH] random: avoid arch_get_random_seed_long() when collecting IRQ randomness

2021-01-04 Thread Ard Biesheuvel
On Tue, 17 Nov 2020 at 14:33, Ard Biesheuvel wrote: > > On Wed, 11 Nov 2020 at 09:19, Ard Biesheuvel wrote: > > > > (+ Eric) > > > > On Thu, 5 Nov 2020 at 16:29, Ard Biesheuvel wrote: > > > > > > When reseeding the CRNG periodically, arch_get_random_seed_long() is > > > called to obtain entropy

Re: [PATCH] random: avoid arch_get_random_seed_long() when collecting IRQ randomness

2020-12-07 Thread Ard Biesheuvel
On Mon, 7 Dec 2020 at 15:28, Jason A. Donenfeld wrote: > > Hi Ard, > > On Tue, Dec 1, 2020 at 1:24 PM Ard Biesheuvel wrote: > > > > > is implemented. In most cases, these are special instructions, but in > > > > > some cases, such as on ARM, we may want to back this using firmware > > > > > calls

Re: [PATCH] random: avoid arch_get_random_seed_long() when collecting IRQ randomness

2020-12-07 Thread Jason A. Donenfeld
Hi Ard, On Tue, Dec 1, 2020 at 1:24 PM Ard Biesheuvel wrote: > > > > is implemented. In most cases, these are special instructions, but in > > > > some cases, such as on ARM, we may want to back this using firmware > > > > calls, which are considerably more expensive. This seems fine. But I supp

Re: [PATCH] random: avoid arch_get_random_seed_long() when collecting IRQ randomness

2020-12-07 Thread Ard Biesheuvel
On Tue, 1 Dec 2020 at 13:23, Ard Biesheuvel wrote: > > (+ Jason) > > On Fri, 20 Nov 2020 at 05:11, Eric Biggers wrote: > > > > On Wed, Nov 11, 2020 at 09:19:37AM +0100, Ard Biesheuvel wrote: > > > (+ Eric) > > > > > > On Thu, 5 Nov 2020 at 16:29, Ard Biesheuvel wrote: > > > > > > > > When reseed

Re: [PATCH] random: avoid arch_get_random_seed_long() when collecting IRQ randomness

2020-12-01 Thread Ard Biesheuvel
(+ Jason) On Fri, 20 Nov 2020 at 05:11, Eric Biggers wrote: > > On Wed, Nov 11, 2020 at 09:19:37AM +0100, Ard Biesheuvel wrote: > > (+ Eric) > > > > On Thu, 5 Nov 2020 at 16:29, Ard Biesheuvel wrote: > > > > > > When reseeding the CRNG periodically, arch_get_random_seed_long() is > > > called to

Re: [PATCH] random: avoid arch_get_random_seed_long() when collecting IRQ randomness

2020-11-27 Thread Ard Biesheuvel
On Fri, 20 Nov 2020 at 16:27, Marc Zyngier wrote: > > On 2020-11-05 15:29, Ard Biesheuvel wrote: > > When reseeding the CRNG periodically, arch_get_random_seed_long() is > > called to obtain entropy from an architecture specific source if one > > is implemented. In most cases, these are special in

Re: [PATCH] random: avoid arch_get_random_seed_long() when collecting IRQ randomness

2020-11-20 Thread Marc Zyngier
On 2020-11-05 15:29, Ard Biesheuvel wrote: When reseeding the CRNG periodically, arch_get_random_seed_long() is called to obtain entropy from an architecture specific source if one is implemented. In most cases, these are special instructions, but in some cases, such as on ARM, we may want to bac

Re: [PATCH] random: avoid arch_get_random_seed_long() when collecting IRQ randomness

2020-11-19 Thread Eric Biggers
On Wed, Nov 11, 2020 at 09:19:37AM +0100, Ard Biesheuvel wrote: > (+ Eric) > > On Thu, 5 Nov 2020 at 16:29, Ard Biesheuvel wrote: > > > > When reseeding the CRNG periodically, arch_get_random_seed_long() is > > called to obtain entropy from an architecture specific source if one > > is implemente

Re: [PATCH] random: avoid arch_get_random_seed_long() when collecting IRQ randomness

2020-11-17 Thread Ard Biesheuvel
On Wed, 11 Nov 2020 at 09:19, Ard Biesheuvel wrote: > > (+ Eric) > > On Thu, 5 Nov 2020 at 16:29, Ard Biesheuvel wrote: > > > > When reseeding the CRNG periodically, arch_get_random_seed_long() is > > called to obtain entropy from an architecture specific source if one > > is implemented. In most

Re: [PATCH] random: avoid arch_get_random_seed_long() when collecting IRQ randomness

2020-11-11 Thread Ard Biesheuvel
On Wed, 11 Nov 2020 at 11:46, André Przywara wrote: > > On 11/11/2020 10:05, Ard Biesheuvel wrote: > > Hi, > > > On Wed, 11 Nov 2020 at 10:45, André Przywara wrote: > >> > >> On 11/11/2020 08:19, Ard Biesheuvel wrote: > >> > >> Hi, > >> > >>> (+ Eric) > >>> > >>> On Thu, 5 Nov 2020 at 16:29, Ard

Re: [PATCH] random: avoid arch_get_random_seed_long() when collecting IRQ randomness

2020-11-11 Thread André Przywara
On 11/11/2020 10:05, Ard Biesheuvel wrote: Hi, > On Wed, 11 Nov 2020 at 10:45, André Przywara wrote: >> >> On 11/11/2020 08:19, Ard Biesheuvel wrote: >> >> Hi, >> >>> (+ Eric) >>> >>> On Thu, 5 Nov 2020 at 16:29, Ard Biesheuvel wrote: When reseeding the CRNG periodically, arch_get_ran

Re: [PATCH] random: avoid arch_get_random_seed_long() when collecting IRQ randomness

2020-11-11 Thread Ard Biesheuvel
On Wed, 11 Nov 2020 at 10:45, André Przywara wrote: > > On 11/11/2020 08:19, Ard Biesheuvel wrote: > > Hi, > > > (+ Eric) > > > > On Thu, 5 Nov 2020 at 16:29, Ard Biesheuvel wrote: > >> > >> When reseeding the CRNG periodically, arch_get_random_seed_long() is > >> called to obtain entropy from an

Re: [PATCH] random: avoid arch_get_random_seed_long() when collecting IRQ randomness

2020-11-11 Thread André Przywara
On 11/11/2020 08:19, Ard Biesheuvel wrote: Hi, > (+ Eric) > > On Thu, 5 Nov 2020 at 16:29, Ard Biesheuvel wrote: >> >> When reseeding the CRNG periodically, arch_get_random_seed_long() is >> called to obtain entropy from an architecture specific source if one >> is implemented. In most cases, t

Re: [PATCH] random: avoid arch_get_random_seed_long() when collecting IRQ randomness

2020-11-11 Thread Ard Biesheuvel
(+ Eric) On Thu, 5 Nov 2020 at 16:29, Ard Biesheuvel wrote: > > When reseeding the CRNG periodically, arch_get_random_seed_long() is > called to obtain entropy from an architecture specific source if one > is implemented. In most cases, these are special instructions, but in > some cases, such as

[PATCH] random: avoid arch_get_random_seed_long() when collecting IRQ randomness

2020-11-05 Thread Ard Biesheuvel
When reseeding the CRNG periodically, arch_get_random_seed_long() is called to obtain entropy from an architecture specific source if one is implemented. In most cases, these are special instructions, but in some cases, such as on ARM, we may want to back this using firmware calls, which are consid