... and clean up the comments to better explain why it's acceptable to
do it this way instead of using rb_erase() "properly".
Signed-off-by: David Woodhouse
---
On Wed, 2012-07-18 at 12:40 +0100, David Woodhouse wrote:
> If you're going to make that comment redundant, you might as well remove
>
On Wed, 2012-07-18 at 04:31 -0700, Michel Lespinasse wrote:
> Fix this and add a comment explaining why this direct use is safe
> here.
Note that there was already a comment which was *intended* to have that
effect, right before the assignment:
/* Colour doesn't matter now. Only the
When renaming rb_parent_color into __rb_parent_color to highlight the
fact that people aren't expected to directly manipulate this, I broke
the jffs2 build which was doing such direct manipulation in
fs/jffs2/readinode.c . Fix this and add a comment explaining why
this direct use is safe here.
When renaming rb_parent_color into __rb_parent_color to highlight the
fact that people aren't expected to directly manipulate this, I broke
the jffs2 build which was doing such direct manipulation in
fs/jffs2/readinode.c . Fix this and add a comment explaining why
this direct use is safe here.
On Wed, 2012-07-18 at 04:31 -0700, Michel Lespinasse wrote:
Fix this and add a comment explaining why this direct use is safe
here.
Note that there was already a comment which was *intended* to have that
effect, right before the assignment:
/* Colour doesn't matter now. Only the parent
... and clean up the comments to better explain why it's acceptable to
do it this way instead of using rb_erase() properly.
Signed-off-by: David Woodhouse david.woodho...@intel.com
---
On Wed, 2012-07-18 at 12:40 +0100, David Woodhouse wrote:
If you're going to make that comment redundant, you
6 matches
Mail list logo
