Re: [PATCH] regmap: Fix compile warning with value uninitialized

2013-11-09 Thread Levente Kurusa
2013-11-09 19:57 keltezéssel, Mark Brown írta: > On Sat, Nov 09, 2013 at 04:34:07PM +0100, Levente Kurusa wrote: >> 2013-11-09 16:16 keltezéssel, Mark Brown írta: > - int i, ret; + int i; + int ret = 0; bool bypass; > >> Wouldn't the following be better? > >> int i,

Re: [PATCH] regmap: Fix compile warning with value uninitialized

2013-11-09 Thread Mark Brown
On Sat, Nov 09, 2013 at 04:34:07PM +0100, Levente Kurusa wrote: > 2013-11-09 16:16 keltezéssel, Mark Brown írta: > >> - int i, ret; > >> + int i; > >> + int ret = 0; > >>bool bypass; > Wouldn't the following be better? > int i, ret = 0; > I think it is more readable. No, that's not the

Re: [PATCH] regmap: Fix compile warning with value uninitialized

2013-11-09 Thread Greg Kroah-Hartman
On Sat, Nov 09, 2013 at 04:34:07PM +0100, Levente Kurusa wrote: > 2013-11-09 16:16 keltezéssel, Mark Brown írta: > > On Sat, Nov 09, 2013 at 09:49:11AM +, Caizhiyong wrote: > > > >> @@ -2170,7 +2170,8 @@ int regmap_register_patch(struct regmap *map, const > >> struct reg_default *regs, > >>

Re: [PATCH] regmap: Fix compile warning with value uninitialized

2013-11-09 Thread Levente Kurusa
2013-11-09 16:16 keltezéssel, Mark Brown írta: > On Sat, Nov 09, 2013 at 09:49:11AM +, Caizhiyong wrote: > >> @@ -2170,7 +2170,8 @@ int regmap_register_patch(struct regmap *map, const >> struct reg_default *regs, >>int num_regs) >> { >> struct reg_default *p; >>

Re: [PATCH] regmap: Fix compile warning with value uninitialized

2013-11-09 Thread Mark Brown
On Sat, Nov 09, 2013 at 09:49:11AM +, Caizhiyong wrote: > @@ -2170,7 +2170,8 @@ int regmap_register_patch(struct regmap *map, const > struct reg_default *regs, > int num_regs) > { > struct reg_default *p; > - int i, ret; > + int i; > + int ret = 0;

[PATCH] regmap: Fix compile warning with value uninitialized

2013-11-09 Thread Caizhiyong
From: Cai Zhiyong Date: Sat, 9 Nov 2013 14:14:36 +0800 Subject: [PATCH] regmap: Fix compile warning with value uninitialized Fix compile warning with value uninitialized: drivers/base/regmap/regmap.c:2173: warning: 'ret' may be used uninitialized in this function Signed-off-by: Cai Zhiyong

[PATCH] regmap: Fix compile warning with value uninitialized

2013-11-09 Thread Caizhiyong
From: Cai Zhiyong caizhiy...@huawei.com Date: Sat, 9 Nov 2013 14:14:36 +0800 Subject: [PATCH] regmap: Fix compile warning with value uninitialized Fix compile warning with value uninitialized: drivers/base/regmap/regmap.c:2173: warning: 'ret' may be used uninitialized in this function Signed

Re: [PATCH] regmap: Fix compile warning with value uninitialized

2013-11-09 Thread Mark Brown
On Sat, Nov 09, 2013 at 09:49:11AM +, Caizhiyong wrote: @@ -2170,7 +2170,8 @@ int regmap_register_patch(struct regmap *map, const struct reg_default *regs, int num_regs) { struct reg_default *p; - int i, ret; + int i; + int ret = 0;

Re: [PATCH] regmap: Fix compile warning with value uninitialized

2013-11-09 Thread Levente Kurusa
2013-11-09 16:16 keltezéssel, Mark Brown írta: On Sat, Nov 09, 2013 at 09:49:11AM +, Caizhiyong wrote: @@ -2170,7 +2170,8 @@ int regmap_register_patch(struct regmap *map, const struct reg_default *regs, int num_regs) { struct reg_default *p; -int i,

Re: [PATCH] regmap: Fix compile warning with value uninitialized

2013-11-09 Thread Greg Kroah-Hartman
On Sat, Nov 09, 2013 at 04:34:07PM +0100, Levente Kurusa wrote: 2013-11-09 16:16 keltezéssel, Mark Brown írta: On Sat, Nov 09, 2013 at 09:49:11AM +, Caizhiyong wrote: @@ -2170,7 +2170,8 @@ int regmap_register_patch(struct regmap *map, const struct reg_default *regs,

Re: [PATCH] regmap: Fix compile warning with value uninitialized

2013-11-09 Thread Mark Brown
On Sat, Nov 09, 2013 at 04:34:07PM +0100, Levente Kurusa wrote: 2013-11-09 16:16 keltezéssel, Mark Brown írta: - int i, ret; + int i; + int ret = 0; bool bypass; Wouldn't the following be better? int i, ret = 0; I think it is more readable. No, that's not the kernel coding

Re: [PATCH] regmap: Fix compile warning with value uninitialized

2013-11-09 Thread Levente Kurusa
2013-11-09 19:57 keltezéssel, Mark Brown írta: On Sat, Nov 09, 2013 at 04:34:07PM +0100, Levente Kurusa wrote: 2013-11-09 16:16 keltezéssel, Mark Brown írta: - int i, ret; + int i; + int ret = 0; bool bypass; Wouldn't the following be better? int i, ret = 0; I think it is