Re: [PATCH] regulator: Add lockdep asserts to help detecting locking misuse

2015-08-19 Thread Krzysztof Kozlowski
On 19.08.2015 22:08, Geert Uytterhoeven wrote: > Hi Krzysztof, > > On Wed, Jun 10, 2015 at 8:23 AM, Krzysztof Kozlowski > wrote: >> Add lockdep_assert_held_once() to functions explicitly mentioning that >> rdev or regulator_list mutex must be held. Using WARN_ONCE shouldn't >> pollute the dmesg

Re: [PATCH] regulator: Add lockdep asserts to help detecting locking misuse

2015-08-19 Thread Mark Brown
On Wed, Aug 19, 2015 at 03:08:34PM +0200, Geert Uytterhoeven wrote: > Drivers calling regulator_notifier_call_chain() from a threaded interrupt > handler should be OK calling mutex_lock(). > Does anyone have plans to fix all affected drivers? I'm not aware of anyone who's shown an interest.

Re: [PATCH] regulator: Add lockdep asserts to help detecting locking misuse

2015-08-19 Thread Geert Uytterhoeven
Hi Krzysztof, On Wed, Jun 10, 2015 at 8:23 AM, Krzysztof Kozlowski wrote: > Add lockdep_assert_held_once() to functions explicitly mentioning that > rdev or regulator_list mutex must be held. Using WARN_ONCE shouldn't > pollute the dmesg to much. > > The patch (if CONFIG_LOCKDEP enabled) will

Re: [PATCH] regulator: Add lockdep asserts to help detecting locking misuse

2015-08-19 Thread Geert Uytterhoeven
Hi Krzysztof, On Wed, Jun 10, 2015 at 8:23 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Add lockdep_assert_held_once() to functions explicitly mentioning that rdev or regulator_list mutex must be held. Using WARN_ONCE shouldn't pollute the dmesg to much. The patch (if

Re: [PATCH] regulator: Add lockdep asserts to help detecting locking misuse

2015-08-19 Thread Mark Brown
On Wed, Aug 19, 2015 at 03:08:34PM +0200, Geert Uytterhoeven wrote: Drivers calling regulator_notifier_call_chain() from a threaded interrupt handler should be OK calling mutex_lock(). Does anyone have plans to fix all affected drivers? I'm not aware of anyone who's shown an interest.

Re: [PATCH] regulator: Add lockdep asserts to help detecting locking misuse

2015-08-19 Thread Krzysztof Kozlowski
On 19.08.2015 22:08, Geert Uytterhoeven wrote: Hi Krzysztof, On Wed, Jun 10, 2015 at 8:23 AM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Add lockdep_assert_held_once() to functions explicitly mentioning that rdev or regulator_list mutex must be held. Using WARN_ONCE shouldn't

[RESEND PATCH] regulator: Add lockdep asserts to help detecting locking misuse

2015-06-28 Thread Krzysztof Kozlowski
Add lockdep_assert_held_once() to functions explicitly mentioning that rdev or regulator_list mutex must be held. Using WARN_ONCE shouldn't pollute the dmesg to much. The patch (if CONFIG_LOCKDEP enabled) will show warnings in certain regulators calling regulator_notifier_call_chain() without

[RESEND PATCH] regulator: Add lockdep asserts to help detecting locking misuse

2015-06-28 Thread Krzysztof Kozlowski
Add lockdep_assert_held_once() to functions explicitly mentioning that rdev or regulator_list mutex must be held. Using WARN_ONCE shouldn't pollute the dmesg to much. The patch (if CONFIG_LOCKDEP enabled) will show warnings in certain regulators calling regulator_notifier_call_chain() without

Re: [PATCH] regulator: Add lockdep asserts to help detecting locking misuse

2015-06-10 Thread Mark Brown
On Wed, Jun 10, 2015 at 03:23:12PM +0900, Krzysztof Kozlowski wrote: > Add lockdep_assert_held_once() to functions explicitly mentioning that > rdev or regulator_list mutex must be held. Using WARN_ONCE shouldn't > pollute the dmesg to much. Applied, thanks. signature.asc Description: Digital

[PATCH] regulator: Add lockdep asserts to help detecting locking misuse

2015-06-10 Thread Krzysztof Kozlowski
Add lockdep_assert_held_once() to functions explicitly mentioning that rdev or regulator_list mutex must be held. Using WARN_ONCE shouldn't pollute the dmesg to much. The patch (if CONFIG_LOCKDEP enabled) will show warnings in certain regulators calling regulator_notifier_call_chain() without

Re: [PATCH] regulator: Add lockdep asserts to help detecting locking misuse

2015-06-10 Thread Mark Brown
On Wed, Jun 10, 2015 at 03:23:12PM +0900, Krzysztof Kozlowski wrote: Add lockdep_assert_held_once() to functions explicitly mentioning that rdev or regulator_list mutex must be held. Using WARN_ONCE shouldn't pollute the dmesg to much. Applied, thanks. signature.asc Description: Digital

[PATCH] regulator: Add lockdep asserts to help detecting locking misuse

2015-06-10 Thread Krzysztof Kozlowski
Add lockdep_assert_held_once() to functions explicitly mentioning that rdev or regulator_list mutex must be held. Using WARN_ONCE shouldn't pollute the dmesg to much. The patch (if CONFIG_LOCKDEP enabled) will show warnings in certain regulators calling regulator_notifier_call_chain() without