Re: [PATCH] regulator: Fix deadlock during regulator registration

2016-03-30 Thread Javier Martinez Canillas
Hello Mark, On 03/30/2016 07:34 PM, Mark Brown wrote: > On Wed, Mar 30, 2016 at 07:25:49PM -0400, Javier Martinez Canillas wrote: > >> You are doing some cleanup of the clean and scrub error paths by removing >> rdev and returning ERR_PTR(ret) directly. I believe that should be in a >> separate

Re: [PATCH] regulator: Fix deadlock during regulator registration

2016-03-30 Thread Javier Martinez Canillas
Hello Mark, On 03/30/2016 07:34 PM, Mark Brown wrote: > On Wed, Mar 30, 2016 at 07:25:49PM -0400, Javier Martinez Canillas wrote: > >> You are doing some cleanup of the clean and scrub error paths by removing >> rdev and returning ERR_PTR(ret) directly. I believe that should be in a >> separate

Re: [PATCH] regulator: Fix deadlock during regulator registration

2016-03-30 Thread Mark Brown
On Wed, Mar 30, 2016 at 07:25:49PM -0400, Javier Martinez Canillas wrote: > You are doing some cleanup of the clean and scrub error paths by removing > rdev and returning ERR_PTR(ret) directly. I believe that should be in a > separate patch since is not related to the fix. There needs to be some

Re: [PATCH] regulator: Fix deadlock during regulator registration

2016-03-30 Thread Mark Brown
On Wed, Mar 30, 2016 at 07:25:49PM -0400, Javier Martinez Canillas wrote: > You are doing some cleanup of the clean and scrub error paths by removing > rdev and returning ERR_PTR(ret) directly. I believe that should be in a > separate patch since is not related to the fix. There needs to be some

Re: [PATCH] regulator: Fix deadlock during regulator registration

2016-03-30 Thread Javier Martinez Canillas
Hello Jon, On 03/30/2016 12:09 PM, Jon Hunter wrote: > Commit 5e3ca2b349b1 ("regulator: Try to resolve regulators supplies on > registration") added a call to regulator_resolve_supply() within > regulator_register() where the regulator_list_mutex is held. This causes > the following deadlock to

Re: [PATCH] regulator: Fix deadlock during regulator registration

2016-03-30 Thread Javier Martinez Canillas
Hello Jon, On 03/30/2016 12:09 PM, Jon Hunter wrote: > Commit 5e3ca2b349b1 ("regulator: Try to resolve regulators supplies on > registration") added a call to regulator_resolve_supply() within > regulator_register() where the regulator_list_mutex is held. This causes > the following deadlock to

Re: [PATCH] regulator: Fix deadlock during regulator registration

2016-03-30 Thread Jon Hunter
On 30/03/16 18:00, Mark Brown wrote: > * PGP Signed by an unknown key > > On Wed, Mar 30, 2016 at 05:46:05PM +0100, Jon Hunter wrote: > > Please fix your mail client to word wrap within paragraphs at something > substantially less than 80 columns. Doing this makes your messages much > easier

Re: [PATCH] regulator: Fix deadlock during regulator registration

2016-03-30 Thread Jon Hunter
On 30/03/16 18:00, Mark Brown wrote: > * PGP Signed by an unknown key > > On Wed, Mar 30, 2016 at 05:46:05PM +0100, Jon Hunter wrote: > > Please fix your mail client to word wrap within paragraphs at something > substantially less than 80 columns. Doing this makes your messages much > easier

Re: [PATCH] regulator: Fix deadlock during regulator registration

2016-03-30 Thread Mark Brown
On Wed, Mar 30, 2016 at 05:46:05PM +0100, Jon Hunter wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > > Please don't paste entire backlogs into changelogs,

Re: [PATCH] regulator: Fix deadlock during regulator registration

2016-03-30 Thread Mark Brown
On Wed, Mar 30, 2016 at 05:46:05PM +0100, Jon Hunter wrote: Please fix your mail client to word wrap within paragraphs at something substantially less than 80 columns. Doing this makes your messages much easier to read and reply to. > > Please don't paste entire backlogs into changelogs,

Re: [PATCH] regulator: Fix deadlock during regulator registration

2016-03-30 Thread Jon Hunter
On 30/03/16 17:18, Mark Brown wrote: > * PGP Signed by an unknown key > > On Wed, Mar 30, 2016 at 05:09:13PM +0100, Jon Hunter wrote: > >> INFO: task swapper/0:1 blocked for more than 120 seconds. >> Not tainted 4.6.0-rc1-1-g5e3ca2b-dirty #290 >> "echo 0 >

Re: [PATCH] regulator: Fix deadlock during regulator registration

2016-03-30 Thread Jon Hunter
On 30/03/16 17:18, Mark Brown wrote: > * PGP Signed by an unknown key > > On Wed, Mar 30, 2016 at 05:09:13PM +0100, Jon Hunter wrote: > >> INFO: task swapper/0:1 blocked for more than 120 seconds. >> Not tainted 4.6.0-rc1-1-g5e3ca2b-dirty #290 >> "echo 0 >

Re: [PATCH] regulator: Fix deadlock during regulator registration

2016-03-30 Thread Mark Brown
On Wed, Mar 30, 2016 at 05:09:13PM +0100, Jon Hunter wrote: > INFO: task swapper/0:1 blocked for more than 120 seconds. > Not tainted 4.6.0-rc1-1-g5e3ca2b-dirty #290 > "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. > swapper/0 D c07daeac 0 1 0 0x > []

Re: [PATCH] regulator: Fix deadlock during regulator registration

2016-03-30 Thread Mark Brown
On Wed, Mar 30, 2016 at 05:09:13PM +0100, Jon Hunter wrote: > INFO: task swapper/0:1 blocked for more than 120 seconds. > Not tainted 4.6.0-rc1-1-g5e3ca2b-dirty #290 > "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this message. > swapper/0 D c07daeac 0 1 0 0x > []

[PATCH] regulator: Fix deadlock during regulator registration

2016-03-30 Thread Jon Hunter
Commit 5e3ca2b349b1 ("regulator: Try to resolve regulators supplies on registration") added a call to regulator_resolve_supply() within regulator_register() where the regulator_list_mutex is held. This causes the following deadlock to occur on the Tegra114 Dalmore board when the palmas PMIC is

[PATCH] regulator: Fix deadlock during regulator registration

2016-03-30 Thread Jon Hunter
Commit 5e3ca2b349b1 ("regulator: Try to resolve regulators supplies on registration") added a call to regulator_resolve_supply() within regulator_register() where the regulator_list_mutex is held. This causes the following deadlock to occur on the Tegra114 Dalmore board when the palmas PMIC is